oxen-io/session-ios
1
0
Fork 0
mirror of https://github.com/oxen-io/session-ios.git synced 2023-12-13 21:30:14 +01:00
Code Issues Projects Releases Wiki Activity
11281 commits 5 branches 133 tags 218 MiB
Commit graph

408 commits

Author SHA1 Message Date
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 2019-03-25 09:31:19 -04:00
Matthew Chen 95e125d55e Simplify usage of accessibilityIdentifiers. 2019-03-25 09:31:19 -04:00
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack. 
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
 2019-03-21 10:37:54 -07:00
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 2019-03-21 10:55:04 -04:00
Matthew Chen c9d62f47cc Respond to CR. 2019-03-21 10:26:38 -04:00
Matthew Chen d7b1e65a71 Add accessibility identifiers to blocklist popups. 2019-03-21 10:08:25 -04:00
Matthew Chen f1520d760e Add accessibility identifiers to other settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen b48e204b90 Add accessibility identifiers to notification settings views. 2019-03-21 10:08:25 -04:00
Michael Kirk 0b638f4831 link checks 2019-03-18 15:21:19 -07:00
Michael Kirk 78ce3583ed fix rotation issue 2019-03-18 15:17:13 -07:00
Matthew Chen 88c07fc534 Pinch to change text size in image editor text tool. 2019-03-13 11:41:44 -04:00
Michael Kirk 71dd4eb151 in-conversation search 
- use MediaTime for computing benchmarks
 2019-02-28 16:19:16 -07:00
Michael Kirk 870caaa84a simplify completion checking - make nonnull 2019-02-26 10:06:52 -07:00
Michael Kirk 13154fb828 allow long text with non-durable sends (SAE) 2019-02-26 10:06:52 -07:00
Matthew Chen 56e5feca46 Introduce ConversationSnapshot. 2019-02-26 10:55:44 -05:00
Michael Kirk f1623b6037 missing nullability text 2019-02-25 13:27:49 -07:00
Michael Kirk 7e5256856c render media+longText message 2019-02-25 13:27:49 -07:00
Michael Kirk b7989e9384 feature flag approval sending 2019-02-25 13:27:49 -07:00
Michael Kirk bc4260b444 Send long-text with other attachments 2019-02-25 13:27:49 -07:00
Michael Kirk a218d6c465 Send first chars of longtext in protobuf 2019-02-25 13:27:49 -07:00
Michael Kirk 680b844f3c Allow all windows to do landscape, fixes: 
1. Remove undesirable animation from portrait->landscape when minimizizing in
   landscape and relaunching in landscape.

2. This also seems to fix the intermittently misplaced toolbar when launching
   in landscape. I believe this is a consequence of fix #1
 2019-02-21 17:38:52 -07:00
Michael Kirk fabd3996c2 pop view if message is deleted 
- use global ui database connection
 2019-02-21 16:18:14 -07:00
Matthew Chen 9402e088b2 Apply design feedback from Myles. 2019-02-21 14:16:31 -05:00
Matthew Chen 8ecad88674 Move the accessibility identifier macros into UIUtil.h. 2019-02-19 16:11:36 -05:00
Matthew Chen 73b36c5400 Respond to CR. 2019-02-12 10:03:32 -05:00
Michael Kirk cc2e062b85 CR: clean up graphics context code 2019-02-07 08:43:12 -07:00
Michael Kirk 2323cc21f0 note-to-self avatar 2019-02-07 08:34:48 -07:00
Matthew Chen 12e57ecd25 Improve background screenshots v. orientation. 2019-01-31 10:14:06 -05:00
Matthew Chen 9149282e94 Resize link preview images if necessary. 2019-01-24 13:28:54 -05:00
Matthew Chen 4e7dbc486d Segment proxied content downloads. 2019-01-24 08:51:25 -05:00
Matthew Chen 3d757b492a Add link previews to conversation message bubbles. 2019-01-23 09:32:30 -05:00
Matthew Chen 977ee9ffe9 Merge remote-tracking branch 'private/release/2.34.0' 2019-01-22 11:10:04 -05:00
Matthew Chen 2dcc79fbca Fix issues around link previews. 2019-01-22 10:15:50 -05:00
Matthew Chen 8e44bf554c Respond to CR. 2019-01-22 09:42:25 -05:00
Matthew Chen d775a70a89 Build link previews. 2019-01-22 09:42:25 -05:00
Matthew Chen 31ea64bdaf Build link previews. 2019-01-22 09:42:25 -05:00
Matthew Chen 7878c0fac8 Add feature flag for 'note to self'. 2019-01-18 17:22:12 -05:00
Michael Kirk 0c1b2e9f48 CR: remove unnecessary param, clearer code, comment typo 2019-01-17 09:47:01 -07:00
Michael Kirk 6e50a5353b rename for clarity 2019-01-16 17:06:37 -07:00
Michael Kirk b4908e71e9 Use FTS for compose picker search 2019-01-16 14:39:35 -07:00
Matthew Chen a477e01a4a Apply LinkPreview model. 2019-01-14 16:20:54 -05:00
Matthew Chen bf0d92acfb Landscape layout in gif picker. 2019-01-10 12:04:12 -05:00
Matthew Chen 2ddde368ec Landscape orientation. 2019-01-09 15:22:55 -05:00
Matthew Chen 5adcbac5ef Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen 9ab8bec2b1 Fix searching for 'note to self'. 2019-01-07 08:45:42 -05:00
Michael Kirk af7ee5e1d1 address compiler breakage after rebase 2018-12-19 15:16:36 -07:00
Michael Kirk 5671fd2520 Revert "Revert 'new sort id'." 
This reverts commit ebae75af00.
 2018-12-19 15:16:36 -07:00
Matthew Chen 35b6f6cf12 Respond to CR. 2018-12-19 15:08:28 -05:00
Matthew Chen db8bc58b6d Implement crop. 2018-12-19 14:48:37 -05:00
Matthew Chen bd40aacd53 Purge dynamic interactions from database. 2018-12-18 10:55:54 -05:00