Commit graph

1063 commits

Author SHA1 Message Date
Matthew Chen
d70aa4418f Merge branch 'release/2.32.0' 2018-12-03 22:20:50 -05:00
Matthew Chen
894fd1379c Fix spurious assert. 2018-12-03 22:06:38 -05:00
Matthew Chen
aa4fea64cf Improve Profiles Debug UI. 2018-12-03 22:02:03 -05:00
Matthew Chen
d6ca969c62 Backup local profile. 2018-11-29 09:10:27 -05:00
Matthew Chen
c7f5047056 Handle iCloud status. 2018-11-29 08:57:51 -05:00
Michael Kirk
128bb9be8c Merge tag '2.32.0.17' 2018-11-28 22:15:39 -07:00
Michael Kirk
71ab5817eb fix captionview visibility 2018-11-28 21:23:31 -07:00
Matthew Chen
c5744321ba Backup misc collections. 2018-11-28 17:05:08 -05:00
Matthew Chen
4556025566 Update migrations. 2018-11-28 16:01:12 -05:00
Michael Kirk
61758dcf05 Only show caption for multiple images 2018-11-27 15:39:45 -07:00
Michael Kirk
0ac8f13c0b remove redunant method, consolidate naming, adding array getter 2018-11-27 15:39:45 -07:00
Michael Kirk
6fdd5d1001 dont initializer pagerScrollView as sideEffect 2018-11-27 15:39:45 -07:00
Michael Kirk
9bcc6a6c57 show navbar for photo/album picker, not approval 2018-11-27 10:27:13 -07:00
Matthew Chen
dcaaff7eac Add isRegisteredAndReady to TSAccountManager. 2018-11-27 09:21:44 -05:00
Matthew Chen
8110e0c765 Clean up usage of TSAccountManager. 2018-11-27 09:21:44 -05:00
Michael Kirk
26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 2018-11-26 14:11:13 -07:00
Michael Kirk
78c74d87bc Merge tag '2.32.0.16' 2018-11-26 13:03:27 -07:00
Michael Kirk
9317ee9c99 design comment 2018-11-26 12:57:50 -07:00
Michael Kirk
e3120a5b87 cleanup keyboard animation code 2018-11-26 12:52:05 -07:00
Michael Kirk
0562619ca9 smaller margins between rail images, avoid choppy change as the margin updates
are not being animated smoothly.
2018-11-26 12:43:28 -07:00
Michael Kirk
55807f9a4d iPhoneX compatible keyboard animations 2018-11-26 12:43:28 -07:00
Michael Kirk
279694e704 keyboard animation cleanup 2018-11-26 12:43:28 -07:00
Michael Kirk
0808458392 fix caption dismiss animation/placeholder for multiline message body 2018-11-26 12:43:28 -07:00
Michael Kirk
4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
2018-11-26 12:43:28 -07:00
Michael Kirk
3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 2018-11-26 12:43:28 -07:00
Michael Kirk
b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
2018-11-26 12:43:28 -07:00
Michael Kirk
838012d1ec Caption length limit and label 2018-11-26 12:43:28 -07:00
Michael Kirk
e0f7513df0 white tint for attachment approval textview cursors 2018-11-26 12:43:28 -07:00
Michael Kirk
a946ec0056 new icon assets per design 2018-11-26 12:43:28 -07:00
Michael Kirk
8776dd1909 New "add caption" and "done" assets 2018-11-26 12:43:28 -07:00
Michael Kirk
feb5a0c444 fix initial CaptionView layout glitch 2018-11-26 12:43:28 -07:00
Michael Kirk
e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 2018-11-26 12:43:28 -07:00
Michael Kirk
33750baf67 finally got dismiss-before-swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
dd82803a10 second abandoned attempt to require dismiss before page 2018-11-26 12:43:28 -07:00
Michael Kirk
b98b3d1fdd WIP: require dismiss before swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
706dd3d0c1 initial layout of keyboard is correct across pages 2018-11-26 12:43:28 -07:00
Michael Kirk
280664c763 WIP: keyboard 2018-11-26 12:43:28 -07:00
Michael Kirk
eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
2018-11-26 12:43:28 -07:00
Michael Kirk
8b5d1d9e69 Only add delete button once 2018-11-26 12:43:28 -07:00
Michael Kirk
28f8fc5911 per cr, avoid unnecessary 2018-11-26 12:37:58 -07:00
Michael Kirk
fcc4b516a5 fix typo in logging 2018-11-26 12:37:58 -07:00
Michael Kirk
4f0092615a Support captions *and* independent message body 2018-11-26 12:37:58 -07:00
Michael Kirk
cd88ef2bec CaptionView text field per page 2018-11-26 12:37:58 -07:00
Michael Kirk
79995cc52c rename captioning -> messageText
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Michael Kirk
47affb81c0 Move gallery rail into input accessory view
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Matthew Chen
544bdbd7f5 Fix edge cases around registration. 2018-11-26 09:58:59 -05:00
Matthew Chen
3edf3ed199 Don't use UD for "self" profile fetches. 2018-11-26 09:19:12 -05:00
Michael Kirk
31782af2f1 dark theme section headers in tile gallery 2018-11-25 18:03:20 -06:00
Michael Kirk
6cdef57e2a Merge tag '2.32.0.15' 2018-11-25 12:54:59 -06:00
Michael Kirk
18766280f6 fix crash when non-registered user upgrades 2018-11-23 11:38:51 -06:00