Commit graph

52 commits

Author SHA1 Message Date
Niels Andriesse
aeb3cecf55 WIP 2019-05-03 07:58:48 +10:00
Michael Kirk
7cf53293da restore Share/Delete functionality to gallery items in the post multi-attachment world 2018-11-08 12:52:09 -06:00
Michael Kirk
57681bd6f3 Gallery supports album messages 2018-11-08 12:52:09 -06:00
Michael Kirk
06eae47e09 ConversationViewItem -> protocol 2018-09-28 12:58:33 -06:00
Matthew Chen
f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 2018-09-07 15:27:50 -04:00
Michael Kirk
c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
2018-09-07 10:00:48 -06:00
Matthew Chen
1c325cd210 Respond to CR. 2018-09-06 16:03:29 -04:00
Matthew Chen
b1f2b9e75c Clean up thumbnail-related logic. 2018-09-06 16:03:29 -04:00
Matthew Chen
5d96af98bc Use large thumbnail in media views. 2018-09-06 16:03:29 -04:00
Matthew Chen
a2fad57964 Load GIFs from disk in media view; don't cache GIF data in memory. 2018-09-06 16:03:29 -04:00
Matthew Chen
12307aeeed Load GIFs from disk in media view; don't cache GIF data in memory. 2018-09-06 16:03:29 -04:00
Matthew Chen
446ceb2b9c Rename AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen
498828f93c Rename AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen
f473f60111 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
c0d486b1f1 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Michael Kirk
c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
2018-08-09 15:30:19 -06:00
Michael Kirk
8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
2018-07-16 10:20:05 -06:00
Michael Kirk
42eb7a8d31 cleanup unused code 2018-07-13 13:00:27 -06:00
Michael Kirk
9496bedce1 remove redundant menu controller from media detail
You can already copy/save/delete from toolbar, which is a much cleaner
implementation
2018-07-13 13:00:27 -06:00
Michael Kirk
2552368146 add text reply action, comment out more deprecated uimenu code 2018-07-13 13:00:27 -06:00
Michael Kirk
104e63ded9 remove appearance juggling 2018-06-29 16:27:37 -06:00
Matthew Chen
1607aa7f57 Image content types. 2018-06-20 17:13:31 -04:00
Michael Kirk
fda5d65674 Avoid crash - reply only works from ConversationVC
// FREEBIE
2018-05-08 13:56:28 -04:00
Matthew Chen
644e78f19d Respond to CR. 2018-04-13 14:32:42 -04:00
Michael Kirk
1d95cd6977 Improve video scrubbing UX in PageView
// FREEBIE
2018-03-27 10:16:18 -04:00
Michael Kirk
6c877403cf Fix delete from message details
// FREEBIE
2018-03-22 19:54:19 -04:00
Michael Kirk
6e20f5b654 Fix Delete
from conversation settings > tile > tap for details > delete

TODO:

- Don't dismiss pager, show next item
- dismiss pager if deleting last media

// FREEBIE
2018-03-22 19:52:52 -04:00
Michael Kirk
428802aee8 Only try to stop video when it *is* a video
// FREEBIE
2018-03-19 20:30:19 -04:00
Michael Kirk
24eb4bf443 Stop any video whenever leaving PageView
// FREEBIE
2018-03-19 20:15:47 -04:00
Michael Kirk
4c2d30a776 Memory warning clears MediaPageView cache
Doing so required MediaDetailView to retain GalleryItem, but because
GalleryItem is a swift struct, I had to envoke the Box dance.

// FREEBIE
2018-03-19 18:57:10 -04:00
Michael Kirk
4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
2018-03-16 15:55:34 -04:00
Michael Kirk
88e1386720 Move frame to presentation logic, out of init
This no longer made sense now that we're using this in a
PageViewController we won't always be zooming from a particular frame.

TODO:

- why is background image all wonky?
- why aren't views created by the time it's presented? Is that a
regression? (how is self.view a MenuView if loadView hasn't been called)

// FREEBIE
2018-03-14 12:50:27 -04:00
Matthew Chen
59c745756a Clean up codebase. 2018-03-02 15:05:14 -05:00
Matthew Chen
99aedca45f Strip out special casing for pre-iOS 9 users. 2018-02-26 14:13:38 -05:00
Michael Kirk
c6e5d4369b Don't adjust inset when fully zoomed in.
On iOS11, when looking at the full-screen media details, if you'd zoomed
far enough that the media content is behind the status bar, tapping to
hide the status bar would cause an undesirable change in content offset.

// FREEBIE
2018-02-14 09:05:05 -08:00
Michael Kirk
c646f76335 Garther audio concerns, clean up session when done
- sync speakerphone state manipulated from system call screen
  - Revert audio session after call failure, ensures media plays out of
    speaker after placing a failing call.
  - Replace notification with delegate pattern since we're already using
    delegate pattern here.
- Fixes voiceover accessibility after voice memo
- Avoid audio blip after pressing hangup
- Rename CallAudioSession -> OWSAudioSession
  Going to start using it for other non-call things since we want to
  gather all our audio session concerns.
- Resume background audio when done playing video
  - Extract OWSVideoPlayer which ensures audio is in proper state before
    playback
  - Move recording session logic to shared OWSAudioSession
  - Deactivate audio session when complete

// FREEBIE
2018-02-06 18:45:51 -08:00
Michael Kirk
e39ca59eeb Merge tag '2.19.5.0' 2018-02-01 14:03:43 -08:00
Michael Kirk
3a5fa63cd6 Fix confirmation preview
// FREEBIE
2018-01-19 15:34:11 -05:00
Michael Kirk
94d58b88b8 Play video inline in approval view
Previously we launched the MPMoviePlayerController

// FREEBIE
2018-01-16 17:57:14 -05:00
Michael Kirk
0c6a42003f clang-format after RI
// FREEBIE
2018-01-16 15:27:53 -05:00
Michael Kirk
a423fe8a0e WIP Merge tag '2.19.4.4'
- restore video playback in fullscreen

This was a large merge, so I'm opting to make some changes in separate
commits.
2018-01-16 15:25:58 -05:00
Michael Kirk
63c23b77d0 Cleanup presentation view, feels less blurry
// FREEBIE
2018-01-12 00:17:06 -05:00
Michael Kirk
1ef824029e Fix distorted images
// FREEBIE
2018-01-11 23:58:11 -05:00
Michael Kirk
3582ab42db Fix media detail presentation
- video view now scales during presentation
- no "swooping" when presenting large res images

// FREEBIE
2018-01-11 23:49:21 -05:00
Michael Kirk
7c2bfdfb1f rename: imageView -> mediaView
// FREEBIE
2018-01-11 23:05:59 -05:00
Michael Kirk
8851413b35 CR: cleanup, remove debug animation time, move constant
// FREEBIE
2018-01-11 23:05:59 -05:00
Michael Kirk
e140ffc423 Fullscreen presentation touchups
"zoom" presentation now accounts for zoomScale.

Fix background flicker as status bar hides
Round corners during presentation/dismiss. Smooths transition a bit.

// FREEBIE
2018-01-11 23:05:59 -05:00