Commit graph

5778 commits

Author SHA1 Message Date
Michael Kirk f0e1cea27c Merge branch 'mkirk/send-ice-updates-immediately' 2018-02-23 17:36:17 -05:00
Michael Kirk 5f305f844f Send ICE updates immediately after sending CallOffer for faster call
connection.

For legacy reasons, the call sender used to wait until after receiving
the call answer before sending the ICE updates. The primary motivation
was that if the receiving user hadn't accepted a new identity change,
rather than just seeing one "Tap to Accept New Safety Number" messages
for a call, they'd see one for the call offer and then a dozen more as
ICE updates trickled in.

We changed that behavior long ago, and effectively all clients will
avoid that case, while sending ICE updates immediately will allow calls
to connect without having to wait for an additional serialized round
trip between the caller and call recipient.

// FREEBIE
2018-02-23 17:36:07 -05:00
Michael Kirk 76aee05817 Merge branch 'mkirk/dont-send-sender-read-receipts-to-self' 2018-02-23 13:50:43 -05:00
Michael Kirk b79244affa Don't enqueue sender read receipts from self-sent messages
These messages are always already read.

Reminder, there are two types of read receipts:

1. One informs our linked devices that we've read a message on another
device.
2. The other informs the sender that we've read their message.

This change is about the latter, we'll continue to send the former to
ourself.

The proximate cause for this change was a failing assert in
OWSMessageSender#handleSendToMyself:(TSOutgoingMessage *)outgoingMessage

The assert was failing because we were sending a message to ourself
which had no body or attachment (the sender-read receipt). Rather than
filtering them out from the message sender, we should never ask the
message sender to do nonsense work (send a senderReadReceipt to ourself)

// FREEBIE
2018-02-23 13:50:40 -05:00
Michael Kirk c66fb70b2f Merge branch 'mkirk/use-contact-ringtones' 2018-02-23 13:49:11 -05:00
Michael Kirk e8c5509f3a Respect system contact ringtones
If CallKit privacy is enabled, we'll always use the system default
ringer.

If CallKit privacy is *not* enabled we'll use any ringtone specified in
the for that contact in the address book, else fall back to the default

// FREEBIE
2018-02-23 13:43:23 -05:00
Matthew Chen f7935bc363 Merge branch 'charlesmchen/customNotificationSounds2' 2018-02-23 12:54:24 -05:00
Matthew Chen 6c8a8fa098 Add new "note" audio asset for fallback push notifications. 2018-02-23 12:53:43 -05:00
Matthew Chen 0c20f2215a Improve sound settings view. 2018-02-23 12:53:43 -05:00
Matthew Chen e0144dab5f Improve sound settings view. 2018-02-23 12:53:43 -05:00
Matthew Chen 899799af92 Improve sound settings view. 2018-02-23 12:53:43 -05:00
Matthew Chen 5e8f3086de Update call sounds. 2018-02-23 12:53:43 -05:00
Matthew Chen a0f4723fa2 Update call sounds. 2018-02-23 12:53:43 -05:00
Matthew Chen a44a117612 Add custom ringtone sounds. 2018-02-23 12:53:43 -05:00
Matthew Chen cd32895657 Add UI for editing per-thread notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 396fe82707 Add UI for editing per-thread notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen dc8b8ca0bd Add per-thread custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 9aa02489b8 Custom notification sounds in local notifications. 2018-02-23 12:53:42 -05:00
Matthew Chen a837c5d41b Custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 60d839d7a4 Custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 5c3f6b0ee5 Custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 3d892abc46 "Bump build to 2.21.0.0." 2018-02-23 12:29:24 -05:00
Matthew Chen 03bea4fd8b "Bump build to 2.20.0.42." 2018-02-23 10:21:39 -05:00
Matthew Chen 9e3aa77fc6 Update l10n strings. 2018-02-23 10:21:33 -05:00
Matthew Chen cf39181d05 Merge branch 'mkirk/freeze-after-dismiss' 2018-02-23 10:19:53 -05:00
Michael Kirk 5af1123219 Fix freeze in host app after "dismissing" select thread VC
We must call these completion handlers whenever we exit the SAE

// FREEBIE
2018-02-23 10:15:34 -05:00
Matthew Chen 01cde6740c "Bump build to 2.20.0.41." 2018-02-22 16:43:11 -05:00
Matthew Chen fbab526b3c Update l10n strings. 2018-02-22 16:40:19 -05:00
Matthew Chen ff88f11738 Update l10n strings. 2018-02-22 16:34:00 -05:00
Matthew Chen ec32d8839b "Bump build to 2.20.0.40." 2018-02-22 16:31:37 -05:00
Matthew Chen e0793a0eae Merge branch 'charlesmchen/backgroundVsMigration' 2018-02-22 16:21:54 -05:00
Matthew Chen 5235f97953 Use background task while migrating. 2018-02-22 16:21:48 -05:00
Matthew Chen 8ec9540b8f Merge branch 'charlesmchen/handleCaptions' 2018-02-22 16:12:58 -05:00
Matthew Chen 10ca369da8 Respond to CR. 2018-02-22 16:12:39 -05:00
Matthew Chen 6006d22870 Improve handling of attachments with captions. 2018-02-22 16:03:00 -05:00
Matthew Chen 8576da791c Improve handling of attachments with captions. 2018-02-22 16:03:00 -05:00
Matthew Chen 96b5f22799 Improve handling of attachments with captions. 2018-02-22 16:03:00 -05:00
Matthew Chen d30dd22040 "Bump build to 2.20.0.39." 2018-02-22 13:31:45 -05:00
Matthew Chen 81629a87df Fix build break. 2018-02-22 13:31:41 -05:00
Matthew Chen 5e88110a0b "Bump build to 2.20.0.38." 2018-02-22 13:30:51 -05:00
Matthew Chen 8e9261e1ba "Bump build to 2.20.0.37." 2018-02-22 13:30:15 -05:00
Matthew Chen 708ff7efbd "Bump build to 2.20.0.36." 2018-02-22 13:28:23 -05:00
Matthew Chen 1112f7a644 Merge branch 'charlesmchen/conversationViewVsModifiedExternal' 2018-02-22 12:10:48 -05:00
Matthew Chen 152c570900 Respond to CR. 2018-02-22 12:07:11 -05:00
Matthew Chen 03670b4868 Rename the view horizon. 2018-02-22 11:46:08 -05:00
Matthew Chen fabbe46114 Clean up ahead of PR. 2018-02-22 11:46:08 -05:00
Matthew Chen 4e1e232825 Flush writes from other processes. 2018-02-22 11:46:08 -05:00
Matthew Chen 1ff4f85247 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen 5444fc73b0 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen 2ac7716771 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00