Commit graph

4960 commits

Author SHA1 Message Date
Matthew Chen 5fc21bce96 "Bump build to 2.30.2.4." 2018-09-28 17:32:10 -04:00
Matthew Chen 9474a1bfcb Fix "broken settings button layout in iOS 9" issue. 2018-09-28 17:25:44 -04:00
Matthew Chen 908d6dfd78 Ensure unread badges in home view are always at least a circle. 2018-09-28 16:41:51 -04:00
Matthew Chen b07de266c6 "Bump build to 2.30.2.3." 2018-09-28 15:43:35 -04:00
Michael Kirk 56387f3574 demo conversation colors when selecting 2018-09-28 13:35:57 -06:00
Michael Kirk 06eae47e09 ConversationViewItem -> protocol 2018-09-28 12:58:33 -06:00
Matthew Chen f56ac96d31 "Bump build to 2.30.2.2." 2018-09-27 19:42:39 -04:00
Matthew Chen ebae75af00 Revert 'new sort id'. 2018-09-27 19:40:51 -04:00
Matthew Chen 673dae83d9 Bump build to 2.30.2.1. 2018-09-27 17:00:38 -04:00
Matthew Chen 69b805c390 "Bump build to 2.30.1.1." 2018-09-27 16:58:00 -04:00
Matthew Chen b076f14964 Swift exit(). 2018-09-27 16:56:54 -04:00
Matthew Chen 1e82caed03 Remove dark theme feature flag. 2018-09-27 15:41:43 -04:00
Matthew Chen 99766fe07b Update l10n strings. 2018-09-27 15:38:41 -04:00
Michael Kirk 4765ed9a06 Color picker
TODO

-[x] tap to select/deselect
-[x] initially selected
-[x] integrate into conversation settings
-[x] colorPickerDelegate
-[x] translate strings
-[] reorder colors
-[x] SheetView: add top handle

Nice to have:

-[] SheetView: interactively swipe/unswipe to dismiss?
-[] preview color in bubbles
2018-09-27 13:34:23 -06:00
Joshua Lund 97d0543cef String cleanup:
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
2018-09-27 15:30:58 -04:00
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 2018-09-27 13:03:35 -06:00
Matthew Chen 2ef878bfc9 Add crash gesture to about view. 2018-09-27 12:32:09 -04:00
Matthew Chen 5a99cd347f Pull out OWSConversationColor to its own file. 2018-09-27 12:24:14 -04:00
Matthew Chen 0e5f42defe Use new asset for default contact avatars. 2018-09-27 12:22:14 -04:00
Matthew Chen 1c1d305a71 Respond to CR. 2018-09-27 11:42:32 -04:00
Matthew Chen 27488f078a Replace old "default profile avatar" icon with default avatar for local user. 2018-09-27 11:24:20 -04:00
Matthew Chen b5c5d1c3ef Use local avatar as app settings button. 2018-09-27 09:53:40 -04:00
Matthew Chen cbaf40d4ce Respond to CR. 2018-09-27 09:52:12 -04:00
Matthew Chen d161e5ff3d Add inner shadows to media thumbnails. 2018-09-27 09:42:29 -04:00
Matthew Chen 6715e3d1ad Respond to CR. 2018-09-27 09:28:16 -04:00
Matthew Chen b20cd57383 Rename OWSConversationColor. 2018-09-27 09:15:15 -04:00
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 2018-09-27 09:07:47 -04:00
Matthew Chen 26a2d568de Add "conversation color mode" enum. 2018-09-27 09:07:47 -04:00
Matthew Chen e5150267c2 Rework the conversation color constants. 2018-09-27 09:07:47 -04:00
Matthew Chen da63731447 Respond to CR. 2018-09-27 09:07:03 -04:00
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 2018-09-27 08:55:20 -04:00
Matthew Chen 25d56b30c1 Rework group avatars to reflect conversation colors. 2018-09-27 08:55:20 -04:00
Michael Kirk c21020d7e7 Use received date for footer-collapse supression 2018-09-26 09:52:34 -06:00
Michael Kirk 6f8eddc955 unread indicator uses sortId
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state

1. `unreadIndicator.firstUnseenTimestamp`:
    the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
    the timestamp of the first interaction *after* the unread indicator that fits in the loading window

We don't actually need to track `2` because it was only used in a comparison like:

   viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp

But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.

In other words, there's no situation where

   viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
2018-09-26 09:52:34 -06:00
Michael Kirk 3240e0d9d0 Be explicit about receivedAt time
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.

In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
2018-09-26 09:52:34 -06:00
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
2018-09-26 09:52:34 -06:00
Michael Kirk 1459fad01a sort media gallery by sortId 2018-09-26 09:52:33 -06:00
Michael Kirk 90aa593dcd sortId vs. Read status 2018-09-26 09:52:33 -06:00
Michael Kirk d6d6c4fca4 ConversationVC - lastSeenSortId 2018-09-26 09:52:33 -06:00
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
2018-09-26 09:52:33 -06:00
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 2018-09-26 09:52:33 -06:00
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
2018-09-26 09:52:33 -06:00
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
2018-09-26 09:52:33 -06:00
Michael Kirk ae668ceca9 include sequence number in fake messages 2018-09-26 09:52:33 -06:00
Matthew Chen 72562920ed Fix author conversation colors. 2018-09-26 09:19:12 -04:00
Michael Kirk 306c6ade71 "Bump build to 2.30.1.0." 2018-09-25 15:42:20 -06:00
Matthew Chen 4186ce9a72 Respond to CR. 2018-09-25 17:05:26 -04:00
Matthew Chen 7b2dd19fb8 Respond to CR. 2018-09-25 16:11:37 -04:00
Matthew Chen 8910f1f65a Enable conversation colors. 2018-09-25 16:11:37 -04:00
Matthew Chen ae84528dc3 Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ. 2018-09-25 16:11:37 -04:00