Commit graph

65 commits

Author SHA1 Message Date
Matthew Chen
6caa5b87b6 Add more asserts around thread in SAE. 2018-04-13 14:59:38 -04:00
Michael Kirk
86553b62f9 keyboard pinning vs iPhoneX 2018-04-02 17:38:13 -04:00
Michael Kirk
394cc6637c Backport comments from translations
// FREEBIE
2018-03-26 10:12:04 -04:00
Matthew Chen
76b4deffe4 Respond to CR. 2018-03-14 09:27:39 -03:00
Matthew Chen
593f7da72d Upload test file to CloudKit. 2018-03-12 16:40:07 -03:00
Michael Kirk
1d3831eccd Registration Lock reminder view
Also fixed: Don't lose PIN across registrations

// FREEBIE
2018-03-05 09:53:09 -05:00
Michael Kirk
5dde17d939 Show approval/caption view in app.
ApprovalView/Captioning is shown for:
- Images/Videos from Library
- Images/Video from Camera
- Document Picker
- GIFs

Voice notes are intentionally not captionable.

Also, in main app, hide status bar when ApprovalView is presented

// FREEBIE
2018-01-17 18:19:48 -05:00
Matthew Chen
e77c3e6717 Retain changes from session database branch. 2018-01-10 12:18:23 -05:00
Matthew Chen
80ae5e0fcf Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen
11b4848530 Respond to CR. 2017-12-11 10:37:20 -05:00
Michael Kirk
a58f1f385c Share a photo from photos app
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
2017-12-07 10:13:06 -05:00
Matthew Chen
8cc33b3de1 Refine loading view of share extension. 2017-12-01 10:48:18 -05:00
Michael Kirk
a11d83187b WIP: Framework-friendly - compiles but crashes on launch
// FREEBIE
2017-11-29 13:58:27 -08:00
Michael Kirk
a27b034090 Fix GIF picker footer for iPhoneX
// FREEBIE
2017-11-14 12:48:33 -05:00
Matthew Chen
4037e2ee39 Merge tag '2.18.0.7' 2017-11-02 17:21:17 -04:00
Michael Kirk
ad8c1db689 Reduce progressive search delay
// FREEBIE
2017-11-02 15:47:27 -04:00
Matthew Chen
db8a381960 Merge remote-tracking branch 'origin/release/2.18.0' 2017-11-01 12:02:37 -04:00
Matthew Chen
487bd06755 Respond to CR.
// FREEBIE
2017-10-31 11:56:13 -04:00
Matthew Chen
12de1aa90c Split up GIF requests.
// FREEBIE
2017-10-27 17:23:51 -04:00
Matthew Chen
c83090a46e Split up GIF requests.
// FREEBIE
2017-10-27 17:23:51 -04:00
Matthew Chen
2dfea25243 Split up GIF requests.
// FREEBIE
2017-10-27 17:23:51 -04:00
Matthew Chen
bcf83a4c8e Rework handling of oversize text messages.
// FREEBIE
2017-10-26 11:56:03 -04:00
Matthew Chen
be0149ccf2 Update layout of views to reflect keyboard.
// FREEBIE
2017-10-24 17:10:12 -04:00
Matthew Chen
cbb0030b12 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Michael Kirk
64c7c40b81 CR: add shadow to activity indicator
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
2af99eb710 Allow canceling GIF download
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
891cc6ee0d CR: better method names
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
688810c267 CR: Enforce "one time only" with a bool, not a cell ref
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
591cba6468 fix comment typos
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
a01de44917 Fix intermittent crash
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
6db5895269 dismiss keyboard when scrolling after auto-search
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
be51776d82 Fix mask appearing partially above search bar
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
37177de7cb Make sure user knows what they're picking
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
3939e8a6ac Download picked GIF faster: cancel pending request
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
b8ce636afc Show loading screen while selected GIF downloads
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
2017-10-20 12:34:55 -07:00
Matthew Chen
a386ac5685 Respond to CR.
// FREEBIE
2017-10-18 08:32:28 -07:00
Matthew Chen
b90e9fcd64 Skip redundant GIF searches.
// FREEBIE
2017-10-17 18:07:29 -07:00
Matthew Chen
33d3c4123a Progressive GIF search shouldn't dismiss keyboard.
// FREEBIE
2017-10-17 17:56:05 -07:00
Matthew Chen
7d9c2825d8 Add progressive search to Gif picker.
// FREEBIE
2017-10-10 09:51:13 -04:00
Matthew Chen
fd28e54132 Respond to CR.
// FREEBIE
2017-10-06 16:26:50 -04:00
Matthew Chen
52a8fb4b88 Add loading background to gif cells, refactor gif cells.
// FREEBIE
2017-10-06 16:25:40 -04:00
Matthew Chen
334396dac6 Add activity indicator, "error", "no results" and retry to gif picker.
// FREEBIE
2017-10-06 16:25:40 -04:00
Matthew Chen
6fb9af6363 Rework gif picker background & giphy logo.
// FREEBIE
2017-10-06 16:25:40 -04:00
Matthew Chen
8b7d34e51c Respond to CR.
// FREEBIE
2017-10-02 15:24:57 -04:00
Matthew Chen
fd9188415f Respond to CR.
// FREEBIE
2017-10-02 14:26:03 -04:00
Matthew Chen
a0c9a84390 Clean up ahead of PR.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen
d73a1a02a8 Tweak GIF cells.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen
801734a938 Clean up ahead of PR.
// FREEBIE
2017-10-02 13:37:32 -04:00