Commit graph

438 commits

Author SHA1 Message Date
Matthew Chen 6830d4e8cb Apply message bubble view to message details view. 2018-04-06 12:35:46 -04:00
Matthew Chen d99a2be005 Apply message bubble view to message details view. 2018-04-06 12:35:46 -04:00
Matthew Chen 9085609087 Fix interaction initializers and tests. 2018-04-05 09:36:52 -04:00
Michael Kirk bf401bad90 Send quoted messages
MVP

- [x] populate from menu
- [x] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk d99054d895 Reply menu item
MVP

- [x] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk cfbbeca7ac WIP: QuotedMessagePreviewView
MVP

- [] populate from menu
- [] send quoted message

TODO

- [] thumbnail
- [] paperclip icon showing for text message
- [] cancel button asset
- [] fonts
- [] colors
- [] adjust content inset/offset when showing quote edit

NICE TO HAVE

- [] animate presentation
- [] animate dismiss
- [] non-paperclip icon for generic attachments

// FREEBIE
2018-04-04 10:59:03 -04:00
Matthew Chen c36297a9ad Elaborate 'quoted reply' variations in the Debug UI. 2018-04-03 13:42:21 -04:00
Michael Kirk 6f1608f44b Conventional naming for out custom PureLayout methods.
This moves methods more in line with PureLayout conventions.

- Methods always specify if they pin to an edge vs margin

- `margin` is a reserved word which should only refer to layout margins.
  i.e. do not use it to refer to "inset" and "offset".

// FREEBIE
2018-04-02 17:02:32 -04:00
Matthew Chen 8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
2018-04-02 16:17:46 -04:00
Matthew Chen 3ca2c08b06 Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen 3d07dc7c5b Bubble collapse. 2018-04-02 10:07:15 -04:00
Matthew Chen 3a5ba15d21 Elaborate debug UI for messages. 2018-04-02 10:07:15 -04:00
Matthew Chen c2e31540d7 Elaborate debug UI for messages. 2018-04-02 10:06:45 -04:00
Michael Kirk 394cc6637c Backport comments from translations
// FREEBIE
2018-03-26 10:12:04 -04:00
Michael Kirk 00b5316976 Don't show the "All Media" button when viewing the slider from the
gallery via settings.

In this context it makes more sense for the user to hit the "dismiss"
button to get "back" to "All Media"

// FREEBIE
2018-03-20 11:12:11 -04:00
Michael Kirk ae8dbeb8dd Access Media Gallery from conversation settings
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk dfd628250d Gallery performance
- [x] share uiDatabaseConnection to share cache
- [x] increase cache size
- [x] load less initially
- [x] lazy loading
  - [x] slider view
  - [x] tile view

// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk 985af76d0b WIP: All Media view
TODO

- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style

NICE TO HAVE

- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"

DONE

- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells

// FREEBIE

WIP WIP extract datasouce to GalleryViewController

- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation

// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk 4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
2018-03-16 15:55:34 -04:00
Michael Kirk 88e1386720 Move frame to presentation logic, out of init
This no longer made sense now that we're using this in a
PageViewController we won't always be zooming from a particular frame.

TODO:

- why is background image all wonky?
- why aren't views created by the time it's presented? Is that a
regression? (how is self.view a MenuView if loadView hasn't been called)

// FREEBIE
2018-03-14 12:50:27 -04:00
Michael Kirk a1de99f1f1 Merge tag '2.21.0.9' 2018-03-06 16:43:33 -05:00
Matthew Chen d6f4db1523 Rename TSStorageManager to OWSPrimaryStorage. 2018-03-06 17:12:13 -03:00
Michael Kirk d7fcac8a5a In-App notifications don't pause background audio
// FREEBIE
2018-03-05 17:59:09 -05:00
Michael Kirk 07ee3ea843 Merge tag '2.21.0.5' 2018-03-05 09:54:06 -05:00
Michael Kirk 6077367e66 Notification sounds should respect silent switch
// FREEBIE
2018-03-03 11:33:31 -05:00
Matthew Chen baf6fcc535 Add 2FA registration view. 2018-03-02 10:55:00 -05:00
Matthew Chen 38ff82ab97 Rebrand OWSAudioPlayer. 2018-02-26 14:47:57 -05:00
Matthew Chen 81629a87df Fix build break. 2018-02-22 13:31:41 -05:00
Matthew Chen 152c570900 Respond to CR. 2018-02-22 12:07:11 -05:00
Matthew Chen 03670b4868 Rename the view horizon. 2018-02-22 11:46:08 -05:00
Matthew Chen fabbe46114 Clean up ahead of PR. 2018-02-22 11:46:08 -05:00
Matthew Chen 4e1e232825 Flush writes from other processes. 2018-02-22 11:46:08 -05:00
Matthew Chen 1ff4f85247 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen 2ac7716771 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Michael Kirk 5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
2018-02-22 08:57:58 -05:00
Michael Kirk d7f8c3e9d3 Ensure inputAccessory doesn't obscure the SN alert
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.

// FREEBIE
2018-02-21 16:35:46 -05:00
Michael Kirk abb51b565a Don't de-activate audio sesion when other audio activities are happening
// FREEBIE
2018-02-16 14:00:15 -08:00
Matthew Chen ceaf028445 Always scroll to bottom after sending attachments. 2018-02-16 14:06:46 -05:00
Matthew Chen bd0f601792 Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen 43765ef3b5 Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen bbd689bfd0 Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen d3e16583eb Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Michael Kirk c646f76335 Garther audio concerns, clean up session when done
- sync speakerphone state manipulated from system call screen
  - Revert audio session after call failure, ensures media plays out of
    speaker after placing a failing call.
  - Replace notification with delegate pattern since we're already using
    delegate pattern here.
- Fixes voiceover accessibility after voice memo
- Avoid audio blip after pressing hangup
- Rename CallAudioSession -> OWSAudioSession
  Going to start using it for other non-call things since we want to
  gather all our audio session concerns.
- Resume background audio when done playing video
  - Extract OWSVideoPlayer which ensures audio is in proper state before
    playback
  - Move recording session logic to shared OWSAudioSession
  - Deactivate audio session when complete

// FREEBIE
2018-02-06 18:45:51 -08:00
Michael Kirk e39ca59eeb Merge tag '2.19.5.0' 2018-02-01 14:03:43 -08:00
Matthew Chen fa76e524c4 Respond to CR. 2018-01-30 10:15:15 -05:00
Matthew Chen 9c84bdb105 Add support for images as documents. 2018-01-30 10:12:08 -05:00
Matthew Chen 3609275c20 Handle malformed row updates. 2018-01-30 10:06:46 -05:00
Matthew Chen 069587b150 Add message approval view. 2018-01-25 13:27:16 -05:00
Matthew Chen 992e926142 Unpack oversize text messages if possible. 2018-01-25 13:26:10 -05:00
Michael Kirk baa312f449 Timer button with duration label
// FREEBIE
2018-01-22 10:28:51 -05:00
Michael Kirk f41dfa509c Re-aquire first responder when necessary.
// FREEBIE
2018-01-19 15:05:50 -05:00
Michael Kirk 3ca5ec2726 Ensure media-library permissions when accessing media library
// FREEBIE
2018-01-18 13:37:11 -05:00
Michael Kirk 5dde17d939 Show approval/caption view in app.
ApprovalView/Captioning is shown for:
- Images/Videos from Library
- Images/Video from Camera
- Document Picker
- GIFs

Voice notes are intentionally not captionable.

Also, in main app, hide status bar when ApprovalView is presented

// FREEBIE
2018-01-17 18:19:48 -05:00
Michael Kirk 0c6a42003f clang-format after RI
// FREEBIE
2018-01-16 15:27:53 -05:00
Michael Kirk a423fe8a0e WIP Merge tag '2.19.4.4'
- restore video playback in fullscreen

This was a large merge, so I'm opting to make some changes in separate
commits.
2018-01-16 15:25:58 -05:00
Matthew Chen 17907dca10 Clean up ahead of PR. 2018-01-12 10:23:54 -05:00
Matthew Chen 15b8e58324 Retain changes from session database branch. 2018-01-12 10:23:54 -05:00
Michael Kirk 63c23b77d0 Cleanup presentation view, feels less blurry
// FREEBIE
2018-01-12 00:17:06 -05:00
Michael Kirk 74e03aad01 Fix intermittent content offset problem
Using the CollectionView's frame to determine if we're at the bottom
doesn't make sense unless the collection view is correctly layed out.

// FREEBIE
2018-01-11 23:04:18 -05:00
Matthew Chen e77c3e6717 Retain changes from session database branch. 2018-01-10 12:18:23 -05:00
Michael Kirk 74019b2ae4 Fix keyboard animation glitch after sending
// FREEBIE
2018-01-09 12:31:41 -05:00
Michael Kirk 1ec409ad2b CR: re-enable default keyboard toggle
// FREEBIE
2018-01-08 16:29:42 -05:00
Michael Kirk 8d2934d86e CR: remove unnecessary code, comments
// FREEBIE
2018-01-08 15:11:35 -05:00
Michael Kirk 412fe2735e Rename FullImageViewController -> MediaDetailViewController
// FREEBIE
2018-01-08 01:10:32 -05:00
Michael Kirk 918e3f7dfe Videos play in full-screen media view controller, use modern movie
player.

// FREEBIE
2018-01-08 01:10:32 -05:00
Michael Kirk 81268012e5 Better keyboard management.
- fixes problems on iOS11.2 where emoji keyboard sometimes obscures text
  input.
- better animation for interactive pan gesture when viewing message
  details
- more intuitive swipe-to-dismiss keyboard in conversation view
- converge on one mnethod for dismissing keyboard in conversation view

- [ ] Pop keyboard, then hit attachment, dismisses keyboard, which is
      fine, but the content should immediately scroll down with the
      keyboard, instead it stays up, and scrolls down only once the
      attachment action sheet has been dismissed.

// FREEBIE
2018-01-08 01:10:31 -05:00
sdkjfhsdkjhfsdlkjhfsdf b87079d4b4 Sharing attachment shows progress / retry dialog
// FREEBIE
2017-12-20 20:57:17 -06:00
Matthew Chen 6b0e3508a5 Respond to CR. 2017-12-20 11:28:07 -05:00
Matthew Chen 9258b0883e Clean up TSStorageManager usage. 2017-12-19 11:41:31 -05:00
Matthew Chen 9a990b58e8 Respond to CR. 2017-12-19 11:38:25 -05:00
Matthew Chen 3643414da1 Respond to CR. 2017-12-15 11:16:07 -05:00
Matthew Chen e45d63e862 Clean up ahead of PR. 2017-12-15 11:11:57 -05:00
Matthew Chen 0c9d9ba679 Fix issues around cross process db changes. 2017-12-15 11:11:57 -05:00
Michael Kirk 8996741277 DocumentPicker converts to mp4 when necessary
// FREEBIE
2017-12-11 20:34:47 -05:00
Michael Kirk 031e40d090 Use SignalAttachment logic in conversation view too
// FREEBIE
2017-12-11 20:16:34 -05:00
Matthew Chen 74efcb9041 Rework thread safety in profile manager. 2017-12-11 12:28:28 -05:00
Matthew Chen 80ae5e0fcf Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 11b4848530 Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 84061cca9f Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Matthew Chen 125aabb0a3 Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Michael Kirk d9cca77e23 update header references
// FREEBIE
2017-12-08 13:32:52 -05:00
Matthew Chen b4e8df79da Migrate environment to SignalMessaging. 2017-12-05 10:29:29 -05:00
Matthew Chen 6d87df88aa Migrate environment to SignalMessaging. 2017-12-05 10:29:28 -05:00
Matthew Chen bf21d0c0ed Enable logging in SAE; rework log file management to include multiple log directories. 2017-12-01 12:55:47 -05:00
Matthew Chen 64762eb427 Observe YapDatabaseModifiedExternallyNotification. 2017-11-30 10:28:05 -05:00
Michael Kirk fd829ba575 Merge branch 'hotfix/2.19.1' 2017-11-29 14:07:33 -08:00
Michael Kirk a11d83187b WIP: Framework-friendly - compiles but crashes on launch
// FREEBIE
2017-11-29 13:58:27 -08:00
Michael Kirk 9d1e3dc223 We need to change file extensions when converting data
// FREEBIE
2017-11-29 12:43:05 -08:00
Michael Kirk a542471bbe center "Loading More Messages" label
// FREEBIE
2017-11-22 13:32:20 -05:00
Matthew Chen 35bdc86ab5 Reload adjacent rows using original indices, not final indices. 2017-11-22 13:06:54 -05:00
Matthew Chen 71f5ef5940 Improve handling of unread indicator edge cases. 2017-11-22 10:39:38 -05:00
Matthew Chen 2ec1e7e925 Respond to CR. 2017-11-22 09:39:43 -05:00
Matthew Chen 2d241623b7 Improve handling of edge cases around unread indicator delimiting deleted message(s). 2017-11-21 18:17:19 -05:00
Matthew Chen 5ef9d53c91 Update conversation view UI to reflect unread state. 2017-11-21 17:53:52 -05:00
Michael Kirk 370364c936 Scroll down button scrolls to unread
// FREEBIE
2017-11-21 11:42:33 -05:00
Matthew Chen b0c9add29c Update layout of "scroll down button" to reflect RTL. 2017-11-21 11:27:01 -05:00
Matthew Chen 92ef507810 Make swipe-for-details RTL-safe. 2017-11-21 11:17:05 -05:00
Matthew Chen aea2bf3e00 Fix scroll state insets in conversation view. 2017-11-20 17:17:10 -05:00
Matthew Chen 5cfa7e35f4 Respond to CR. 2017-11-20 17:08:10 -05:00
Michael Kirk 34811a635b Fixes: "connected call" showing as "unconnected outgoing" call.
Expire viewItem cache when resetting mappings

// FREEBIE
2017-11-20 17:04:54 -05:00
Matthew Chen 45c7d80d97 Improving handling of edge cases in conversation view. 2017-11-20 14:44:10 -05:00
Matthew Chen 6d4a05bbea Improving handling of edge cases in conversation view. 2017-11-20 14:44:10 -05:00
Matthew Chen 658746093d Use finalIndex in row changes. 2017-11-20 14:44:10 -05:00
Michael Kirk 8ee030bea1 Don't dismiss keyboard when view appears
// FREEBIE
2017-11-20 14:30:55 -05:00
Matthew Chen 937ac5830d Skip animations in conversation view. 2017-11-16 17:59:32 -05:00
Matthew Chen b67179b45d Skip animations in conversation view. 2017-11-16 17:53:05 -05:00
Matthew Chen 0ccddb696a Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
2017-11-16 17:32:39 -05:00
Matthew Chen 96274a60a9 Respond to CR.
// FREEBIE
2017-11-16 17:30:19 -05:00
Matthew Chen 7aae47b021 Reduce font size of "load more" indicator. 2017-11-16 17:30:19 -05:00
Matthew Chen ddf4bf28cc Load attachments for conversation view items using long-lived db connection. 2017-11-16 13:16:18 -05:00
Matthew Chen df5aa5ef67 Update UI to reflect changes to disappearing messages configuration. 2017-11-16 12:25:43 -05:00
Michael Kirk 9675cbb1e1 Scroll only as far as necessary
// FREEBIE
2017-11-15 17:30:45 -05:00
Matthew Chen cc90f4cb80 Respond to CR.
// FREEBIE
2017-11-15 15:46:27 -05:00
Matthew Chen 86fdd6dea2 Fix edge cases in conversation view. 2017-11-15 15:43:03 -05:00
Matthew Chen 6413bc8e4c Evacuate the view item cache. 2017-11-15 13:36:56 -05:00
Matthew Chen 19ba564f80 Respond to CR.
// FREEBIE
2017-11-15 13:21:31 -05:00
Matthew Chen c6160a5a1e Rework the "update with..." methods to avoid re-saving deleted models. 2017-11-15 07:16:12 -05:00
Michael Kirk 8c69e00a3f Adapt ConversationViewController to iPhoneX
// FREEBIE
2017-11-14 12:37:09 -05:00
Matthew Chen bf0f33e4b0 Temporarily alter animations in conversation view. 2017-11-10 14:51:34 -05:00
Matthew Chen af6a7c103c Add a comment. 2017-11-10 14:08:52 -05:00
Matthew Chen 42a70e0def Revert "Temporarily make logging around conversation view row updates more verbose."
This reverts commit 105b033761.
2017-11-10 14:04:56 -05:00
Matthew Chen f0a8e08df9 Temporarily alter animations in conversation view. 2017-11-10 13:17:38 -05:00
Matthew Chen b5f7a4746f Temporarily alter animations in conversation view. 2017-11-10 12:41:11 -05:00
Matthew Chen 105b033761 Temporarily make logging around conversation view row updates more verbose. 2017-11-10 11:37:16 -05:00
Matthew Chen 87b0692af0 Fixes for scrolling in conversation view. 2017-11-10 09:41:27 -05:00
Matthew Chen 5cc292fb6c Don't ask for camera permissions if app is not active.
// FREEBIE
2017-11-09 03:02:05 -05:00
Matthew Chen 5e61307ce3 Don't ask for microphone permissions if app is not active.
// FREEBIE
2017-11-09 02:58:51 -05:00
Matthew Chen 6e840ff956 Fix build warnings from XCode 9. 2017-11-09 02:52:44 -05:00
Matthew Chen 2d21e2ae2c Fix build warnings from XCode 9. 2017-11-09 02:52:44 -05:00
Matthew Chen af5489952c Don't animate message sends.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen 40e04ffb92 Respond to CR.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen 5df4ac92b7 Don't animate message sends.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen d52b19a69e Let users with external keyboards send messages using modifier-return (shift, command, option).
// FREEBIE
2017-11-01 12:46:55 -04:00
Matthew Chen 0c92850d38 Log voice memo durations.
// FREEBIE
2017-11-01 12:45:22 -04:00
Matthew Chen 89dbcb0fe8 Respond to CR.
// FREEBIE
2017-11-01 12:36:37 -04:00
Matthew Chen f95e599c55 Don't overwrite draft after GIF send.
// FREEBIE
2017-11-01 12:36:36 -04:00
Matthew Chen a0ddb2a06d Respond to CR.
// FREEBIE
2017-10-31 15:01:29 -04:00
Matthew Chen 5ac2f16ebc Skip redundant relayout.
// FREEBIE
2017-10-31 14:33:30 -04:00
Matthew Chen 9cc4521d07 Respond to CR.
// FREEBIE
2017-10-26 12:09:36 -04:00
Matthew Chen bcf83a4c8e Rework handling of oversize text messages.
// FREEBIE
2017-10-26 11:56:03 -04:00
Michael Kirk 8f9311a6ac Show timer in navbar without reload
// FREEBIE
2017-10-25 14:40:05 -07:00
Michael Kirk 709010499f remove overzealous assert
// FREEBIE
2017-10-25 14:39:12 -07:00
Michael Kirk cd291e19ff We conceivably want to to initiate calls more than once without leaving
the conversation view. e.g. from Contacts.app

// FREEBIE
2017-10-25 11:37:04 -07:00
Michael Kirk 4000760cf7 Fix "back button count" flash. Only call once.
This affects returning from message info or when leaving conversation
settings.

// FREEBIE
2017-10-25 11:31:06 -07:00
Michael Kirk 43dd3abf6c clamp value per CR
// FREEBIE
2017-10-24 15:29:04 -07:00
Michael Kirk 59b125c3fb Add clarifying comment per CR
// FREEBIE
2017-10-24 15:29:04 -07:00
Michael Kirk d87f000051 Interactive/Cancelable slide left for details
// FREEBIE
2017-10-24 15:29:03 -07:00
Matthew Chen fb3bb852ca Tap image attachment preview to view full screen.
// FREEBIE
2017-10-24 17:12:26 -04:00
Matthew Chen 27af310235 Auto-dismiss keyboard if user scrolls away from bottom of the conversation.
// FREEBIE
2017-10-24 13:58:56 -04:00
Matthew Chen cbb0030b12 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Michael Kirk 1fee5d97e6 Merge branch 'release/2.18.0' 2017-10-23 16:02:11 -07:00
Michael Kirk 21df2dc047 Never hide "failed to send" footer
// FREEBIE
2017-10-23 08:40:26 -07:00
Michael Kirk f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons."
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
2017-10-20 16:37:07 -07:00
Michael Kirk 66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 2017-10-20 16:23:58 -07:00
Michael Kirk 2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 2017-10-20 16:23:10 -07:00
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 2017-10-20 16:10:07 -07:00
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
2017-10-20 12:35:21 -07:00
Matthew Chen 7fa7d5d526 Fix "mark as read."
// FREEBIE
2017-10-20 09:53:33 -04:00
Matthew Chen b0aa84e420 Clean up conversation view.
// FREEBIE
2017-10-19 23:02:59 -04:00
Matthew Chen d355b45bae Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen c2608785e1 Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen 4dc6934fc7 End text editing if we leave conversation view.
// FREEBIE
2017-10-19 22:48:28 -04:00
Matthew Chen 45ba79d296 Auto-load more message if user scrolls near the top of the conversation.
// FREEBIE
2017-10-19 22:39:42 -04:00
Matthew Chen f28abbc2a1 Revert from numeric to default keyboard after message send.
// FREEBIE
2017-10-19 22:36:25 -04:00
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 22:33:51 -04:00
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 10:04:49 -07:00
Matthew Chen 0fe76aaab8 Move "attachment approval" into input toolbar.
// FREEBIE
2017-10-18 12:50:16 -07:00
Matthew Chen 06eb794db6 Simplify and fix edge cases around long pressing on system message cells.
// FREEBIE
2017-10-18 12:31:23 -07:00
Matthew Chen 4a94d039e8 Restore the input toolbar's placeholder text.
// FREEBIE
2017-10-18 12:18:15 -07:00
Matthew Chen c47573334b Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen 3b945a9da2 Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen 257f8249bf Cull cached cell media outside a load window.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen e77292c2a9 Add contentWidth property to ConversationViewCell.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen b9f6bbb369 Clean up ahead of PR.
// FREEBIE
2017-10-18 09:30:03 -07:00
Matthew Chen 163e66dd4f Restore "load more messages" functionality.
// FREEBIE
2017-10-18 09:30:03 -07:00
Matthew Chen ed350f8ea6 Add vertical scroll indicator to conversation view.
// FREEBIE
2017-10-18 08:37:47 -07:00
Matthew Chen 032ec59d1c Respond to CR.
// FREEBIE
2017-10-16 21:05:29 -07:00
Matthew Chen 132d5b3408 Clean up ahead of PR.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen 3723a4845f Restore message cell footers.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen c2f07bb3d8 Restore message cell footers.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen 227fd5280d Resize conversation view cells as necessary.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen f7bd813c9f Restore the date headers to the conversation view cells.
// FREEBIE
2017-10-16 20:41:14 -07:00
Michael Kirk 0f859d6b20 Merge branch 'release/2.18.0' 2017-10-16 12:27:20 -07:00
Michael Kirk 3080cb512b Compose View: collation index and group search
- Include table index for contacts
- Fix extra spacing in OWS table view
- Separate search results into contact/invite sections
- Include groups in search results when composing new message
- Compose Screen search matches on group member names

// FREEBIE
2017-10-16 12:22:02 -07:00
Matthew Chen 7c82f6d448 Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
2017-10-13 12:57:44 -04:00
Matthew Chen 49501a5d1b Respond to CR.
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen 5621fe893c Clean up ahead of PR.
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen fb408f980c Remove JSQ.
// FREEBIE
2017-10-12 16:23:48 -04:00
Michael Kirk 796be18c56 enable gif picker
// FREEBIE
2017-10-12 14:58:25 -04:00
Matthew Chen 380ed0f82b Create & access groups more carefully.
// FREEBIE
2017-10-04 09:45:09 -04:00
Matthew Chen cef1f9186d Fix the scroll down button margins.
// FREEBIE
2017-10-03 11:18:57 -04:00
Matthew Chen fd9188415f Respond to CR.
// FREEBIE
2017-10-02 14:26:03 -04:00
Matthew Chen 801734a938 Clean up ahead of PR.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen 5b70116209 Unify the "message was sent" logic in conversation view. Ensure "message sent" sounds are played after sending attachments.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen a65a4b133c Clean up ahead of PR.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen 2dfd7aa0e9 Actually send GIFs.
// FREEBIE

SQUASH ME.

SQUASH ME.
2017-10-02 13:37:32 -04:00
Matthew Chen 62ba5701f6 Sketch out GIF picker.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen 27e5a2f1b2 Sketch out GIF picker.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen dbe2c6aa76 Fix scroll down button.
// FREEBIE
2017-10-01 14:22:01 -04:00
Matthew Chen f99ce23e69 Fix wrongful "add to contacts offer" issue.
// FREEBIE
2017-09-29 16:38:57 -04:00
Matthew Chen 6abc4bed90 Increase hot area of scroll down button.
// FREEBIE
2017-09-29 14:39:35 -04:00
Michael Kirk e2445e6ed2 Fix RTL bubbles in conversation and message detail view
// FREEBIE
2017-09-28 16:34:10 -04:00
Michael Kirk c3bb8a0190 on main thread, per CR
// FREEBIE
2017-09-28 14:59:00 -04:00
Michael Kirk 5704bf1765 message bubbles for message detail view controller
// FREEBIE
2017-09-28 14:58:15 -04:00
Michael Kirk e77a7e09bb Fix assert for empty thread
// FREEBIE
2017-09-28 13:06:29 -04:00
Matthew Chen d557817bb4 Format message statuses with date if possible.
// FREEBIE
2017-09-27 16:38:48 -04:00
Matthew Chen af7fd60d76 Fix NPE in conversation view.
// FREEBIE
2017-09-27 11:31:48 -04:00
Matthew Chen 9f9ac746d1 Sketch out message metadata view.
* Show message metadata view from conversation view.
* Pull out MediaMessageView class.
* Track recipient read timestamps.
* Add per-recipient status to message metadata view.
* Add share button to message metadata view.

// FREEBIE
2017-09-25 17:25:49 -04:00
Matthew Chen 315c1d7dc4 Hide all read receipts in UI if not enabled.
// FREEBIE
2017-09-25 17:22:27 -04:00
Matthew Chen 11cadf4200 Send, receive & show read receipts to senders/from receivers.
* Send read receipts to senders.
* Honor "send read receipts" preference.
* Process read receipts from recipients.
* Refactor "mark as read" logic.
* Serialize and apply recipient read receipts received before sync transcript.
* Show recipient read receipts in conversation view.

// FREEBIE
2017-09-22 14:24:17 -04:00
Matthew Chen c92c6de7b9 Add stress group to debug UI.
// FREEBIE
2017-09-22 10:40:23 -04:00
Matthew Chen 7268bde506 Add stress group to debug UI.
// FREEBIE
2017-09-22 10:30:35 -04:00
Matthew Chen bd416176ae Add stress group to debug UI.
// FREEBIE
2017-09-22 00:31:13 -04:00
Matthew Chen 35a2470cb7 Post notifications asynchronously.
// FREEBIE
2017-09-21 17:03:57 -04:00
Matthew Chen b28c4b74b2 Pull out TSMessageDecrypter class.
// FREEBIE
2017-09-21 14:38:30 -04:00
Matthew Chen f1b7d895e2 Modify precommit script to clean up includes and forward declarations.
// FREEBIE
2017-09-20 15:33:17 -04:00
Matthew Chen fa353259c3 Process messages in a single transaction (wherever possible).
// FREEBIE
2017-09-20 10:56:04 -04:00
Matthew Chen 6fce2c26b7 Process messages in a single transaction (wherever possible).
// FREEBIE
2017-09-20 09:40:46 -04:00
Matthew Chen 80e5f281c6 Rename app preferences class.
// FREEBIE
2017-09-19 17:35:42 -04:00
Matthew Chen c0f5bda2be Respond to CR.
// FREEBIE
2017-09-19 09:39:38 -04:00
Matthew Chen 400f536e37 Respond to CR.
// FREEBIE
2017-09-19 09:30:01 -04:00
Matthew Chen 872ce17dd6 Clean up data source temp files when complete.
// FREEBIE
2017-09-19 09:30:01 -04:00
Matthew Chen 541966aaf6 Fix NPEs when profiles change while entering conversation view.
// FREEBIE
2017-09-18 16:36:58 -04:00
Matthew Chen 2c68b06412 Respond to CR.
// FREEBIE
2017-09-18 16:12:51 -04:00
Matthew Chen 05b1818874 Don't "scroll to bottom" when messages are sent from desktop.
// FREEBIE
2017-09-18 15:49:33 -04:00
Matthew Chen 48121e5eac Don't "scroll to bottom" when messages are sent from desktop.
// FREEBIE
2017-09-18 15:49:32 -04:00
Matthew Chen 5be2014ec7 Create Flat UI rounded button class.
// FREEBIE
2017-09-12 14:45:57 -04:00
Matthew Chen ab00342d67 Add modal activity indicator view.
// FREEBIE
2017-09-11 12:49:14 -04:00
Matthew Chen 9dfebb2d4b Apply OWSFail() in more places.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen c21a7673c8 Rework preservation of attachment filenames.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen b95b5f69de Apply DataSource to message sender.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 20e5013aae Convert DataSource to Objective-C.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 69816cdf0e Convert DataSource to Objective-C.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 2282733fa9 Add data source class.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 26a6e76f3c Rework conversation view header.
// FREEBIE
2017-09-07 10:47:35 -04:00
Matthew Chen b626fb5bf8 Rework conversation view header.
// FREEBIE
2017-09-07 10:36:28 -04:00
Matthew Chen 644f435b16 Rework conversation view header.
// FREEBIE
2017-09-07 10:35:11 -04:00
Matthew Chen c106794fe8 Rename conversation view.
// FREEBIE
2017-09-06 14:13:18 -04:00
Renamed from Signal/src/ViewControllers/ConversationView/MessagesViewController.m (Browse further)