Commit graph

4355 commits

Author SHA1 Message Date
Matthew Chen 86d006ba14 Respond to CR. 2018-11-15 13:14:55 -05:00
Matthew Chen 2919e8d780 Respond to CR. 2018-11-15 13:14:55 -05:00
Matthew Chen ea080eda72 Sketch out the photo collection picker. 2018-11-15 13:14:55 -05:00
Matthew Chen 9641edbfd2 Fix build breakage. 2018-11-15 12:34:38 -05:00
Michael Kirk 92135af8be Merge branch 'release/2.32.0' 2018-11-15 10:38:43 -06:00
Michael Kirk 12b916ad36 Merge tag '2.31.0.37' into release/2.32.0 2018-11-15 10:35:03 -06:00
Michael Kirk a27b04613d CR: simplify scroll check 2018-11-15 10:29:49 -06:00
Michael Kirk ff63c31dae CR: rename colors 2018-11-15 10:23:53 -06:00
Michael Kirk 47a7114317 Gallery pager style changes 2018-11-15 10:16:51 -06:00
Michael Kirk f6e9fce0d3 fix All Media button from conversation settings 2018-11-15 10:16:22 -06:00
Michael Kirk 542d5826de fix a million retain cycles in conversation settings 2018-11-14 18:55:29 -06:00
Matthew Chen 210da50868 Rework ACK of messages fetched via REST. 2018-11-14 17:26:39 -05:00
Michael Kirk 84879b991d Album rail in Gallery 2018-11-14 14:50:33 -06:00
Matthew Chen b865b91147 Use REST for UD requests. 2018-11-14 08:30:25 -05:00
Matthew Chen f7e7477f54 Add sharing scenarios to Debug UI. 2018-11-13 13:15:11 -05:00
Matthew Chen 2e50cc1f2d Respond to CR. 2018-11-13 13:14:24 -05:00
Matthew Chen 84d6f61d53 Fix glitches in conversation media view. 2018-11-13 11:57:16 -05:00
Michael Kirk 24745570dc Merge tag '2.32.0.8' 2018-11-13 10:43:06 -06:00
Michael Kirk 3faa700d66 Merge tag '2.31.0.31' into release/2.32.0 2018-11-13 09:45:47 -06:00
Matthew Chen be784d14d6 Revert "Disable the orphan data cleaner."
This reverts commit 7c47fe6b4f.
2018-11-13 09:51:00 -05:00
Matthew Chen 49c8e6db7d Merge remote-tracking branch 'origin/release/2.31.0' 2018-11-13 09:50:44 -05:00
Matthew Chen 7c47fe6b4f Disable the orphan data cleaner. 2018-11-12 16:28:58 -05:00
Michael Kirk fa82d43e6c put custom image picker behind feature flag 2018-11-12 14:32:43 -06:00
Michael Kirk 3c450eeeaa degrade from crashing to debug assert, upon failure we return a fully (overly)
redacted string
2018-11-12 09:55:56 -06:00
Michael Kirk 54059532f7 remove unused strong capture 2018-11-12 09:55:29 -06:00
Michael Kirk 97e9871f19 remove unnecessary implicitly unwrapped optional 2018-11-12 09:55:06 -06:00
Michael Kirk 2a1c62f6f5 remove unused delegate method declaration 2018-11-12 09:55:00 -06:00
Michael Kirk 24f97f1229 compiler warning: discard result explicitly 2018-11-12 09:54:42 -06:00
Matthew Chen 6f64a809f3 Tap on album item. 2018-11-09 17:45:29 -05:00
Michael Kirk d805246cb7 update caption after deleting item 2018-11-09 16:26:12 -06:00
Michael Kirk ca30a96451 Increase caption height 2018-11-09 16:19:57 -06:00
Michael Kirk 78b1c9a8b9 caption should not be selectable/editable 2018-11-09 16:19:45 -06:00
Michael Kirk 43489a6551 remove gradient when viewing attachment with no caption 2018-11-09 16:19:38 -06:00
Michael Kirk 5da525ce2e Merge remote-tracking branch 'origin/release/2.31.0' 2018-11-09 15:49:53 -06:00
Michael Kirk 11fece2f3f move category method to be shared 2018-11-09 14:06:06 -06:00
Michael Kirk 74b25c14f1 filter caption strings for display 2018-11-09 14:06:06 -06:00
Michael Kirk 3b53ee08ba Long captions use ScrollView rather than resizing 2018-11-09 14:06:06 -06:00
Michael Kirk cfd2e8d9d1 Show captions in gallery page view 2018-11-09 14:06:06 -06:00
Matthew Chen 52af57f8a3 Fix accessibility for app settings button. 2018-11-09 14:01:28 -05:00
Matthew Chen b475695f54 Respond to CR. 2018-11-09 13:58:31 -05:00
Matthew Chen 34b4ea377f Revise media progress views. 2018-11-09 13:49:32 -05:00
Matthew Chen 15c42642e0 Apply invalid and rety assets. 2018-11-09 13:49:32 -05:00
Matthew Chen 1ac74cfb81 Modify MessageFetcherJob to handle incoming UD messages. 2018-11-09 13:46:08 -05:00
Matthew Chen 9d1579a480 Update caption indicator asset. 2018-11-08 15:49:49 -05:00
Matthew Chen cd224a1590 Render single media as albums. 2018-11-08 15:44:22 -05:00
Matthew Chen 82fb766c27 Respond to CR. 2018-11-08 15:40:43 -05:00
Matthew Chen 654325c6dc Add download progress indicators. 2018-11-08 15:35:14 -05:00
Matthew Chen a26086b303 Show attachment upload progress indicators. 2018-11-08 15:34:03 -05:00
Matthew Chen c1a5e1e258 Rename to media album. 2018-11-08 15:33:57 -05:00
Matthew Chen 3daf7d4744 Add OWSAttachmentDownloads. 2018-11-08 15:31:00 -05:00
Michael Kirk 03aba93985 CR: use id for hashvalue, make clearer that we don't expect to use incrementing ID's for uniqueId 2018-11-08 13:11:30 -06:00
Michael Kirk 7cf53293da restore Share/Delete functionality to gallery items in the post multi-attachment world 2018-11-08 12:52:09 -06:00
Michael Kirk 42bf267607 fixup plumbing for incoming messages/synced transcripts 2018-11-08 12:52:09 -06:00
Michael Kirk e096406e56 migrate existing attachments to album-compatible gallery schema 2018-11-08 12:52:09 -06:00
Michael Kirk 57681bd6f3 Gallery supports album messages 2018-11-08 12:52:09 -06:00
Michael Kirk 27cb91e9c8 Plumb through messageAlbumId so an Attachment knows what album (if any) it
belongs to.
2018-11-08 12:52:08 -06:00
Matthew Chen f37c4f71ad Add footer to 'typing indicators' setting. 2018-11-08 13:49:39 -05:00
Matthew Chen 02a9cc9181 Remove stroke on album items. 2018-11-08 13:46:02 -05:00
Matthew Chen 9a44f24bc1 Reduce typing indicators. 2018-11-07 14:31:47 -05:00
Matthew Chen f382cd770e Fix build break. 2018-11-07 12:32:30 -05:00
Matthew Chen 777e2b9251 Rename to media album. 2018-11-07 12:26:57 -05:00
Matthew Chen 2dfd4b2c0d Rename to media album. 2018-11-07 12:24:53 -05:00
Michael Kirk 3ff3779f17 CR: remove unnecessary assert 2018-11-07 10:12:50 -06:00
Matthew Chen c7c02f03d1 Display caption indicators for media albums in conversation view. 2018-11-07 11:12:13 -05:00
Michael Kirk 7cef41f8e2 Multi-approval 2018-11-07 10:09:21 -06:00
Matthew Chen 57de089118 Add support for album captions to models. 2018-11-07 10:54:17 -05:00
Matthew Chen 60c5a84dd2 Fix issues in media gallery cells; Improve debug galleries. 2018-11-07 09:56:49 -05:00
Matthew Chen 88a1186e4e Restore XCode 9 compatability. 2018-11-07 09:56:17 -05:00
Matthew Chen cdfd2779a3 Fix a couple small bugs in the typing indicators. 2018-11-06 17:21:24 -05:00
Matthew Chen 5aa6467d20 Fix issues in media gallery cells. 2018-11-06 15:35:48 -05:00
Matthew Chen f45693ec34 Respond to CR. 2018-11-06 15:34:18 -05:00
Matthew Chen 736d7c7351 Fix media gallery cell edge cases. 2018-11-06 15:23:09 -05:00
Matthew Chen d538301632 Fix media gallery cell edge cases. 2018-11-06 15:23:09 -05:00
Matthew Chen 34e85dd90e Fix media gallery cell edge cases. 2018-11-06 15:23:09 -05:00
Matthew Chen ee3bdca336 Fix media gallery cell edge cases. 2018-11-06 15:23:09 -05:00
Matthew Chen cfcb6cb15b Clean up ahead of PR. 2018-11-06 15:23:09 -05:00
Matthew Chen 0c76e1c02d Use ConversationMediaView to simplify media rendering in conversation view cells. 2018-11-06 15:23:09 -05:00
Matthew Chen f2c0a6f7dd Clean up ahead of PR. 2018-11-06 15:23:09 -05:00
Matthew Chen c89bdd2a15 Modify MediaGalleryCellView to handle animated images and videos. 2018-11-06 15:23:09 -05:00
Matthew Chen 2c9a556786 Remove overzealous assert in ConversationViewModel. 2018-11-06 15:23:09 -05:00
Matthew Chen cf057e3af3 Modify MediaGalleryCellView to handle still images. 2018-11-06 15:23:09 -05:00
Matthew Chen ec6de40bd9 Modify MessageBubbleView to support media galleries. 2018-11-06 15:23:09 -05:00
Matthew Chen 0341f5dc2b Modify ConversationViewItem to support media galleries. 2018-11-06 15:23:09 -05:00
Matthew Chen f2c0985907 Add 'is valid media?' method. 2018-11-06 15:23:09 -05:00
Michael Kirk 4c5d46e8f8 Custom photo picker, respects theme/call banner
- share GridViewCell
- Multiple image selection, with feature flag, cant currently approve multiple
2018-11-05 22:23:40 -06:00
Matthew Chen 2ca32fddcc Preserve ordering in incremental diffs. 2018-11-05 16:53:39 -05:00
Matthew Chen aa5e6b456e Preserve ordering in incremental diffs. 2018-11-05 16:53:39 -05:00
Matthew Chen 39c820b866 Distinguish 'app will/did become ready' events. 2018-11-05 09:04:57 -05:00
Matthew Chen eb2e16872e Distinguish 'app will/did become ready' events. 2018-11-05 09:04:57 -05:00
Matthew Chen af249de681 Fix race in CVM startup. 2018-11-05 09:02:05 -05:00
Matthew Chen 47fda2e377 Add debug UI for multi-image sends. 2018-11-02 13:04:05 -04:00
Matthew Chen ecba67b511 Add debug UI for multi-image sends. 2018-11-02 13:04:05 -04:00
Matthew Chen f6591fac25 Add debug UI for multi-image sends. 2018-11-02 13:04:05 -04:00
Matthew Chen d04f1e6e36 Add debug UI for multi-image sends. 2018-11-02 13:04:05 -04:00
Matthew Chen f893980468 Add debug UI function to make group with unregistered users. 2018-11-02 12:59:16 -04:00
Matthew Chen b8e9cd6b58 Respond to CR. 2018-11-01 16:44:48 -04:00
Matthew Chen 22c922bf5b Respond to CR. 2018-11-01 16:44:47 -04:00
Matthew Chen 650469c6a7 Respond to CR. 2018-11-01 16:44:47 -04:00
Matthew Chen 4088bebe05 Clean up ahead of PR. 2018-11-01 16:44:47 -04:00
Matthew Chen 94eaed0024 Fix rebase breakage. 2018-11-01 16:44:47 -04:00
Matthew Chen f8a5a41415 Apply dark theme to typing indicator. 2018-11-01 16:44:47 -04:00
Matthew Chen 37ae4ef360 Add typing indicator animation. 2018-11-01 16:44:47 -04:00
Matthew Chen 63d88ef5cb Sketch out TypingIndicatorCell. 2018-11-01 16:44:47 -04:00
Matthew Chen eedc9f9a26 Sketch out "typing indicators" interaction and cell. 2018-11-01 16:44:47 -04:00
Matthew Chen 50381cc94c Add typing indicators in home view. 2018-11-01 16:44:47 -04:00
Michael Kirk d9a4c6e837 typing indicator upgrade screen 2018-11-01 14:31:25 -06:00
Michael Kirk 77bd9b8852 Extract most Gallery functionality from the gallery NavigationController.
By not overriding the initializer for an OWSNavigationController subclass,
we can use the dynamic disaptch intialization chain.

The root difficulty here is that super.init(navBarClass:) wants to call
self.init(nibNam)
2018-11-01 12:53:59 -06:00
Michael Kirk 6d8a7ed800 things working 2018-11-01 12:53:59 -06:00
Michael Kirk 1af750363a fix media-gallery doesn't respect call banner 2018-11-01 12:53:59 -06:00
Matthew Chen 834bba8880 Respond to CR. 2018-11-01 14:51:47 -04:00
Matthew Chen 32d3eed7ba Add ConversationViewModel. 2018-11-01 14:51:47 -04:00
Matthew Chen a09cb16e74 Add typing indicators setting. 2018-11-01 14:28:39 -04:00
Michael Kirk f24ef7a0e8 separate title view for landscape 2018-11-01 08:43:59 -06:00
Michael Kirk 432fcc016c Gallery tile landscape 2018-11-01 08:43:59 -06:00
Michael Kirk 19f2d0db48 WIP: Media Landscape Mode 2018-11-01 08:43:59 -06:00
Matthew Chen 3d0e7386a4 Respond to CR. 2018-10-31 12:19:07 -04:00
Matthew Chen a98c82645c Start work on typing indicators.
* Update proto schema to reflect typing indicators.
* Sketch out OWSTypingIndicatorMessage.
* Add "online" to the service message params.
* Sketch out logic to send typing indicator messages.
* Sketch out OWSTypingIndicators class.
2018-10-31 12:11:29 -04:00
Matthew Chen 40aa78e001 Merge remote-tracking branch 'origin/release/2.31.0' 2018-10-31 11:42:41 -04:00
Michael Kirk 82d64405d0 fixup blogpost url 2018-10-30 17:08:02 -06:00
Matthew Chen 2541be1619 Apply refinements to UD logic. 2018-10-30 16:18:22 -04:00
Michael Kirk 3d9cd4f4ed CR: comments and code clarity 2018-10-30 11:35:34 -06:00
Michael Kirk cb9aa6304c find -E . -type f -regex ".*\.(m|h)" -exec sed -i "" -e "s/try_/throws_/" {} \; 2018-10-30 11:35:34 -06:00
Michael Kirk 3a6aafc454 Swift Exception wrap NSData+keyVersionByte 2018-10-30 11:35:34 -06:00
Matthew Chen 5535abd01b Update "sealed sender" blog post URL. 2018-10-30 10:55:30 -04:00
Matthew Chen 9fa16cc66f Fix small bug in the re-registration flow. 2018-10-29 16:41:43 -04:00
Michael Kirk b0a6d18576 leave proximity enabled as long as CallViewController exists 2018-10-26 15:32:12 -06:00
Michael Kirk 5632bd2d83 Use reference counting to disable proximity monitoring after audio message
Multiple overlapping activities require proximity monitoring (namely,
CallViewController and listening to audio messages).

These activities can overlap arbitrarily, so we use a reference counting
strategy to keep proximity monitoring on as long as one of these activities is
active.
2018-10-26 15:32:12 -06:00
Matthew Chen ed4fa2e8cb Respond to CR. 2018-10-26 14:44:53 -04:00
Matthew Chen 38f3321e9a Improve startup logging. 2018-10-26 14:44:53 -04:00
Michael Kirk 0c2bb439f9 kick-queue upon reachability 2018-10-25 11:56:39 -06:00
Michael Kirk 54c63c7a2e Reachability Singleton 2018-10-25 11:56:39 -06:00
Michael Kirk b8e4bfff86 shuffle isReady->isSetup, centralize starting workStep 2018-10-25 11:56:39 -06:00
Michael Kirk 037bdebfab clarify backoff delay examples 2018-10-25 11:54:59 -06:00
Michael Kirk 86a0efedc6 Don't delete session upon starting retry 2018-10-25 11:54:59 -06:00
Michael Kirk 3560f3be5c Durable send operation
TODO
-[x] respect order of queue
-[x] replacements
  -[x] those w/o completion handler
  -[x] basic send+log operation persists
  -[x] send+ui completion
  -[x] share extension
  -[x] update state jobs
-[x] App Lifecyle
  -[x] settable
  -[x] Mark as ready on startup
  -[x] Fail appropriate jobs on startup

NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
  -[x] retry failed jobs on startup?
  -[ ] reachability

DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
2018-10-25 11:54:59 -06:00
Michael Kirk e20df022c8 always show footer for in-progress sending 2018-10-25 11:54:58 -06:00
Michael Kirk 3a1769c81a unrelated swift fix 2018-10-25 11:54:58 -06:00
Matthew Chen 25ed886e72 Update home and group cells' dependencies. 2018-10-25 09:48:58 -04:00
Matthew Chen 28f37a7a34 Update contacts cells' dependencies. 2018-10-25 09:48:57 -04:00
Matthew Chen 8e1103c28f Log WebRTC version. 2018-10-24 16:58:45 -04:00
Matthew Chen 81d6b60ad5 Fix icon layout in privacy settings. 2018-10-24 11:43:28 -04:00
Michael Kirk ce9ca1bdaa audio player type 2018-10-24 07:46:27 -06:00
Michael Kirk 3b4188f34b hoist audio session singleton to Environment 2018-10-24 07:46:25 -06:00
Michael Kirk 3d022adf4e WIP: audio activities 2018-10-24 07:44:50 -06:00
Matthew Chen 55ab6c39d4 Rework UD settings. 2018-10-23 15:08:02 -04:00
Matthew Chen f765c6c1bb Update UD settings copy. 2018-10-23 15:08:02 -04:00
Matthew Chen 1a53005e08 Respond to CR. 2018-10-22 14:43:07 -04:00
Matthew Chen 8fec73dda5 Fix edge cases around UD v. linked devices. 2018-10-22 12:33:09 -04:00
Matthew Chen d656ae1017 Fix edge cases around UD v. linked devices. 2018-10-22 12:31:28 -04:00
Matthew Chen 94c7b72361 Only send "sent message transcript" sync messages using UD. 2018-10-19 16:45:50 -04:00