f98e57e164
fixes #1329 We must register notification settings earlier to be sure we'll be able to get the users push tokens. We were previously relying on a quirk of background fetch, a feature which we don't *actually* use, wherein it's possible to get push tokens for a user without first prompting them for their notification settings. More on this from UIApplication.h: // Calling this will result in either application:didRegisterForRemoteNotificationsWithDeviceToken: or application:didFailToRegisterForRemoteNotificationsWithError: to be called on the application delegate. // ---> Note: these callbacks will be made only if the application has successfully registered for user notifications with registerUserNotificationSettings:, or if it is enabled for Background App Refresh. - (void)registerForRemoteNotifications NS_AVAILABLE_IOS(8_0); In the previous implementation, if a user had disabled background notifications (e.g. in order to save battery), we were waiting for push tokens that would never come. However, this simple "fix" introduces a UX problem - now we prompt for an alert in the middle of our registration flow. // FREEBIE |
||
---|---|---|
.github | ||
Libraries | ||
Scripts | ||
SettingsBundle | ||
Signal | ||
Signal.xcodeproj | ||
Signal.xcworkspace | ||
.clang-format | ||
.gitattributes | ||
.gitignore | ||
.travis.yml | ||
BUILDING.md | ||
CONTRIBUTING.md | ||
Makefile | ||
Podfile | ||
Podfile.lock | ||
README.md |
README.md
Signal for iOS
Signal is a messaging app for simple private communication with friends.
Translation
Help us translate Signal! The translation effort happens on Transifex
Contributing Code
Instructions on how to setup your development environment and build Signal-iOS can be found in BUILDING.md.
If you're new to the Signal-iOS codebase, we recommend going through our issues and picking out a simple bug to fix (check the "easy" label in our issues) in order to get yourself familiar.
For larger changes and feature ideas, we ask that you propose it on the unofficial Community Forum for a high-level discussion with the wider community before implementation.
This repository is set up with BitHub, so you can make money for committing to Signal-iOS. The current BitHub price for an accepted pull request is:
Contributing Ideas
Have something you want to say about Open Whisper Systems projects or want to be part of the conversation? Get involved in the community forum.
Cryptography Notice
This distribution includes cryptographic software. The country in which you currently reside may have restrictions on the import, possession, use, and/or re-export to another country, of encryption software. BEFORE using any encryption software, please check your country's laws, regulations and policies concerning the import, possession, or use, and re-export of encryption software, to see if this is permitted. See http://www.wassenaar.org/ for more information.
The U.S. Government Department of Commerce, Bureau of Industry and Security (BIS), has classified this software as Export Commodity Control Number (ECCN) 5D002.C.1, which includes information security software using or performing cryptographic functions with asymmetric algorithms. The form and manner of this distribution makes it eligible for export under the License Exception ENC Technology Software Unrestricted (TSU) exception (see the BIS Export Administration Regulations, Section 740.13) for both object code and source code.
License
Copyright 2014-2016 Open Whisper Systems
Licensed under the GPLv3: http://www.gnu.org/licenses/gpl-3.0.html