fix: Use the correct match subgroup in denote-link--find-value

Also document that dependence on subgroup in doc strings.
This commit is contained in:
Kaushal Modi 2022-06-11 12:29:31 -04:00
parent 24371b4c86
commit 561553db8e

View file

@ -95,13 +95,19 @@ files."
"Return value from REGEXP by searching the file."
(goto-char (point-min))
(re-search-forward regexp)
(match-string-no-properties 3))
(match-string-no-properties 1))
(defconst denote-link--title-regexp "^\\(#\\+\\)?\\(title:\\)[\s\t]+\\(.*\\)"
"Regular expression for title key and value.")
(defconst denote-link--title-regexp "^\\(?:#\\+\\)?\\(?:title:\\)[\s\t]+\\(?1:.*\\)"
"Regular expression for title key and value.
(defconst denote-link--identifier-regexp "^.?.?\\b\\(identifier\\|ID\\)\\s-*[:=]\\s-*\"?\\([0-9T]+\\)"
"Regular expression for filename key and value.")
The match that needs to be extracted is explicityly marked as
group 1. `denote-link--find-value' uses the group 1 sting.")
(defconst denote-link--identifier-regexp "^.?.?\\b\\(?:identifier\\|ID\\)\\s-*[:=]\\s-*\"?\\(?1:[0-9T]+\\)"
"Regular expression for filename key and value.
The match that needs to be extracted is explicityly marked as
group 1. `denote-link--find-value' uses the group 1 sting.")
(defconst denote-link--link-format-org "[[file:%s][%s (%s)]]"
"Format of Org link to note.")