From 561553db8e6615e4489dda1c06951fd78c5caad9 Mon Sep 17 00:00:00 2001 From: Kaushal Modi Date: Sat, 11 Jun 2022 12:29:31 -0400 Subject: [PATCH] fix: Use the correct match subgroup in `denote-link--find-value` Also document that dependence on subgroup in doc strings. --- denote-link.el | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/denote-link.el b/denote-link.el index ca0668b..399c12b 100644 --- a/denote-link.el +++ b/denote-link.el @@ -95,13 +95,19 @@ files." "Return value from REGEXP by searching the file." (goto-char (point-min)) (re-search-forward regexp) - (match-string-no-properties 3)) + (match-string-no-properties 1)) -(defconst denote-link--title-regexp "^\\(#\\+\\)?\\(title:\\)[\s\t]+\\(.*\\)" - "Regular expression for title key and value.") +(defconst denote-link--title-regexp "^\\(?:#\\+\\)?\\(?:title:\\)[\s\t]+\\(?1:.*\\)" + "Regular expression for title key and value. -(defconst denote-link--identifier-regexp "^.?.?\\b\\(identifier\\|ID\\)\\s-*[:=]\\s-*\"?\\([0-9T]+\\)" - "Regular expression for filename key and value.") +The match that needs to be extracted is explicityly marked as +group 1. `denote-link--find-value' uses the group 1 sting.") + +(defconst denote-link--identifier-regexp "^.?.?\\b\\(?:identifier\\|ID\\)\\s-*[:=]\\s-*\"?\\(?1:[0-9T]+\\)" + "Regular expression for filename key and value. + +The match that needs to be extracted is explicityly marked as +group 1. `denote-link--find-value' uses the group 1 sting.") (defconst denote-link--link-format-org "[[file:%s][%s (%s)]]" "Format of Org link to note.")