tfelypoc/-._protesilaos-s-___denote___.-
tfelypoc/-._protesilaos-s-___denote___.-
1
1
Fork 0
Code Issues Projects 1 Releases Activity

Simplify denote-dired--rename-buffer

Browse source 
The new code is basically what `dired-rename-file' does.
This commit is contained in:
Damien Cassou 2022-06-20 17:12:10 +02:00 committed by Protesilaos Stavrou
parent 750f8bf95c
commit 6b200b31ef
No known key found for this signature in database
GPG key ID: 99BD6459CD5CA3EA
1 changed files with 3 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
denote-dired.el
View file

@ -180,19 +180,9 @@ everything works as intended."
(defun denote-dired--rename-buffer (old-name new-name)
"Rename OLD-NAME buffer to NEW-NAME, when appropriate."
(when-let ((old-buf (find-buffer-visiting old-name)))
(with-current-buffer old-buf
;; We get the window to replace the buffer without affecting the
;; window layout.
(let ((win (get-buffer-window old-buf)))
(rename-buffer (file-name-nondirectory new-name))
;; TODO 2022-06-17: Is there a better way to avoid duplication
;; between old and new? It seems wrong to kill-buffer and then
;; find-file.
(kill-buffer (find-buffer-visiting old-name))
(when win
(with-selected-window win
(find-file new-name)))))))
(when-let* ((buffer (find-buffer-visiting old-name)))
(with-current-buffer buffer
(set-visited-file-name new-name nil t))))
(defun denote-dired--rename-dired-file-or-prompt ()
"Return Dired file at point, else prompt for one."