From 028875514b99a5807be3b0aa4a36606f600f4485 Mon Sep 17 00:00:00 2001
From: Peter Zimon <peter.zimon@gmail.com>
Date: Mon, 7 Mar 2022 18:54:40 +0100
Subject: [PATCH] Fixed linter error

---
 .lint-todo                            |  9 +++++++++
 app/components/gh-nav-menu/footer.hbs | 18 +++++++++---------
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/.lint-todo b/.lint-todo
index 1a27dfdb0..611b92795 100644
--- a/.lint-todo
+++ b/.lint-todo
@@ -1161,3 +1161,12 @@ add|ember-template-lint|no-action|4|11|4|11|831dd12209c22868d0614c65417281fda799
 add|ember-template-lint|require-valid-alt-text|3|44|3|44|a7f0566c430150bae4153e0dfb489a218bdeb8a4|1646611200000|1649199600000|1651791600000|lib/koenig-editor/addon/components/koenig-card-embed/nft.hbs
 add|ember-template-lint|require-valid-alt-text|8|20|8|20|9d0c591086dc9139ff38a7b385c3367a83438786|1646611200000|1649199600000|1651791600000|lib/koenig-editor/addon/components/koenig-card-embed/nft.hbs
 add|ember-template-lint|require-input-label|10|12|10|12|8c3c0ea315ff4da828363989a45fa11256a78796|1646611200000|1649199600000|1651791600000|lib/koenig-editor/addon/components/koenig-card-image/selector-tenor.hbs
+remove|ember-template-lint|no-invalid-role|16|24|16|24|f4ef9ac4dce151eec8ed5c4ea81b263d70d8ec82|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|28|28|28|28|38a04b1a48e814d3644ec621f53b0b976dc7637f|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|33|28|33|28|ae089ed2726e29ba4828e6b9d74460a2b95b8eae|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|38|28|38|28|44dba2b770f13e4b458bd3ad8fd0bce027412c06|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|48|24|48|24|ed0e49b40ec918b4568302fadc617fb64a10d6ab|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|56|28|56|28|156177efcfa893d64c122bd7e2f34ddf25c485fb|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|61|28|61|28|83c51011d1462aebfd2e81537be01340e13503fb|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|72|40|72|40|82eb5369fb03019dee23eb2a99d3da774eee7084|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
+remove|ember-template-lint|no-invalid-role|83|24|83|24|82e305f542b2c200d412e1b6e596c5fa620930b2|1646611200000|1649199600000|1651791600000|app/components/gh-nav-menu/footer.hbs
diff --git a/app/components/gh-nav-menu/footer.hbs b/app/components/gh-nav-menu/footer.hbs
index a983e9249..b45124530 100644
--- a/app/components/gh-nav-menu/footer.hbs
+++ b/app/components/gh-nav-menu/footer.hbs
@@ -13,7 +13,7 @@
 
                 <dropdown.Content class="gh-nav-menu-dropdown {{if this.session.user.isContributor "gh-nav-menu-dropdown-contributor"}}">
                     <ul class="dropdown-menu dropdown-triangle-top" role="menu">
-                        <li role="presentation">
+                        <li>
                             <div class="gh-account-menu-header">
                                 <div class="gh-user-avatar relative" style={{background-image-style this.session.user.profileImageUrl}}></div>
                                 <div class="gh-user-info">
@@ -25,17 +25,17 @@
                         <li class="divider" role="separator"></li>
                         
                         {{#if this.session.user.isContributor}}
-                            <li role="presentation">
+                            <li>
                                 <LinkTo @route="posts" @query={{hash entry=null}} class="dropdown-item" @role="menuitem" tabindex="-1" data-test-nav="posts">
                                     Posts
                                 </LinkTo>
                             </li>
-                            <li role="presentation">
+                            <li>
                                 <a href="{{this.config.blogUrl}}/" class="dropdown-item" role="menuitem" tabindex="-1" title="Open site in new tab" target="_blank" rel="noopener noreferrer">View site</a>
                             </li>
                             <li class="divider" role="separator"></li>
                         {{else}}
-                            <li role="presentation">
+                            <li>
                                 <LinkTo @route="whatsnew" @query={{hash entry=null}} class="dropdown-item" @role="menuitem" tabindex="-1" data-test-nav="whatsnew">
                                     What's new?
                                     {{#if this.whatsNew.hasNew}}
@@ -45,7 +45,7 @@
                             </li>
                         {{/if}}
 
-                        <li role="presentation">
+                        <li>
                             <LinkTo @route="settings.staff.user" @model={{this.session.user.slug}} class="dropdown-item" @role="menuitem" tabindex="-1" data-test-nav="user-profile">
                                 Your profile
                             </LinkTo>
@@ -53,12 +53,12 @@
                         
                         {{#unless this.session.user.isContributor}}
                             <li class="divider" role="separator"></li>
-                            <li role="presentation">
+                            <li>
                                 <a class="dropdown-item" role="menuitem" tabindex="-1" href="https://ghost.org/help?utm_source=admin&utm_campaign=help" target="_blank" rel="noopener noreferrer">
                                     Help center
                                 </a>
                             </li>
-                            <li role="presentation">
+                            <li>
                                 <a class="dropdown-item" role="menuitem" tabindex="-1" href="https://ghost.org/resources?utm_source=admin&utm_campaign=resources" target="_blank" rel="noopener noreferrer">
                                     Resources & guides
                                 </a>
@@ -69,7 +69,7 @@
                                     {{#if menuItem.divider}}
                                         <li class="divider" role="separator"></li>
                                     {{else}}
-                                        <li role="presentation">
+                                        <li>
                                             <a href="{{menuItem.href}}" target="_blank" class="dropdown-item {{menuItem.classes}}" role="menuitem" tabindex="-1" rel="noopener noreferrer">
                                                 {{menuItem.text}}
                                             </a>
@@ -80,7 +80,7 @@
                         <li class="divider" role="separator"></li>
                         {{/unless}}
 
-                        <li role="presentation">
+                        <li>
                             <LinkTo @route="signout" class="dropdown-item user-menu-signout" @role="menuitem" tabindex="-1">
                                 Sign out
                             </LinkTo>