From 3db79bdcb38f3368e3947e83c55dcbfc868b5394 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Wed, 5 Jan 2022 12:52:00 +0000 Subject: [PATCH] Fixed `?search=` empty param after members bulk delete no issue - the members query reset was using `""` rather than `null` due to a bug in an old version of search/filtering but that meant we could end up with an empty param - switched to `null` as it no longer appears necessary to use a blank string, this matches behaviour of other params --- app/helpers/reset-query-params.js | 2 +- tests/acceptance/members-test.js | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/helpers/reset-query-params.js b/app/helpers/reset-query-params.js index 700ef3651..80602efc6 100644 --- a/app/helpers/reset-query-params.js +++ b/app/helpers/reset-query-params.js @@ -18,7 +18,7 @@ export const DEFAULT_QUERY_PARAMS = { 'members.index': { label: null, paid: null, - search: '', + search: null, filter: null, order: null } diff --git a/tests/acceptance/members-test.js b/tests/acceptance/members-test.js index 86b0d1677..ca11c5817 100644 --- a/tests/acceptance/members-test.js +++ b/tests/acceptance/members-test.js @@ -194,8 +194,7 @@ describe('Acceptance: Members', function () { expect(find('[data-test-button="confirm"]')).to.not.exist; // members filter is reset - // TODO: fix query params reset for empty strings - expect(currentURL()).to.equal('/members?search='); + expect(currentURL()).to.equal('/members'); expect(findAll('[data-test-member]').length).to.equal(6); await click('[data-test-button="close-modal"]');