From 482188b2635776011ea31ef056bdc4beb52f78d1 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Sat, 11 Aug 2018 18:26:30 +0100 Subject: [PATCH] Koenig - Prevent "Enter" being inserted into captions refs https://github.com/TryGhost/Ghost/issues/9724 - mobiledoc-kit's `key.isPrintable()` returns true for Enter but in this instance we don't want to capture newlines as printable chars - swapped insertion of `event.key` for `key.toString()` for better handling of named keys that output characters (eg. when `event.key` === `Enter` which prints `\n`) --- lib/koenig-editor/addon/components/koenig-caption-input.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/koenig-editor/addon/components/koenig-caption-input.js b/lib/koenig-editor/addon/components/koenig-caption-input.js index 3d1a19425..684d48fdd 100644 --- a/lib/koenig-editor/addon/components/koenig-caption-input.js +++ b/lib/koenig-editor/addon/components/koenig-caption-input.js @@ -90,10 +90,10 @@ export default Component.extend({ let key = new Key(event); let {editor} = this; - if (event.target.matches('[data-kg="editor"]') && editor && !editor._hasFocus() && key.isPrintableKey()) { + if (event.target.matches('[data-kg="editor"]') && editor && !editor._hasFocus() && key.isPrintableKey() && !key.isEnter()) { editor.focus(); editor.run((postEditor) => { - postEditor.insertText(editor.post.tailPosition(), event.key); + postEditor.insertText(editor.post.tailPosition(), key.toString()); }); event.preventDefault();