From 52cf55e369eb7648bc980c7c6cd88a1e31a1cf75 Mon Sep 17 00:00:00 2001 From: Jason Williams Date: Tue, 24 Jun 2014 06:33:24 +0000 Subject: [PATCH] Enable validation for settings/general screen Closes #3036 Refs #3012 -Enable validation for settings/general -Turn on functional tests for the validations -Move notification closeAll calls so that notifications are cleared on attempted saves instead of just on successful saves --- controllers/settings/general.js | 13 +++++++++---- controllers/settings/user.js | 5 +++-- mixins/editor-base-controller.js | 6 +++--- mixins/validation-engine.js | 4 +++- models/setting.js | 6 +++++- validators/setting.js | 33 ++++++++++++++++++++++++++++++++ 6 files changed, 56 insertions(+), 11 deletions(-) create mode 100644 validators/setting.js diff --git a/controllers/settings/general.js b/controllers/settings/general.js index c3486a5a4..56c33f89f 100644 --- a/controllers/settings/general.js +++ b/controllers/settings/general.js @@ -30,13 +30,18 @@ var SettingsGeneralController = Ember.ObjectController.extend({ save: function () { var self = this; + // @TODO This should call closePassive() to only close passive notifications + self.notifications.closeAll(); + return this.get('model').save().then(function (model) { - // @TODO This should call closePassive() to only close passive notifications - self.notifications.closeAll(); - self.notifications.showSuccess('Settings successfully saved.'); + return model; - }).catch(this.notifications.showErrors); + }).catch(function (errors) { + self.notifications.showErrors(errors); + + return Ember.RSVP.reject(errors); + }); }, } }); diff --git a/controllers/settings/user.js b/controllers/settings/user.js index 4c80a1af5..54c4a3a49 100644 --- a/controllers/settings/user.js +++ b/controllers/settings/user.js @@ -23,13 +23,14 @@ var SettingsUserController = Ember.Controller.extend({ save: function () { var self = this; + // @TODO This should call closePassive() to only close passive notifications + self.notifications.closeAll(); + alert('@TODO: Saving user...'); if (this.user.validate().get('isValid')) { this.user.save().then(function (response) { - // @TODO This should call closePassive() to only close passive notifications - self.notifications.closeAll(); alert('Done saving' + JSON.stringify(response)); }, function () { alert('Error saving.'); diff --git a/mixins/editor-base-controller.js b/mixins/editor-base-controller.js index 98f9e6147..37f256f79 100644 --- a/mixins/editor-base-controller.js +++ b/mixins/editor-base-controller.js @@ -124,6 +124,9 @@ var EditorControllerMixin = Ember.Mixin.create(MarkerManager, { isNew = this.get('isNew'), self = this; + // @TODO This should call closePassive() to only close passive notifications + self.notifications.closeAll(); + // ensure an incomplete tag is finalised before save this.get('controllers.post-tags-input').send('addNewTag'); @@ -137,9 +140,6 @@ var EditorControllerMixin = Ember.Mixin.create(MarkerManager, { // for a saved model it would otherwise be false. self.set('isDirty', false); - // @TODO This should call closePassive() to only close passive notifications - self.notifications.closeAll(); - self.notifications.showSuccess('Post status saved as ' + model.get('status') + '.', isNew ? true : false); return model; diff --git a/mixins/validation-engine.js b/mixins/validation-engine.js index f573d2090..b5f0afbd7 100644 --- a/mixins/validation-engine.js +++ b/mixins/validation-engine.js @@ -5,6 +5,7 @@ import PostValidator from 'ghost/validators/post'; import SignupValidator from 'ghost/validators/signup'; import SigninValidator from 'ghost/validators/signin'; import ForgotValidator from 'ghost/validators/forgotten'; +import SettingValidator from 'ghost/validators/setting'; ValidatorExtensions.init(); @@ -13,7 +14,8 @@ var ValidationEngine = Ember.Mixin.create({ post: PostValidator, signup: SignupValidator, signin: SigninValidator, - forgotten: ForgotValidator + forgotten: ForgotValidator, + setting: SettingValidator }, validate: function (opts) { diff --git a/models/setting.js b/models/setting.js index d77930c30..a3857c870 100644 --- a/models/setting.js +++ b/models/setting.js @@ -1,4 +1,8 @@ -var Setting = DS.Model.extend({ +import ValidationEngine from 'ghost/mixins/validation-engine'; + +var Setting = DS.Model.extend(ValidationEngine, { + validationType: 'setting', + title: DS.attr('string'), description: DS.attr('string'), email: DS.attr('string'), diff --git a/validators/setting.js b/validators/setting.js new file mode 100644 index 000000000..9a61946c6 --- /dev/null +++ b/validators/setting.js @@ -0,0 +1,33 @@ +var SettingValidator = Ember.Object.create({ + validate: function (model) { + var validationErrors = [], + title = model.get('title'), + description = model.get('description'), + email = model.get('email'), + postsPerPage = model.get('postsPerPage'); + + if (!validator.isLength(title, 0, 150)) { + validationErrors.push({ message: 'Title is too long' }); + } + + if (!validator.isLength(description, 0, 200)) { + validationErrors.push({ message: 'Description is too long' }); + } + + if (!validator.isEmail(email) || !validator.isLength(email, 0, 254)) { + validationErrors.push({ message: 'Please supply a valid email address' }); + } + + if (!validator.isInt(postsPerPage) || postsPerPage > 1000) { + validationErrors.push({ message: 'Please use a number less than 1000' }); + } + + if (!validator.isInt(postsPerPage) || postsPerPage < 0) { + validationErrors.push({ message: 'Please use a number greater than 0' }); + } + + return validationErrors; + } +}); + +export default SettingValidator;