Renamed members-modal naming to portal

no issue

- Updated naming for members modal to portal in sync with rest of the codebase

app/components/gh-members-lab-setting.hbs

@@ -148,7 +148,7 @@
                     <p class="gh-setting-desc pa0 ma0">Customize members modal signup flow</p>
                 </div>
                 <div>
-                    <button type="button" class="gh-btn" {{action (toggle "showMembersModalSettings" this)}} data-test-toggle-membersFrom><span> Customize </span></button>
+                    <button type="button" class="gh-btn" {{action (toggle "showPortalSettings" this)}} data-test-toggle-membersFrom><span> Customize </span></button>
                 </div>
             </div>
         </section>
@@ -454,9 +454,9 @@
         @modifier="action wide" />
 {{/if}}
 
-{{#if this.showMembersModalSettings}}
-    <GhFullscreenModal @modal="members-modal-settings"
-        @close={{action "closeMembersModalSettings"}}
+{{#if this.showPortalSettings}}
+    <GhFullscreenModal @modal="portal-settings"
+        @close={{action "closePortalSettings"}}
         @modifier="full-overlay portal-settings" />
 {{/if}}
 {{#if this.showLeaveSettingsModal}}

app/components/gh-members-lab-setting.js

@@ -51,7 +51,7 @@ export default Component.extend({
     replyAddresses: null,
     showFromAddressConfirmation: false,
     showSupportAddressConfirmation: false,
-    showMembersModalSettings: false,
+    showPortalSettings: false,
     stripePlanInvalidAmount: false,
     _scratchStripeYearlyAmount: null,
     _scratchStripeMonthlyAmount: null,
@@ -153,12 +153,12 @@ export default Component.extend({
             this.toggleProperty('showFromAddressConfirmation');
         },
 
-        closeMembersModalSettings() {
+        closePortalSettings() {
             const changedAttributes = this.settings.changedAttributes();
             if (changedAttributes && Object.keys(changedAttributes).length > 0) {
                 this.set('showLeaveSettingsModal', true);
             } else {
-                this.set('showMembersModalSettings', false);
+                this.set('showPortalSettings', false);
             }
         },
 
@@ -304,7 +304,7 @@ export default Component.extend({
 
         leavePortalSettings() {
             this.settings.rollbackAttributes();
-            this.set('showMembersModalSettings', false);
+            this.set('showPortalSettings', false);
             this.set('showLeaveSettingsModal', false);
         }
     },