Commit Graph

2277 Commits

Author SHA1 Message Date
Kevin Ansfield 020f8015d8 Style inline-error fields and response test
issue #5652
- highlight input border and response text in red
2015-08-20 17:04:37 +01:00
Kevin Ansfield de57b2fc05 Mobile nav menu fixes
issue #5483 & #5652
- trigger the close menus action every time a route transition is successful
- close nav menu when clicking "collapse sidebar" button (action chain was incomplete)
2015-08-20 16:49:33 +01:00
Sebastian Gierlinger 183a7a1f18 Merge pull request #5689 from kevinansfield/fix-property-val-of-undefined
Fix occasional `Cannot read property 'val' of undefined` errors in console
2015-08-20 16:53:47 +02:00
Kevin Ansfield ad83bca937 Replace the current tag input with a selectize based input
issue #3800, closes #5648
- uses ember-cli-selectize addon for the tag editing functionality in the PSM
2015-08-20 14:40:56 +01:00
Kevin Ansfield bceb5d69e1 Fix flickering autonav animation
- use `transition: left` instead of `transform: translate3d`
- fixes issue where translate3d moves the element immediately then animates resulting in invisible hit areas that cause unexpected hover behaviour whilst animation is in progress
- translate3d is sometimes faster as it doesn't need to constantly re-calculate layout, however in this case the element is positon:absolute and we're only animating opaque elements so the benefit is marginal. Tested on Late-2012 13" retina MBP and framerate was consistently 100fps or higher.
2015-08-20 13:04:26 +01:00
Nazar Gargol a4e12f3575 Adds 'button' role to toggle icon for better a11y
closes #5696
- adds button role to toggle icon on new zelda menu
2015-08-20 12:51:44 +02:00
Kevin Ansfield 600b598168 Minor UI fixes for invitations
issue #5652
- display "Sending Invite..." text after clicking "RESEND" link
- change "Invitation sent" alert to notification
2015-08-20 10:36:36 +01:00
Austin Burdine cd1f7eccf0 fix auto width and height of spin button component
refs #5652
- changes the spin-button so that it only sets the size when the button is submitting instead of all of the time
2015-08-19 23:39:07 -04:00
Kevin Ansfield 2bf8ffc320 guard against missing $previewContent/ViewPort in gh-editor.scrollPosition
issue #5659
- fixes occasional issue with editor not rendering due to scrollPosition being requested before the relevant jquery elements have been set
2015-08-19 20:44:59 +01:00
Kevin Ansfield 8d8c298b2c guard against missing editor element in editor-base-controller.save
issue #5659
- Fixes occasional issue with `Uncaught TypeError: Cannot read property 'val' of undefined` errors appearing when navigating quickly to/from the editor. I traced the `save` action calls back to the `autoSave` method - it may warrant further investigation to find out why the throttled/debounced calls are sometimes made when the editor element is non-existent.
2015-08-19 20:43:30 +01:00
Kevin Ansfield f821ec0658 Update admin area jquery and jquery-ui dependencies
no issue
- updates jquery from 1.9.x to 2.1.x, dropping support for old IE
- updates jquery-ui from 1.10.4 to 1.11.4
2015-08-19 09:37:02 +01:00
Sebastian Gierlinger f983a4537e Merge pull request #5672 from jomahoney/signup-image
Update signup form to have profile image upload component
2015-08-16 18:49:13 +02:00
John O'Mahoney 37fd5fda9a Update signup form to have profile image upload component
closes #5544
- Added profile image into `signup.hbs`
- Added image handling in `signup.js` controller
- Uses session authenticated user to upload image
2015-08-15 13:00:42 +01:00
Jason Williams 6d12a9aa97 Update ember-myth
- ember-myth@0.1.1. Removes console.log debug output.
2015-08-14 22:35:26 -05:00
John O'Nolan 20de81624a Variety of style fixes
- Modal button position tweaked, removed extraneous margin
- Fix user profile full name field and mobile profile-picture
- Added chevron to tag settings men, corrected chevron colour
- Fixed regression in delete-tag button caused by removing flexbox from buttons
- Fixed regression in button positioning on about-ghost page caused by removing flexbox from buttons

See #5652
2015-08-13 10:04:45 +02:00
John O'Nolan 227486082e Fixed publish menu positioning, cleaned up dropdown component
See #5652
2015-08-13 09:09:07 +02:00
John O'Nolan 34437f1897 Kill old tag styles 2015-08-13 08:55:41 +02:00
John O'Nolan 1869124b31 Multiple minor visual style fixes
- Lighter dropdown shadow
- Removed display:flex from .btn because safari can't handle it on <button> elements, where it will immediately set all text-alignment to "left" with no way to change. I haven't been able to find any regressions for this change so far. Can't remember why buttons were supposed to be flexbox anyway. Maybe for icon alignment within buttons, but I can't find any such examples within the app.
- Safari thinks that user-select: all; means a single click should SELECT ALL THE THINGS. Removed/replaced with user-select: text; which makes it behave like Chrome; click and drag to select.
- Increased hit area for "?" button
- Removed :active style for post-edit button on content management screen, adjusted position
- Increased contrast on tag description, tag count, and view blog links

See #5652
2015-08-12 10:29:40 +02:00
John O'Nolan bfe62bac6c Prevent view titles from being cut off in Safari
See #5652
2015-08-12 09:17:01 +02:00
Hannah Wolfe 2b7aa6607c Merge pull request #5658 from acburdine/tag-fixes
fixed focus and duplication tag issues
2015-08-11 19:42:52 +01:00
Hannah Wolfe 4353a32e06 Merge pull request #5654 from cobbspur/bugfixes
Lock out email address on signup page
2015-08-11 18:06:12 +01:00
Austin Burdine 88053ef060 fixed focus and duplication tag issues
refs #5648
- adds default value to refocus in reloadTypeahead method to fix focus issues
- moves tag input clearing call up to avoid duplication.
2015-08-11 11:04:53 -06:00
cobbspur bd4729cbd7 Fix spinner on settings page
refs #5652

- stops spinner from spinning forever on settings screen when saving
2015-08-11 15:26:24 +01:00
cobbspur 9b777d89a6 Lock out email address on signup page
refs #5653

- disables email field
- pull error message from api response
2015-08-11 14:25:30 +01:00
cobbspur 1549f6dc69 Fix errors for setup and signup
refs #5635

- adds enter action to signup fields
- adds validation text errors
2015-08-10 22:24:10 +01:00
Hannah Wolfe 3e1b84310f Merge pull request #5633 from acburdine/spin-buttons
Add spin buttons
2015-08-10 19:06:32 +01:00
Austin Burdine 3c0bd3e8b2 add spin-button component & implement it
closes #3928
- adds spin-button component & styles
- implements spin-button in places where buttons trigger async tasks
2015-08-10 09:43:50 -06:00
Austin Burdine 87d4731a11 reimplement tag editing component for posts
refs #3800
- remove old tag editor code
- reimplement tag editor as an ember component
- add tag editor component to PSM
2015-08-10 07:22:37 -06:00
Hannah Wolfe 6648de5845 Merge pull request #5640 from cobbspur/errors
Fix server errors for signin
2015-08-10 13:20:53 +01:00
Hannah Wolfe bca7b173ff Merge pull request #5634 from acburdine/onboard-fixes
Fixes in setup/three
2015-08-10 13:17:28 +01:00
cobbspur 49241e7611 Fix signin errors
refs #5635

- fixes format for server errors
- changes signin-api validation errors to be text rather than alerts
2015-08-10 12:26:45 +01:00
Austin Burdine dcf292e8ca setup/three fixes
refs #5315
- adds call to loadServerNotifications so that notifications are loaded after setup
- fixes user invite so that you can't invite someone with the same email as you created the owner with
2015-08-09 22:40:27 -06:00
cobbspur ac28144f24 Fix signup bug
No Issue

- fixes bug that prevents successful signup from invite
2015-08-08 16:04:28 +01:00
cobbspur 58d07d656a Enter key submits form in setup step 2
Issue #5315

 - adds gh-input enter event to trigger setup action
 - removes html for unused password strength hint
2015-08-04 09:36:02 +01:00
Kevin Ansfield cd72b298a3 WIP: review uses of notifications.showErrors
issue #5409

`notifications.showErrors` was historically used to display multiple error notifications whether from validation errors or responses form the API. This usage needs to be reviewed as inline validations should handle the validation side and we should be displaying alerts for actual errors.

Eventually `notifications.showErrors` should be left unused and therefore removed.
2015-07-28 12:27:57 +01:00
Kevin Ansfield d4c8892ad5 Replace validation notifications with inline validations
issue #5409 & #5336

- update settings/general
- update signin
- update signup
- update edit user
- update reset password
- update setup/three
- remove `formatErrors` function from validationEngine mixin (it's no longer needed as inline validations should handle this instead)
2015-07-28 12:26:34 +01:00
Kevin Ansfield 1ba6bcc131 Refactor notifications service & components
issue #5409

- change persistent/passive notification status to alert/notification
- replace showSuccess/Info/Warn/Error with showNotification/showAlert
- fix and clean up notification/alert components
2015-07-28 12:26:11 +01:00
Jason Williams 5503fb39cc Merge pull request #5565 from acburdine/profile-debounce
Refactor setup controller to only pass valid email into profile image component
2015-07-22 09:53:30 -05:00
Jason Williams 8a68d7c405 Merge pull request #5596 from kevinansfield/fix-missing-code-injection-auth-redirect
Fix missing redirect on settings/code-injection when not authenticated
2015-07-22 09:51:28 -05:00
Kevin Ansfield 820bc3d3f1 Fix missing redirect on settings/code-injection when not authenticated
related issue #5412
- code-injection route was overriding `beforeModel` without calling `super` which meant the redirect handling added in `AuthenticatedRoute` was being skipped
2015-07-22 11:31:42 +01:00
Austin Burdine 704e7448b7 fix setup controller to pass in only a valid email to the profile-image component
closes #5563
2015-07-21 13:19:09 -04:00
cobbspur 36697da6d8 User Onboarding - flow navigation
closes #5317

- Adds back button to steps 2 and 3
- Prevents user navigating from step 1 to step 3 unless blog has been created
- Prevents user navigating from step 2 to step 3 unless blog has been created
2015-07-21 17:23:04 +01:00
Hannah Wolfe ca560d5575 Merge pull request #5575 from cobbspur/imageComponent
Disable image upload during setup for non persistent file storage
2015-07-19 23:23:08 +01:00
cobbspur e3a29b4c19 Disable image upload during setup for non persistent file storage
closes #5550

- passes config.fileStorage into gh-profile-image component
- does not render input tag if fileStorage is set to false
2015-07-18 20:26:27 +01:00
Jason Williams b68bdd3793 Use correct property when determining display URL
Closes #5574
2015-07-17 10:23:29 -05:00
John O'Nolan 49ac90abca Merge pull request #5542 from BlueHatbRit/reset-pass-page-style-fix
Correct reset passsword screen markup and styles
2015-07-15 16:56:14 +03:00
John O'Nolan 461d4a2df0 Merge pull request #5555 from halfdan/fix/invite
Fix team/index screen
2015-07-15 16:54:07 +03:00
Rem Zolotykh 8309b702e0 Allow editing blog details on setup
closes #5526
- when user creates blog we set `blogCreated` flag to true and
  depending on it make `POST` or `PUT` request
2015-07-15 03:17:55 +02:00
BlueHatbRit 7a8b45ccb2 Correct reset passsword screen markup
closes #5524
- changed markup to reflect styles of the sign in screen.
- remove html classes that are redundant.
2015-07-14 20:15:00 +01:00
Fabian Becker 138440c5a6 Fix team/index screen
- Incorrect message was shown (Invitation sent instead of Invitation not sent)
- Correct colouring of message (new .description-error class)
- Correctly display lastLogin time
- Add colour classes
2015-07-14 18:21:08 +02:00