9 commits

Author	SHA1	Message	Date
Kevin Ansfield	ac16e6504c	ESLint: Consistent ember property/method ordering ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md	2018-01-12 12:17:56 +00:00
Kevin Ansfield	238983a5df	Match service/controller import to ember-modules-codemod style for consistency ... no issue Automated tools, code generators, and editor integrations are increasingly standardising on the import style used in `ember-modules-codemod`. Our import style differed a little with regards to service/controller injection imports which meant we were starting to see inconsistent naming.	2017-10-30 09:38:01 +00:00
Kevin Ansfield	88449ed639	Switched from ember-cli-shims to new module imports (#779) ... no issue - add eslint-plugin-ember, configure no-old-shims rule - run `eslint --fix` on `app`, `lib`, `mirage`, and `tests` to move imports to the new module imports - further cleanup of Ember globals usage - remove event-dispatcher initializer now that `canDispatchToEventManager` is deprecated	2017-08-22 14:53:26 +07:00
Austin Burdine	2dff7edd3d	convert remainder of components to use ember-cli-shims (#101) ... follow up from #95 - converts components to use ember-cli-shims	2016-06-30 19:14:25 +01:00
Austin Burdine	b2c91dd3be	cleanup usage of Ember.inject	2016-01-19 07:03:27 -06:00
Kevin Ansfield	7ce3726589	Use es6 across client and add ember-suave to enforce rules ... no issue - add ember-suave dependency - upgrade grunt-jscs dependency - add a new .jscsrc for the client's tests directory that extends from client's base .jscsrc - separate client tests in Gruntfile jscs task so they pick up the test's .jscsrc - standardize es6 usage across client	2015-11-30 10:41:01 +00:00
Kevin Ansfield	d127d79019	Standardize on var-less export default across ember app ... no issue - drops the `var Foo = Ember.Thing.extend({}); export default Foo;` syntax in favour of exporting directly, eg: `export default Ember.Thing.extend({})` - discussion on this change [here](https://github.com/TryGhost/Ghost/pull/5340#issuecomment-105828423) and [here](https://github.com/TryGhost/Ghost/pull/5694#discussion-diff-37511606)	2015-10-06 10:59:50 +01:00
Jason Williams	3ef1167815	Use Ember.inject instead of needs and initializers ... No Issue - Switches to the newer style of dependency injection. - Instead of injection Controllers via "needs," use Ember.inject.controller(). - Get rid of initializers that were only injecting objects into various factories. Converts these objects into Ember.Service objects and declaratively inject them where needed via Ember.inject.service(). The added benefit to this is that it's no longer a mystery where these properties/methods come from and it's straightforward to inject them where needed.	2015-05-27 07:41:42 -05:00
Robert Jackson	9250273d8d	Replace gh-blog-url helper with a component. ... Accessing `this` inside an `Ember.HTMLBars.makeBoundHelper` will not always return the containing `view` object. Instead, use a component.	2015-05-05 14:40:18 -04:00