1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Commit graph

5503 commits

Author SHA1 Message Date
Kevin Ansfield f022401849 Prevent {} text replacements from receiving any formatting
no issue

- we don't want to allow text replacement strings to be split in half by html tags so we disallow any formats to be applied to them
- in the `<KoenigTextReplacementHtmlInput>`'s mobiledoc editor's `didUpdatePost` hook handler we loop over all markers in the post and if they have a code markup (we use this to represent replacement strings) then we strip any other markups
2020-04-17 17:49:16 +01:00
Kevin Ansfield 3ce08aba21 Fixed <code> being persisted to email card payload
no issue

- `<code>` formatting is internal to the text replacement html input and shouldn't be persisted in the payload html
- adjust `cleanTextReplacementHtml` to strip out all `<code>` tags
- adjust `<CleanTextReplacementHtmlInput>` to strip `<code>` formatting when outputting html via the `onChange` action and to also put the `<code>` formatting back when receiving html
- adjust `<KoenigEmailCard>` to add the `<code>` formatting back around any replacement strings so that they are visible in the editor
2020-04-17 16:00:19 +01:00
Kevin Ansfield 2e63e0f496 Fixed {} chars being removed when applying text replacement format
no issue

- we want to keep the `{` and `}` chars when applying/removing formatting from text replacement strings so that you can see the full string with formatting
- added ability to specify a non-replaced special format which is used by the <kbd>Backspace</kbd> handler
- added helper utility to the text expansions for applying formatting to a match without replacing the "markdown" characters
2020-04-17 14:49:54 +01:00
Kevin Ansfield e191ffe8c9 Fixed "special markups" not being separate across different editors
no issue

- if the character used to define a special markup is different such as in the text replacement editor, pressing Backspace was not inserting the correct characters
2020-04-17 14:11:19 +01:00
Kevin Ansfield 58f2755bcd Fixed mobiledoc-kit automatically upgrading document version
refs 50eaa8830b

- we previously set a fixed mobiledoc spec version in blank documents but when the editor was serializing to a json string after editing it was bumping the spec version
- makes the specific version a constant to be used when serializing any mobiledoc
2020-04-16 22:12:01 +01:00
Renovate Bot 69959453f4
Update dependency testem to v3.0.4 2020-04-15 22:15:02 +00:00
Daniel Lockyer 1a1cb22ba4 v3.13.3 2020-04-15 14:06:16 +01:00
Daniel Lockyer 428f0effac v3.13.2 2020-04-15 11:40:33 +01:00
renovate[bot] cc7a0edf4e
Update dependency walk-sync to v2.1.0 (#1547)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-14 17:37:47 +01:00
renovate[bot] 6082672893
Update dependency @tryghost/kg-parser-plugins to v0.10.0 (#1546)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-14 14:49:17 +01:00
Renovate Bot 35f83995c2
Update dependency @tryghost/timezone-data to v0.2.24 2020-04-13 18:17:06 +00:00
Renovate Bot 7c1b248512
Update dependency @tryghost/helpers to v1.1.27 2020-04-13 16:21:21 +00:00
renovate[bot] d636d5a84c
Update dependency ember-cli-htmlbars to v4.3.1 (#1543)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-13 09:33:51 +01:00
renovate[bot] ff9ca67c8c
Update dependency ember-resolver to v8 (#1545)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-13 09:17:55 +01:00
Renovate Bot 057d20f592
Update dependency @tryghost/timezone-data to v0.2.23 2020-04-10 21:18:05 +00:00
Renovate Bot 738d25222c Update dependency @tryghost/helpers to v1.1.26 2020-04-10 21:17:29 +00:00
Renovate Bot 1d79cdbaff
Update dependency @tryghost/string to v0.1.9 2020-04-10 18:47:26 +00:00
Nazar Gargol 734d8f02e3 Moved billing page to a popup
no issue

- To simplify styling and give a better separation feeling from UI perspective
2020-04-09 17:26:11 +12:00
Renovate Bot ed2019c73b
Update dependency @tryghost/kg-parser-plugins to v0.9.3 2020-04-08 15:21:12 +00:00
Renovate Bot 19e9ced75d
Update dependency @tryghost/kg-clean-basic-html to v0.1.8 2020-04-08 13:57:05 +00:00
Peter Zimon b9a5ce5af1 Added email indicator icon, card menu style bugfix
no refs.
- added indicator icon to appropriately show which card is a newsletter email one
- fixed bug of card menu staying the same height when triggered via "/" menu
2020-04-08 14:01:04 +02:00
Peter Zimon d83b5ce21c Added email icon to Koenig card menu
no refs.
- added appropriate icon to Koenig menu to support newsletter email cards
2020-04-08 13:52:48 +02:00
Daniel Lockyer 4b68c5ef37 v3.13.1 2020-04-07 16:03:38 +01:00
Daniel Lockyer 67c2d0b94c v3.13.0 2020-04-07 11:12:52 +01:00
Renovate Bot 796e916879
Update dependency autoprefixer to v9.7.6 2020-04-06 21:22:32 +00:00
Rish 5b196391e4 Fixed save test
no issue
2020-04-06 18:02:19 +05:30
Daniel Lockyer 67984b0080 Switched to using built-in Node.js for tests
no issue

- setup-node was randomly failing to download because of an upstream Node issue
- this commit switches to using the build in Node version
2020-04-06 13:14:13 +01:00
Kevin Ansfield 7c38bdccb3 Removed errant console.log 2020-04-06 13:12:17 +01:00
Rishabh Garg 825161422f
💄Updated save buttons to reset state (#1522)
* Updated save buttons to reset state

no issue

Currently the save buttons across Admin don't auto-reset to idle state after success/failure on run which can give false impression once user changes any value. This PR auto-resets the button to idle state after a fixed timeout if no subsequent action is performed as a short term UX improvement.

* Fixed success check for auto reset

* Updated timeout value

* Added explicit save button reset for pages

* Updated save buttons to reset via shortcut

Auto-reset for save buttons wasn't working if not done through manual click on task button previously, this handles by splitting the original save task in controller to handle shortcut saves.

* Updated reset check for only successful tasks

* Added save reset to code-injection and design settings

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2020-04-06 16:17:28 +05:30
Daniel Lockyer 9ace749826 Revert "Switched to Node.js container in Action"
- this reverts commit e4df8e15c2.
- the tests require more components than Node, which the container
  doesn't have
2020-04-06 11:35:51 +01:00
Daniel Lockyer e4df8e15c2 Switched to Node.js container in Action
no issue

- using the setup-node action is currently failing because of an
  upstream issue - https://github.com/nodejs/node/issues/32683
- this commit switches to using a Docker container
2020-04-06 11:27:54 +01:00
Kevin Ansfield bf7b1e0e33 Added first draft of email-only card
no issue

- adds "Email" card to the card menus when developer experiments is turned on
- adds `<KoenigTextReplacementHtmlInput>` implementing most of Koenig except:
  - uses html as it's input/output format
  - replaces backtick "code" formatting with `{replacement}`
  - no headings
  - no cards at all
  - minimal toolbar but all formatting is still available using markdown text expansions or keyboard shortcuts
2020-04-06 10:56:40 +01:00
Kevin Ansfield b4feb11af1 🐛 Fixed Ctrl/Cmd+Enter toggling cards into edit mode
no issue

- the card wrapper component was registering an event handler for keyboard events when entering edit mode. This was a problem because those events were also picking up the initial ctrl/cmd+enter and then immediately toggling back out of edit mode
- added a 20ms timeout for registering the event handlers so that they're not working cross-purposes
2020-04-06 10:49:23 +01:00
Renovate Bot bd057a5bc0 Update dependency chai-dom to v1.8.2 2020-04-03 16:35:09 +00:00
Renovate Bot bad821a187
Update dependency @tryghost/timezone-data to v0.2.22 2020-04-03 12:56:11 +00:00
Renovate Bot a04e4a4529
Update dependency @tryghost/string to v0.1.8 2020-04-03 10:18:25 +00:00
Renovate Bot 081e4241bb
Update dependency @tryghost/helpers to v1.1.25 2020-04-03 08:17:15 +00:00
renovate[bot] 7561a026ac
Update dependency broccoli-merge-trees to v4.2.0 (#1539)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-04-02 09:36:31 +01:00
Renovate Bot e4517d878e
Update dependency ember-fetch to v8.0.1 2020-03-30 21:56:13 +00:00
renovate[bot] 4c55b50161
Update dependency ember-fetch to v8 (#1538)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:58:05 +01:00
renovate[bot] a30ab6bf2b
Update dependency ember-fetch to v7.1.0 (#1537)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:05:43 +01:00
renovate[bot] 92e5b96568
Update dependency ember-cli-babel to v7.19.0 (#1536)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:05:13 +01:00
renovate[bot] 759cb9fe4c
Update dependency blueimp-md5 to v2.13.0 (#1534)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-03-30 10:03:12 +01:00
Renovate Bot 35548faecc
Update dependency ember-concurrency to v1.1.7 2020-03-30 00:16:52 +00:00
Renovate Bot 0ae90de0c7
Update dependency reframe.js to v2.2.8 2020-03-27 07:40:28 +00:00
Renovate Bot 453e83cf03
Update dependency @tryghost/timezone-data to v0.2.21 2020-03-27 00:43:12 +00:00
Renovate Bot 8195f90dcf
Update dependency @tryghost/helpers to v1.1.24 2020-03-26 23:16:48 +00:00
Renovate Bot ccae514304
Update dependency @tryghost/string to v0.1.7 2020-03-26 21:31:02 +00:00
Daniel Lockyer 513c62dd3b Version bump to 3.12.1 2020-03-26 14:29:11 +00:00
Kevin Ansfield 50eaa8830b Switched to explicit mobiledoc version for new posts
no issue

- when the mobiledoc spec changes due to a mobiledoc-kit version bump, any posts created with that version will fail to load in the editor if a rollback to an earlier Ghost version occurs
- use an explicit version to avoid the problem - we should only be bumping the mobiledoc spec version if we start using features from that version and mark it as a breaking change
2020-03-26 14:27:41 +00:00