10 Commits

Author	SHA1	Message	Date
Kevin Ansfield	ac16e6504c	ESLint: Consistent ember property/method ordering ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md	2018-01-12 12:17:56 +00:00
Kevin Ansfield	c903dc9efc	Remove unused top notification count functionality ... no issue - in a very old iteration of the admin design we needed a data attribute containing the number of notifications in order to add extra spacing in the styles. This hasn't been necessary for a long time and there are easier ways to do it now than using observers.	2017-11-24 11:15:59 +00:00
Kevin Ansfield	238983a5df	Match service/controller import to ember-modules-codemod style for consistency ... no issue Automated tools, code generators, and editor integrations are increasingly standardising on the import style used in `ember-modules-codemod`. Our import style differed a little with regards to service/controller injection imports which meant we were starting to see inconsistent naming.	2017-10-30 09:38:01 +00:00
Kevin Ansfield	88449ed639	Switched from ember-cli-shims to new module imports (#779) ... no issue - add eslint-plugin-ember, configure no-old-shims rule - run `eslint --fix` on `app`, `lib`, `mirage`, and `tests` to move imports to the new module imports - further cleanup of Ember globals usage - remove event-dispatcher initializer now that `canDispatchToEventManager` is deprecated	2017-08-22 14:53:26 +07:00
Kevin Ansfield	7eefbba69f	💄🐷 sort-imports eslint rule (#712) ... no issue - adds `eslint-plugin-sort-imports-es6-autofix` dependency - implements ESLint's base `sort-imports` rule but has a distinction in that `import {foo} from 'bar';` is considered `multiple` rather than `single` - fixes ESLint's autofix behaviour so `eslint --fix` will actually fix the sort order - updates all unordered import rules by using `eslint --fix` With the increased number of `import` statements since Ember+ecosystem started moving towards es6 modules I've found it frustrating at times trying to search through randomly ordered import statements. Recently I've been sorting imports manually when I've added new code or touched old code so I thought I'd add an ESLint rule to codify it.	2017-05-29 20:50:03 +02:00
Austin Burdine	2dff7edd3d	convert remainder of components to use ember-cli-shims (#101) ... follow up from #95 - converts components to use ember-cli-shims	2016-06-30 19:14:25 +01:00
Austin Burdine	b2c91dd3be	cleanup usage of Ember.inject	2016-01-19 07:03:27 -06:00
Kevin Ansfield	7ce3726589	Use es6 across client and add ember-suave to enforce rules ... no issue - add ember-suave dependency - upgrade grunt-jscs dependency - add a new .jscsrc for the client's tests directory that extends from client's base .jscsrc - separate client tests in Gruntfile jscs task so they pick up the test's .jscsrc - standardize es6 usage across client	2015-11-30 10:41:01 +00:00
Kevin Ansfield	1ba6bcc131	Refactor notifications service & components ... issue #5409 - change persistent/passive notification status to alert/notification - replace showSuccess/Info/Warn/Error with showNotification/showAlert - fix and clean up notification/alert components	2015-07-28 12:26:11 +01:00
Austin Burdine	85a16e3551	fixed notification components	2015-05-22 19:05:17 +01:00