Go to file
Kevin Ansfield 17b3ced8c9 Always call `_super` when using Ember hooks
no issue
- review use of Ember core hooks and add a call to `this._super` if missing
- fix a few occurrences of using the wrong component lifecycle hooks that could result in multiple/duplicate event handlers being attached

`_super` should always be called when overriding Ember's base hooks so that core functionality or app functionality added through extensions, mixins or addons is not lost. This is important as it guards against issues arising from later refactorings or core changes.

As example of lost functionality, there were a number of routes that extended from `AuthenticatedRoute` but then overrode the `beforeModel` hook without calling `_super` which meant that the route was no longer treated as authenticated.
2015-11-30 12:45:37 +00:00
app Always call `_super` when using Ember hooks 2015-11-30 12:45:37 +00:00
config Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
lib Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
public/assets Added multiline "placeholder" to 3rd step of setup 2015-07-01 23:14:27 +02:00
tests Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
.ember-cli grunt init, dev 2015-03-11 12:37:41 -06:00
.gitignore Convert Sass to Myth 2015-05-22 19:05:09 +01:00
.jscsrc Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
.jshintrc Set up ember-cli-mirage and update existing acceptance tests 2015-11-03 15:35:58 +00:00
.watchmanconfig updates Ember-CLI to 0.2.7 2015-06-08 09:18:50 -04:00
bower.json Specify full SHAs when importing packages in bower.json 2015-11-24 16:39:14 +00:00
ember-cli-build.js Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
package.json Use es6 across client and add ember-suave to enforce rules 2015-11-30 10:41:01 +00:00
testem.json Fix random ember test failures 2015-10-14 11:26:21 +01:00