1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app
Kevin Ansfield 39ecd67d13 Fixed unsaved changes modal showing after focus/blur of tag and member fields
no issue

- the inputs in tag/member settings are now two-way bound which means that a `null` or `undefined` value can become `""` when a field is focused/blurred due to inputs only working on strings
- if a `null` or `undefined` property value becomes `""` Ember Data will treat that as a dirty property and that will in turn trigger the unsaved changes modal when leaving the tag/member details screens
- this change strengthens our `_saveXProperty` private controller methods to skip any changes between "falsy" property values unless the new value is explicitly `false`
2019-12-16 17:02:19 +00:00
..
adapters Added ability to retry failed emails from the confirm modal (#1412) 2019-11-22 15:09:48 +00:00
authenticators Added "What's new" indicator and modal to highlight recent updates (#1292) 2019-08-23 10:01:27 +01:00
components Converted <GhErrorMessage> to glimmer component 2019-12-13 16:12:04 +00:00
controllers Fixed unsaved changes modal showing after focus/blur of tag and member fields 2019-12-16 17:02:19 +00:00
errors Added polling when confirming email to show immediate error 2019-11-20 23:27:09 +00:00
helpers 🎨 Added gravatars for member avatars (#1417) 2019-12-03 18:10:47 +07:00
initializers Bumped dependencies (Fixed production build) (#1091) 2019-01-08 12:36:16 +00:00
mixins Added member "add" screen (#1411) 2019-11-28 18:30:21 +07:00
models Added Secondary Navigation (#1410) 2019-12-04 11:14:45 +07:00
routes 🐛 Fixed unexpected "unsaved changes" modals when accessing screens 2019-12-13 17:09:06 +00:00
serializers Added member "add" screen (#1411) 2019-11-28 18:30:21 +07:00
services Added new top-level bulk email settings 2019-11-13 22:38:16 +05:30
session-stores Use Admin API v2 with session auth (#1046) 2018-10-05 19:46:33 +01:00
styles 🐛 Fixed darkmode color regressions 2019-12-16 15:04:32 +01:00
templates Converted <GhErrorMessage> to glimmer component 2019-12-13 16:12:04 +00:00
transforms Added Secondary Navigation (#1410) 2019-12-04 11:14:45 +07:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Switched Admin API version from canary to v3 (#1317) 2019-09-03 12:40:27 +05:30
validators Added member "add" screen (#1411) 2019-11-28 18:30:21 +07:00
app.js Removed unnecessary TextField override 2019-02-11 13:51:10 +00:00
index.html 🤡 Serve own admin favicon (#619) 2017-04-06 17:28:51 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
resolver.js deps: ember-cli@2.3.0 2016-02-16 12:32:48 -06:00
router.js Cleaned up and re-organised tag and new tag routes/controllers 2019-12-09 17:44:16 +00:00
transitions.js Unsplash integration 2017-08-15 16:01:12 +01:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)