1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app
Kevin Ansfield c59f9351f9 Fix inability to write posts as an author (#405)
closes TryGhost/Ghost#7730
- treat `Post.authorID` as a string not a number as it's now an objectid
- update `isAuthoredByUser` method so that author's posts aren't hidden from them
- update the post compare method so that it doesn't try to parse objectids as integers (may need revisiting now that we don't have auto-increment IDs to fall back on)
2016-11-17 20:08:11 +00:00
..
adapters Update code to match eslint rules 2016-11-14 13:26:00 +00:00
authenticators Update code to match eslint rules 2016-11-14 13:26:00 +00:00
authorizers deps: ember-simple-auth@1.0.0 2015-10-18 13:17:02 -05:00
components Update code to match eslint rules 2016-11-14 13:26:00 +00:00
controllers Update code to match eslint rules 2016-11-14 13:26:00 +00:00
helpers Update code to match eslint rules 2016-11-14 13:26:00 +00:00
html Slack integration 2016-05-08 12:49:15 +02:00
initializers "400 Version Mismatch" error handling 2016-07-08 14:56:26 +01:00
instance-initializers convert ember imports to ember-cli-shim imports where possible (#95) 2016-06-30 11:21:47 +01:00
mirage Remove UUID attrs from all models except Post (#404) 2016-11-17 11:38:47 -06:00
mixins Update code to match eslint rules 2016-11-14 13:26:00 +00:00
models Fix inability to write posts as an author (#405) 2016-11-17 20:08:11 +00:00
routes 🎨 invites roles table into a field on the invites table (#394) 2016-11-16 11:01:58 +00:00
serializers Remove UUID attrs from all models except Post (#404) 2016-11-17 11:38:47 -06:00
services Update code to match eslint rules 2016-11-14 13:26:00 +00:00
session-stores Update code to match eslint rules 2016-11-14 13:26:00 +00:00
styles Editor and 1.0 style updates 2016-11-14 16:55:08 +07:00
templates 🎨 invites roles table into a field on the invites table (#394) 2016-11-16 11:01:58 +00:00
torii-providers Fetch config from endpoint rather than meta tags (#368) 2016-10-28 14:07:50 +01:00
transforms Update code to match eslint rules 2016-11-14 13:26:00 +00:00
utils Update code to match eslint rules 2016-11-14 13:26:00 +00:00
validators Update code to match eslint rules 2016-11-14 13:26:00 +00:00
_config.yml The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
app.js "400 Version Mismatch" error handling 2016-07-08 14:56:26 +01:00
index.html Fetch config from endpoint rather than meta tags (#368) 2016-10-28 14:07:50 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
resolver.js deps: ember-cli@2.3.0 2016-02-16 12:32:48 -06:00
router.js theme management UI 2016-08-23 12:42:38 +01:00
transitions.js refactor gh-fullscreen-modal component to use liquid-wormhole directly (#281) 2016-10-07 14:27:39 +01:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)