1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app
Kevin Ansfield 78dce694e2 fix malformed CSS that was breaking production builds
no issue
- cssnano was erroring with `Error: Unexpected "space" found`
2017-03-02 11:52:33 +00:00
..
adapters fix test warnings (#492) 2017-01-13 21:14:54 +00:00
authenticators Update code to match eslint rules 2016-11-14 13:26:00 +00:00
authorizers deps: ember-simple-auth@1.0.0 2015-10-18 13:17:02 -05:00
components 🐛 display correct expired/expires text for invites (#550) 2017-02-27 13:11:39 +00:00
controllers remove unnecessary posts/index route (#545) 2017-02-23 18:47:52 +00:00
helpers 🐛 correctly count multibyte chars in character counters (#487) 2017-01-11 14:45:22 +01:00
html Style updates to new app frame for all other screens 2017-02-17 10:14:16 +00:00
initializers prevent ember searching for non-existant custom event dispatchers 2017-02-04 09:01:52 -06:00
instance-initializers convert ember imports to ember-cli-shim imports where possible (#95) 2016-06-30 11:21:47 +01:00
mixins fix double-render issues with validation-state mixin 2017-02-01 17:03:38 -06:00
models renamed to koenig 2017-03-02 09:56:52 +00:00
routes remove unnecessary posts/index route (#545) 2017-02-23 18:47:52 +00:00
serializers fetch themes from /themes endpoint (#542) 2017-02-21 18:28:44 +00:00
services 🐛 fix double slashes in URLs (#506) 2017-01-26 13:45:11 +01:00
session-stores Update code to match eslint rules 2016-11-14 13:26:00 +00:00
styles fix malformed CSS that was breaking production builds 2017-03-02 11:52:33 +00:00
templates Card menu styles and editor tweaks 2017-03-02 09:56:52 +00:00
torii-providers use current URI instead of configured blog URI for OAuth redirectURI (#518) 2017-02-01 16:15:47 +00:00
transforms Update code to match eslint rules 2016-11-14 13:26:00 +00:00
utils Update code to match eslint rules 2016-11-14 13:26:00 +00:00
validators Update code to match eslint rules 2016-11-14 13:26:00 +00:00
_config.yml The great migration (EAK -> ember-cli) 2015-03-11 12:37:41 -06:00
app.js Implemented new toolbar styling and layout. 2017-03-02 09:56:52 +00:00
index.html display a spinner whilst the app is loading (#491) 2017-01-15 15:11:43 -06:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
resolver.js deps: ember-cli@2.3.0 2016-02-16 12:32:48 -06:00
router.js rename settings/navigation -> settings/design, move theme management (#543) 2017-02-21 19:04:50 +00:00
transitions.js refactor gh-fullscreen-modal component to use liquid-wormhole directly (#281) 2016-10-07 14:27:39 +01:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)