mirror of
https://github.com/TryGhost/Ghost-Admin.git
synced 2023-12-14 02:33:04 +01:00
67765897b2
Initial Subscribers screen
- set up mocked api endpoints
- basic subscribers screen with data loading, infinite scroll
"Add Subscriber" screen
- uses modal to display a new subscriber form
- validates subscriber e-mail address
- moves pagination from route into controller to use filtered/sorted CPs on top of a live-query so that new subscribers are added to the list and the total can be properly managed
TODO:
- there is currently a pretty serious performance issue where the whole table is re-rendered when the live-query is updated. `ember-light-table` doesn't allow for live-binding and has no options to easily manipulate it's rows using an external interface - it's possible to move the page loading into the component so we only render new rows but that leaves it difficult to react to new subscribers being added through the UI. I believe the number of components used within the table is also adding to the performance problems.
- most likely solution is to drop `ember-light-table` in favour of rendering the table directly - glimmer should do a good job of fast updates even though the underlying array will be completely swapped out
"Import subscribers" screen
- uses modal to display an import subscribers CSV file upload form
- displays upload progress
- displays import stats and reloads subscribers table once import has completed
- adds `gh-file-uploader` component (NB. pared down copy of `gh-image-uploader`, ripe for some refactoring)
- fixes subscribers acceptance test failing because fixtures did not have the labs flag enabled
Unfortunately this doesn't have 100% test coverage as we're limited in how we can simulate file uploads 😞
Fix performance issues with subscribers table
- moves the table definition from the component up to the controller
- switches back to manually manipulating table rows instead of using a live-query
This is a quick-fix in that it allows us to continue using the `ember-light-table` component but it does mean that we lose some flexibility that the live-query gave us. For now it's not much of an issue and it allows us to defer deeper performance/flexibility work until we have a concrete need and requirements.
Hook up Export CSV button
- use a hidden iFrame to trigger the browser to hit the CSV export endpoint and download the file
Re-order subscribers table by clicking column headers
- displays currently sorted column and sort direction
- clicking a column header re-fetches the data from the server with the appropriate query params
Fix scroll triggers for infinite pagination + icon change
- adds a debounce as well as the throttle so that we always get a final scroll trigger once scrolling has stopped
- changes the subscribers icon from the temporary team icon to the mail icon
150 lines
3.8 KiB
JavaScript
150 lines
3.8 KiB
JavaScript
import Ember from 'ember';
|
|
import { invoke, invokeAction } from 'ember-invoke-action';
|
|
import {
|
|
RequestEntityTooLargeError,
|
|
UnsupportedMediaTypeError
|
|
} from 'ghost/services/ajax';
|
|
|
|
const {
|
|
Component,
|
|
computed,
|
|
inject: {service},
|
|
isBlank,
|
|
run
|
|
} = Ember;
|
|
|
|
export default Component.extend({
|
|
tagName: 'section',
|
|
classNames: ['gh-image-uploader'],
|
|
classNameBindings: ['dragClass'],
|
|
|
|
labelText: 'Select or drag-and-drop a file',
|
|
url: null,
|
|
paramName: 'file',
|
|
|
|
file: null,
|
|
response: null,
|
|
|
|
dragClass: null,
|
|
failureMessage: null,
|
|
uploadPercentage: 0,
|
|
|
|
ajax: service(),
|
|
|
|
formData: computed('file', function () {
|
|
let paramName = this.get('paramName');
|
|
let file = this.get('file');
|
|
let formData = new FormData();
|
|
|
|
formData.append(paramName, file);
|
|
|
|
return formData;
|
|
}),
|
|
|
|
progressStyle: computed('uploadPercentage', function () {
|
|
let percentage = this.get('uploadPercentage');
|
|
let width = '';
|
|
|
|
if (percentage > 0) {
|
|
width = `${percentage}%`;
|
|
} else {
|
|
width = '0';
|
|
}
|
|
|
|
return Ember.String.htmlSafe(`width: ${width}`);
|
|
}),
|
|
|
|
dragOver(event) {
|
|
event.preventDefault();
|
|
this.set('dragClass', '--drag-over');
|
|
},
|
|
|
|
dragLeave(event) {
|
|
event.preventDefault();
|
|
this.set('dragClass', null);
|
|
},
|
|
|
|
drop(event) {
|
|
event.preventDefault();
|
|
this.set('dragClass', null);
|
|
if (event.dataTransfer.files) {
|
|
invoke(this, 'fileSelected', event.dataTransfer.files);
|
|
}
|
|
},
|
|
|
|
generateRequest() {
|
|
let ajax = this.get('ajax');
|
|
let formData = this.get('formData');
|
|
let url = this.get('url');
|
|
|
|
invokeAction(this, 'uploadStarted');
|
|
|
|
ajax.post(url, {
|
|
data: formData,
|
|
processData: false,
|
|
contentType: false,
|
|
dataType: 'text',
|
|
xhr: () => {
|
|
let xhr = new window.XMLHttpRequest();
|
|
|
|
xhr.upload.addEventListener('progress', (event) => {
|
|
this._uploadProgress(event);
|
|
}, false);
|
|
|
|
return xhr;
|
|
}
|
|
}).then((response) => {
|
|
this._uploadSuccess(JSON.parse(response));
|
|
}).catch((error) => {
|
|
this._uploadFailed(error);
|
|
}).finally(() => {
|
|
invokeAction(this, 'uploadFinished');
|
|
});
|
|
},
|
|
|
|
_uploadProgress(event) {
|
|
if (event.lengthComputable) {
|
|
run(() => {
|
|
let percentage = Math.round((event.loaded / event.total) * 100);
|
|
this.set('uploadPercentage', percentage);
|
|
});
|
|
}
|
|
},
|
|
|
|
_uploadSuccess(response) {
|
|
invokeAction(this, 'uploadSuccess', response);
|
|
invoke(this, 'reset');
|
|
},
|
|
|
|
_uploadFailed(error) {
|
|
let message;
|
|
|
|
if (error instanceof UnsupportedMediaTypeError) {
|
|
message = 'The file type you uploaded is not supported.';
|
|
} else if (error instanceof RequestEntityTooLargeError) {
|
|
message = 'The file you uploaded was larger than the maximum file size your server allows.';
|
|
} else if (error.errors && !isBlank(error.errors[0].message)) {
|
|
message = error.errors[0].message;
|
|
} else {
|
|
message = 'Something went wrong :(';
|
|
}
|
|
|
|
this.set('failureMessage', message);
|
|
invokeAction(this, 'uploadFailed', error);
|
|
},
|
|
|
|
actions: {
|
|
fileSelected(fileList) {
|
|
this.set('file', fileList[0]);
|
|
run.schedule('actions', this, function () {
|
|
this.generateRequest();
|
|
});
|
|
},
|
|
|
|
reset() {
|
|
this.set('file', null);
|
|
this.set('uploadPercentage', 0);
|
|
this.set('failureMessage', null);
|
|
}
|
|
}
|
|
});
|