1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost-Admin.git synced 2023-12-14 02:33:04 +01:00
Ghost-Admin/app
Kevin Ansfield fa8a08e40b
Removed usage of ember-light-table in subscribers screen (#1191)
no issue

`ember-light-table` is falling behind Ember.js and other addon development and is increasingly causing issues with Ember deprecations and addon incompatibility.

- swaps `ember-light-table` usage for a straightforward table using `vertical-collection` for occlusion
- uses the same loading mechanism as the members screen with a slight optimisation where the initial load will fetch subscribers in batches of 200 until they are all loaded
- removes now-unused pagination mixin
- fixes duplicate subscriber validation handling
2019-05-07 12:39:56 +01:00
..
adapters Removed use of ?include=tags,authors,authors.roles query param on post/page requests 2019-02-25 21:55:55 +07:00
authenticators Use Admin API v2 with session auth (#1046) 2018-10-05 19:46:33 +01:00
components Removed usage of ember-light-table in subscribers screen (#1191) 2019-05-07 12:39:56 +01:00
controllers Removed usage of ember-light-table in subscribers screen (#1191) 2019-05-07 12:39:56 +01:00
helpers Removed usage of ember-light-table in subscribers screen (#1191) 2019-05-07 12:39:56 +01:00
initializers Bumped dependencies (Fixed production build) (#1091) 2019-01-08 12:36:16 +00:00
mixins Removed usage of ember-light-table in subscribers screen (#1191) 2019-05-07 12:39:56 +01:00
models Updated member management data (#1150) 2019-04-16 20:32:43 +05:30
routes Removed usage of ember-light-table in subscribers screen (#1191) 2019-05-07 12:39:56 +01:00
serializers 🐛 Fixed error when creating subscribers via the admin area 2019-03-06 09:19:39 +00:00
services 🐛 Fixed night shift toggle in Firefox Nightly. (#1174) 2019-04-25 09:40:26 +02:00
session-stores Use Admin API v2 with session auth (#1046) 2018-10-05 19:46:33 +01:00
styles Added language selection to code cards (#1180) 2019-04-30 16:46:29 +02:00
templates Removed usage of ember-light-table in subscribers screen (#1191) 2019-05-07 12:39:56 +01:00
transforms Updated member management data (#1150) 2019-04-16 20:32:43 +05:30
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Added integration details to Zapier integration screen behind dev flag 2019-04-04 12:25:16 +01:00
validators Added ability to override the canonical URL of posts/pages 2019-03-12 10:40:07 +00:00
app.js Removed unnecessary TextField override 2019-02-11 13:51:10 +00:00
index.html 🤡 Serve own admin favicon (#619) 2017-04-06 17:28:51 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
resolver.js deps: ember-cli@2.3.0 2016-02-16 12:32:48 -06:00
router.js View site inside Ghost Admin 2019-03-21 10:33:14 +01:00
transitions.js Unsplash integration 2017-08-15 16:01:12 +01:00

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)