Commit Graph

10677 Commits

Author SHA1 Message Date
Daniel Lockyer 6dcb1094aa Refactored variable name to match intent
no issue
2020-02-20 11:56:01 +00:00
Daniel Lockyer 55bd1cdd6b Fixed use of deprecated function in test suite
no issue
2020-02-19 19:59:05 +00:00
Daniel Lockyer f8b85354d3 Combined Ghost-CLI tests into one GitHub Action job
no issue
2020-02-19 18:18:00 +00:00
Renovate Bot 32e706991c Update dependency mysql to v2.18.1 2020-02-19 14:06:17 +00:00
Nazar Gargol a1fef1fc7c Added `created_at` field to accepted fields for members CSV import
no issue

- This field is usefult when importing from external sources.
- The date format should be compatible with one used internally by Ghost which is RFC 2822 compliant format
2020-02-19 19:55:32 +08:00
Kevin Ansfield 8e78c5f19c Fixed member API regression tests
no issue

- added `avatar_image` to the expected members API response shape
2020-02-19 10:49:21 +00:00
Kevin Ansfield 19812f53f4
Added `member.avatar_image` for member gravatars in themes (#11584)
refs https://github.com/TryGhost/Team/issues/243

- uses `member.toJSON()` to add a computed `avatar_image` property
  - if the member has an email address and gravatar is not disabled then we generate a gravatar url using the `?d=blank` parameter to return a transparent image if the member's email has no gravatar
2020-02-19 10:08:12 +00:00
Daniel Lockyer e7d2d440e0 Enabled full test suite on Renovate PRs
no issue

- only regression tests were being run on Renovate PRs, which allowed
  bad updates to go through
- this commit enables the full test suite
2020-02-19 09:50:26 +00:00
Daniel Lockyer e8dd42d040 Revert "Update dependency grunt-mocha-cli to v5"
This reverts commit 7e5490aab4.
2020-02-19 09:46:09 +00:00
Renovate Bot 7e5490aab4 Update dependency grunt-mocha-cli to v5 2020-02-18 21:24:11 +00:00
Renovate Bot 4cfdd33347 Update dependency sanitize-html to v1.21.1 2020-02-18 20:59:52 +00:00
Renovate Bot 9519e4be6b Update dependency uuid to v3.4.0 2020-02-18 20:26:15 +00:00
Renovate Bot e173d08663 Update dependency chalk to v3 2020-02-18 20:01:21 +00:00
Renovate Bot f2c050a105 Update dependency ajv to v6.11.0 2020-02-18 19:01:19 +00:00
Daniel Lockyer 9ccb0346a4 Version bump to 3.7.0 2020-02-18 12:23:18 +00:00
Daniel Lockyer 71a35092b0 Updated Ghost-Admin to 3.7.0 2020-02-18 12:23:18 +00:00
Kevin Ansfield 354e946e6e 🐛 Fixed "Unable to update nested relation" error when adding labels to members
no issue

- 3.6.0 contained incorrect references in the `schema.js` file for the `members_label` table that was added in that version. On MySQL knex created a foreign key constraint for that reference which stopped member labels from being createable
- this fixes the schema file and has a migration to drop and recreate the table. Knex handles removal and addition of foreign keys during table drop/create
2020-02-18 09:08:28 +00:00
Nazar Gargol 6db07ce34d 🐛 Fixed member CSV import setting subscribed to `true` as default
no issue

- When importing through CSV we should remain the defaults of 'subscribed' fields (`true` at the moment), unless it is explicitly set to `false` or `FALSE` (the latter uppercase value often comes from scpredsheets)
2020-02-18 11:34:20 +08:00
Daniel Lockyer 28071a242a Fixed error reporting to Sentry
no issue

- some errors weren't being reported because they were being passed to
  Sentry before our middleware could populate the error information
- this commit inserts the Sentry middleware into these steps
2020-02-17 13:52:01 +00:00
Hannah Wolfe a8e4492109 Added CODEOWNERS file to protect DB migrations
- DB migrations are risky changes
- require review from devops before merging these
2020-02-17 13:05:09 +00:00
Kevin Ansfield 02c034068c Fixed error when serving public images from `servePublicFile` middleware
no issue

- when `servePublicFile` middleware serves an image it resulted in a "Cannot set headers after they are sent to the client" error because `next()` was erroneously called for successful requests which then tripped the `prettyUrls` middleware which tries to perform a redirect
- only calling `next()` when an error is present allows errors to be picked up by later middleware but successful requests end in the `servePublicFile` middleware
2020-02-17 09:24:15 +00:00
Nazar Gargol 8def4fb402 Bumped @tryghost/members-api to 0.15.1
no issue

- This bump removed limitation to cancel/renew "Complimentary" plan subscription
2020-02-17 16:31:23 +08:00
Renovate Bot 63b6bb58ad Update dependency @tryghost/vhost-middleware to v1.0.1 2020-02-17 01:18:44 +00:00
Daniel Lockyer b7f1579968 Version bump to 3.6.0 2020-02-14 11:50:36 +00:00
Daniel Lockyer 669987eaf6 Updated Ghost-Admin to 3.6.0 2020-02-14 11:50:36 +00:00
Rish fede3d05f5 Fixed members tests
no issue
2020-02-14 16:06:25 +05:30
Rish c5833aa1d9 Fixed tests
no issue
2020-02-14 15:50:49 +05:30
Rish 7f337743e9 Fixed tests
no issue
2020-02-14 15:44:47 +05:30
Rishabh Garg 001db05075
Added labels for Members (#11538)
no issue

* Updated sendEmailWithMagicLink syntax

* Updated label name selection from theme

* Updated migration version for labels

* Added labels to export/import of members

* Added member labels sanitization for case-insensitive duplicates

* Fixed tests

* Fixed label serialization bug on import

* Bumped @tryghost/members-api to 0.15.0

* Fixed lint

* Cleanup
2020-02-14 15:03:10 +05:30
Naz aff289bfee
Added 'visibility' property check to {{#has}} helper (#11596)
no issue

- Allows for syntax like `{{#has visibility="paid"}}` to be used on Content API resources (posts, pages, etc.)|
- The need for this change cropped out from being able to distinguish paid/member-only/public posts in member-enabled themes.
2020-02-14 17:28:26 +08:00
Rishabh Garg 9c1aa07ea8
Added host limit check for members email publish (#11534)
no issue
2020-02-13 10:43:36 +05:30
Nazar Gargol 25721828d9 Fixed failure when upgrading to version 3.5.x
no issue

- Initialy reported here: https://forum.ghost.org/t/unable-to-upgrade-ghost-from-v3-0-2-to-v3-5-1/11925
- The issue was caused by the refactor in 52635f1aa8 where the backup module signature changed and it wasn't updated in migrations
2020-02-13 12:53:44 +08:00
Rish 4eeed0d32a 🐛 Fixed "undefined" values in member csv export
no issue

We missed handling `undefined` values for fields during csv export for memebrs, which causes csv entries as `undefined` for fields that don't exist. It also added need for extra handling of `undefined` entries during csv import. This PR fixes the bug by properly handling empty/undefined values in export
2020-02-12 11:03:16 +05:30
Nazar Gargol 2c52282662 Added future cleanup note
no issue

- This method was created as a shortcut and the real issue of 'undefined' values being present in CSV should be fiexed instead
2020-02-11 18:17:46 +08:00
Daniel Lockyer d2aee78b01 Version bump to 3.5.2 2020-02-11 09:37:50 +00:00
Daniel Lockyer 1dc0a70bee Updated Ghost-Admin to 3.5.2 2020-02-11 09:37:50 +00:00
Nazar Gargol 51c2b22e9f 🐛 Fixed order for "Complimentary" plan creation
no issue

- When new Ghost instance is initialized "Complimentary" plan doesn't have to wait for the rest of plans to be configured.
- Without configured plans the admin would still be able  to assign "Complimentary" plan to members or import same kind of members.
- There is no error handling at the moment when plan initialization fails, that's why it was very confusing when all of the sudden it wasn't possible to create a member record
2020-02-11 17:14:41 +08:00
Nazar Gargol 5caf924013 Fixed member delete method to use correct options
closes #11589

- `findOne` method in destroy method was usinng wrong options object (unlinke read method id comes from frame.options not frame.data) thus this was causing 404 errors
2020-02-11 16:35:18 +08:00
Nazar Gargol 995788f5a2 Bumped @tryghost/members-api to 0.14.2
d8acfba44a

- The bump is needed to handle plan nickname fallback with an actual value instead of empty string
2020-02-11 14:11:06 +08:00
Renovate Bot d64efff9db Update dependency @sentry/node to v5.12.3 2020-02-10 18:02:47 +00:00
Daniel Lockyer 0eb16264be Configured regression tests to run on main branches
no issue

- run the entire test suite on the master or 2.x branch
2020-02-10 17:06:44 +00:00
Daniel Lockyer 1254ac7ac7 Version bump to 3.5.1 2020-02-10 12:55:55 +00:00
Daniel Lockyer 8f161880cb Updated Ghost-Admin to 3.5.1 2020-02-10 12:55:55 +00:00
Nazar Gargol 7e24b727e1 Added new test case to db regression suite
- Checks for correctly returned 404 when file is not there
- Renames make more sense to correspond to what it actually going on in
the suite
2020-02-10 12:41:39 +00:00
Nazar Gargol 70cf2b2c86 Added input sanitization for backup path
- We need to limit the allowed filename accepted by the method to avoid opening up path traversal attack
2020-02-10 12:41:39 +00:00
Nazar Gargol d5c61c7eea Updated acceptance test to include db export request check 2020-02-10 12:41:39 +00:00
Nazar Gargol 4a79a0e753 Corrected 404 handling 2020-02-10 12:41:39 +00:00
Nazar Gargol 52635f1aa8 Basic implementation of backup retreival from file 2020-02-10 12:41:39 +00:00
Nazar Gargol 49983e799c Changed backup service signature to be able to expand it
- Will need to add a new method allowing to read an export file, so the module signature has to become an object rather than a function
2020-02-10 12:41:39 +00:00
Nazar Gargol afe11c2b06 Added basic backup implementation for users DELETE endpoint
- The filename is returned to be able to fetch the backup on demand
- Wasn't able to limit exported tables as exporter doesn't support such functionality
2020-02-10 12:41:39 +00:00