Refactor character code #33

Merged

vantablack merged 2 commits from lunacb/vantaMOO:refactor_characters into vanta

2023-01-22 06:46:27 +01:00

lunacb commented

2023-01-18 00:07:47 +01:00

Contributor

This PR refactors character code to make it more correct and easier to maintain. It replaces #30.

First, to avoid ambiguity and surprising behavior, it makes the DefaultCharacter class inherit from the ContribRPCharacter class and the ContribRPCharacter class from the ClothedCharacter class. That way character method calls to DefaultCharacter will move to the first parenting contrib class, and that class may further defer the call up to the next parenting class when they're done with it.

Second, all custom-built character code is no longer inherited by the DefaultCharacter class. Instead the code is called directly by methods within it. That way, the control flow and logic of further additions will be easier to follow.

This PR refactors character code to make it more correct and easier to maintain. It replaces #30. First, to avoid ambiguity and surprising behavior, it makes the `DefaultCharacter` class inherit from the `ContribRPCharacter` class and the `ContribRPCharacter` class from the `ClothedCharacter` class. That way character method calls to `DefaultCharacter` will move to the first parenting contrib class, and that class may further defer the call up to the next parenting class when they're done with it. Second, all custom-built character code is no longer inherited by the `DefaultCharacter` class. Instead the code is called directly by methods within it. That way, the control flow and logic of further additions will be easier to follow.

lunacb added 2 commits 2023-01-18 00:07:49 +01:00