Rename to sii_identifier_type party field

aeat.py

@@ -756,7 +756,7 @@ class SIIReportLine(ModelSQL, ModelView):
         return self.invoice.party.vat_code
 
     def get_identifier_type(self, name):
-        return self.invoice.party.identifier_type
+        return self.invoice.party.sii_identifier_type
 
     @staticmethod
     def default_company():

aeat_mapping.py

@@ -33,8 +33,8 @@ class BaseTrytonInvoiceMapper(Model):
     not_exempt_kind = attrgetter('sii_subjected_key')
     counterpart_name = attrgetter('party.name')
     counterpart_nif = attrgetter('party.sii_vat_code')
-    counterpart_id_type = attrgetter('party.identifier_type')
-    counterpart_country = attrgetter('party.vat_country')
+    counterpart_id_type = attrgetter('party.sii_identifier_type')
+    counterpart_country = attrgetter('party.sii_vat_country')
     counterpart_id = counterpart_nif
     tax_rate = attrgetter('tax.rate')
     tax_base = attrgetter('base')

locale/es_ES.po

@@ -206,7 +206,7 @@ msgctxt "field:company.company,private_key:"
 msgid "Private Key"
 msgstr "Clave privada"
 
-msgctxt "field:party.party,identifier_type:"
+msgctxt "field:party.party,sii_identifier_type:"
 msgid "Identifier Type"
 msgstr "Tipos de Identificador"
 

party.py

@@ -11,12 +11,11 @@ class Party:
     __name__ = 'party.party'
     __metaclass__ = PoolMeta
 
-    # TODO: v4 change to party.identifier module
-    identifier_type = fields.Selection(aeat.PARTY_IDENTIFIER_TYPE,
-        'Identifier Type')
-    sii_vat_code = fields.Function(fields.Char('VAT', size=9),
+    sii_identifier_type = fields.Selection(aeat.PARTY_IDENTIFIER_TYPE,
+        'SII Identifier Type')
+    sii_vat_code = fields.Function(fields.Char('SII VAT Code', size=9),
         'get_sii_vat_data')
-    sii_vat_country = fields.Function(fields.Char('VAT', size=2),
+    sii_vat_country = fields.Function(fields.Char('SII VAT Country', size=2),
         'get_sii_vat_data')
 
     def get_sii_vat_data(self, name=None):

view/party_form.xml

@@ -4,8 +4,8 @@ copyright notices and license types. -->
 <data>
     <xpath expr="/form/notebook/page[@name='identifiers']/field[@name='identifiers']"
         position="before">
-        <label name="identifier_type"/>
-        <field name="identifier_type"/>
+        <label name="sii_identifier_type"/>
+        <field name="sii_identifier_type"/>
         <newline/>
     </xpath>
 </data>