Disroot-Ansible
/
pleroma
10
0
Fork 0
Code Pull Requests Projects Releases 1 Activity

Fix icon paths. #17

Merged
muppeth merged 3 commits from fix-icons into main 2024-04-26 18:41:50 +02:00
Conversation 3 Commits 3 Files Changed 3 +12 -27
muppeth commented 2023-12-17 02:44:35 +01:00
Owner
Copy Link

Instead of having /srv/pleroma/static/static I moved icons to /srv/pleroma/static/instance/ I think it makes more sense that way.

Instead of having /srv/pleroma/static/static I moved icons to /srv/pleroma/static/instance/ I think it makes more sense that way.
muppeth added 1 commit 2023-12-17 02:44:35 +01:00
meaz commented 2023-12-20 15:26:40 +01:00
Owner
Copy Link

I'm not sure @muppeth . If you read this https://docs.akkoma.dev/stable/configuration/static_dir/ it says Note the extra static folder for the default logo.png location and If you want to give a brand to your instance, You can change the logo of your instance by uploading it to the static directory $static_dir/static/logo.png
So it seems to be we have to have those 2 static dirs, though it looks weird. But perhaps I get all this wrong...

I'm not sure @muppeth . If you read this https://docs.akkoma.dev/stable/configuration/static_dir/ it says `Note the extra static folder for the default logo.png location` and `If you want to give a brand to your instance, You can change the logo of your instance by uploading it to the static directory $static_dir/static/logo.png` So it seems to be we have to have those 2 static dirs, though it looks weird. But perhaps I get all this wrong...
muppeth commented 2023-12-20 21:41:13 +01:00
Author
Owner
Copy Link

Since we use only mangane (for now at least) and logo path is set to variable, this should just work. I could run it on prod prior merging to make sure it works.

Since we use only mangane (for now at least) and logo path is set to variable, this should just work. I could run it on prod prior merging to make sure it works.
muppeth added 1 commit 2023-12-21 12:06:27 +01:00
muppeth commented 2023-12-21 12:45:07 +01:00
Author
Owner
Copy Link

I changed PWA icon back to pleroma_data_dir

I played it in prod and works fine.

I changed PWA icon back to `pleroma_data_dir` I played it in prod and works fine.
meaz reviewed 2023-12-21 18:08:49 +01:00
tasks/frontends.yml
@ -77,3 +65,3 @@
copy:
src: '{{ pleroma_extra_files_path }}/logo-512.png'
dest: '{{ pleroma_data_dir }}/static/static/logo-512.png'
dest: '{{ pleroma_data_dir }}/static/logo-512.png'
meaz commented 2023-12-21 18:08:49 +01:00
Owner
Copy Link

any reason why this one is not changed to /static/instance like this other?

any reason why this one is not changed to `/static/instance` like this other?
muppeth commented 2023-12-21 18:10:37 +01:00
Author
Owner
Copy Link

As far as I saw in the documentation akkoma checks for the icon in this place. the other one can be specified as to place in mangane config

As far as I saw in the documentation akkoma checks for the icon in this place. the other one can be specified as to place in mangane config
meaz approved these changes 2023-12-21 18:21:46 +01:00
muppeth added 1 commit 2024-03-05 23:19:59 +01:00
meaz approved these changes 2024-03-05 23:22:25 +01:00
muppeth merged commit c6e9ad8601 into main 2024-04-26 18:41:50 +02:00
muppeth deleted branch fix-icons 2024-04-26 18:41:51 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meaz
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-Ansible/pleroma#17
No description provided.
Delete Branch "fix-icons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?