Disroot-themes
/
grav-theme-disrootblog
6
2
Fork 2
Code Pull Requests Releases Activity

fix: change Mastodon link to NixNet #11

Merged
meaz merged 1 commits from :main into main 2024-01-17 09:31:23 +01:00
Conversation 6 Commits 1 Files Changed 1 +1 -1
floss4good commented 2024-01-16 00:31:57 +01:00
Contributor
Copy Link

(same as in grav-theme-disroot)

(same as in grav-theme-disroot)
floss4good added 1 commit 2024-01-16 00:31:58 +01:00
6fed2f3e24 fix: change Mastodon link to NixNet 
(same as in grav-theme-disroot)
floss4good commented 2024-01-16 00:33:41 +01:00
Author
Contributor
Copy Link

I don't know if theme version and changelog should also be updated.

I don't know if theme version and changelog should also be updated.
floss4good commented 2024-01-16 00:44:55 +01:00
Author
Contributor
Copy Link

BTW, is there any reason for which the blog footer looks a little bit different than the other pages footer or is it just because this theme was not updated?

BTW, is there any reason for which the blog footer looks a little bit different than the other pages footer or is it just because this theme was not updated?
meaz commented 2024-01-17 09:30:47 +01:00
Owner
Copy Link

BTW, is there any reason for which the blog footer looks a little bit different than the other pages footer or is it just because this theme was not updated?

What do you mean?

> BTW, is there any reason for which the blog footer looks a little bit different than the other pages footer or is it just because this theme was not updated? What do you mean?
meaz commented 2024-01-17 09:30:58 +01:00
Owner
Copy Link

BTW, is there any reason for which the blog footer looks a little bit different than the other pages footer or is it just because this theme was not updated?

What do you mean?

> BTW, is there any reason for which the blog footer looks a little bit different than the other pages footer or is it just because this theme was not updated? What do you mean?
meaz approved these changes 2024-01-17 09:31:08 +01:00
meaz merged commit 577231a53b into main 2024-01-17 09:31:23 +01:00
floss4good commented 2024-01-17 13:54:48 +01:00
Author
Contributor
Copy Link

What do you mean?

  • On https://disroot.org/en and other pages (using grav-theme-disroot) the footer contains:

    (license icon) Terms Of Service • Privacy Policy • Changelog • Tor Onion (Mastodon icon) (RSS icon)

  • On blog pages (using grav-theme-disrootblog) the footer contains:

    (logo) Copyleft Disroot.org • Terms Of Service • Privacy Policy • Changelog (Mastodon icon) (RSS icon)

  • The links from the blog are missing the language part (e.g. '/tos' instead of '/en/tos'); but that's not necessarily an issues, since a redirect is properly done.

  • The height of the footers is also different (but this might be for the logo).

  • And there are also other CSS related details like texts displayed on 1 or 2 lines or the behavior on smaller screens.

Anyway, I am not saying that they should look the same; I was just asking.

> What do you mean? - On https://disroot.org/en and other pages (using grav-theme-disroot) the footer contains: `(license icon) Terms Of Service • Privacy Policy • Changelog • Tor Onion (Mastodon icon) (RSS icon)` - On blog pages (using grav-theme-disrootblog) the footer contains: `(logo) Copyleft Disroot.org • Terms Of Service • Privacy Policy • Changelog (Mastodon icon) (RSS icon)` - The links from the blog are missing the language part (e.g. '/tos' instead of '/en/tos'); but that's not necessarily an issues, since a redirect is properly done. - The height of the footers is also different (but this might be for the logo). - And there are also other CSS related details like texts displayed on 1 or 2 lines or the behavior on smaller screens. Anyway, I am not saying that they should look the same; I was just asking.
meaz commented 2024-01-18 16:23:42 +01:00
Owner
Copy Link

I see. I created an issue to fix this here Disroot/Disroot-Project#763 thanks!

I see. I created an issue to fix this here https://git.disroot.org/Disroot/Disroot-Project/issues/763 thanks!
Sign in to join this conversation.
Reviewers
No reviewers
meaz
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Disroot-themes/grav-theme-disrootblog#11
No description provided.
Delete Branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?