GitNex/GitNex
GitNex
/
GitNex
mirror of https://codeberg.org/gitnex/GitNex.git
2
5
Fork 0
Code Issues 1 Projects Releases Wiki Activity

Never lowercase strings (#1256) 

Never lowercase translatable strings. This can lead to weird translations otherwise, e.g. in German, you always start nouns with a capital letter. The current implementation turns this into a wrong capitalization.

Co-authored-by: qwerty287 <ndev@web.de>
Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1256
Reviewed-by: M M Arif <mmarif@noreply.codeberg.org>
Co-authored-by: qwerty287 <qwerty287@noreply.codeberg.org>
Co-committed-by: qwerty287 <qwerty287@noreply.codeberg.org>
This commit is contained in:
qwerty287 2023-03-07 06:53:02 +00:00 committed by M M Arif
parent 26fb36c60c
commit 3ec469ff19
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
View File

@ -573,10 +573,10 @@ public class IssueCommentsAdapter extends RecyclerView.Adapter<RecyclerView.View
}
String commitText =
context.getResources().getString(R.string.commits).toLowerCase();
context.getResources().getString(R.string.commitsText);
if (Objects.requireNonNull(commitsShaArray).length() == 1) {
commitText =
context.getResources().getString(R.string.commitText).toLowerCase();
context.getResources().getString(R.string.commitText);
}
String commitString =

1
app/src/main/res/values/strings.xml
View File

@ -802,6 +802,7 @@
<string name="notesAllDeletionMessage">This will delete all of your notes. This action cannot be undone.</string>
<!-- timeline -->
<string name="commitsText">commit</string>
<string name="commitText">commit</string>
<string name="timelineAddedCommit">%1$s added %2$s %3$s</string>
<!-- the | is replaced by the label -->