mirror of https://github.com/pypa/pip
Merge pull request #9156 from jdufresne/resource-warning
Always close stderr after subprocess completion in call_subprocess()
This commit is contained in:
commit
a19f1303fb
|
@ -0,0 +1 @@
|
||||||
|
Fix ResourceWarning in VCS subprocesses
|
|
@ -150,6 +150,8 @@ def call_subprocess(
|
||||||
finally:
|
finally:
|
||||||
if proc.stdout:
|
if proc.stdout:
|
||||||
proc.stdout.close()
|
proc.stdout.close()
|
||||||
|
if proc.stderr:
|
||||||
|
proc.stderr.close()
|
||||||
|
|
||||||
proc_had_error = (
|
proc_had_error = (
|
||||||
proc.returncode and proc.returncode not in extra_ok_returncodes
|
proc.returncode and proc.returncode not in extra_ok_returncodes
|
||||||
|
|
Loading…
Reference in New Issue