mirror of https://github.com/pypa/pip
Merge pull request #9408 from jdufresne/setup-no-remote
Handle ._get_svn_url_rev() returning None in .get_remote_url()
This commit is contained in:
commit
a61cb200b5
|
@ -128,7 +128,11 @@ class Subversion(VersionControl):
|
||||||
)
|
)
|
||||||
raise RemoteNotFoundError
|
raise RemoteNotFoundError
|
||||||
|
|
||||||
return cls._get_svn_url_rev(location)[0]
|
url, _rev = cls._get_svn_url_rev(location)
|
||||||
|
if url is None:
|
||||||
|
raise RemoteNotFoundError
|
||||||
|
|
||||||
|
return url
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
def _get_svn_url_rev(cls, location):
|
def _get_svn_url_rev(cls, location):
|
||||||
|
|
|
@ -15,3 +15,17 @@ def test_get_remote_url__no_remote(script, tmpdir):
|
||||||
|
|
||||||
with pytest.raises(RemoteNotFoundError):
|
with pytest.raises(RemoteNotFoundError):
|
||||||
Subversion().get_remote_url(repo_dir)
|
Subversion().get_remote_url(repo_dir)
|
||||||
|
|
||||||
|
|
||||||
|
@need_svn
|
||||||
|
def test_get_remote_url__no_remote_with_setup(script, tmpdir):
|
||||||
|
repo_dir = tmpdir / 'temp-repo'
|
||||||
|
repo_dir.mkdir()
|
||||||
|
setup = repo_dir / "setup.py"
|
||||||
|
setup.touch()
|
||||||
|
repo_dir = str(repo_dir)
|
||||||
|
|
||||||
|
_create_svn_repo(script, repo_dir)
|
||||||
|
|
||||||
|
with pytest.raises(RemoteNotFoundError):
|
||||||
|
Subversion().get_remote_url(repo_dir)
|
||||||
|
|
Loading…
Reference in New Issue