McSinyx
/
pip
mirror of https://github.com/pypa/pip
1
1
Fork 0
Code Issues Releases Activity

Apply suggestions from code review

This commit is contained in:
chrysle 2023-08-14 20:00:50 +02:00
parent f12b8db25f
commit d9b5a9df85
No known key found for this signature in database
GPG Key ID: DC9728CE07739190
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/pip/_internal/configuration.py
View File

@ -148,8 +148,7 @@ class Configuration:
clean_config = {} clean_config = {}
for k, value in self._dictionary.items(): for k, value in self._dictionary.items():
if isinstance(value, dict): if isinstance(value, dict):
for k, v in value.items(): clean_config.update(value)
clean_config[k] = v
else: else:
clean_config[k] = value clean_config[k] = value
return clean_config[key] return clean_config[key]
@ -175,10 +174,7 @@ class Configuration:
parser.add_section(section) parser.add_section(section)
parser.set(section, name, value) parser.set(section, name, value)
exists = self._config[self.load_only].get(fname) self._config[self.load_only].setdefault(fname, {})
if not exists:
self._config[self.load_only][fname] = {}
self._config[self.load_only][fname][key] = value self._config[self.load_only][fname][key] = value
self._mark_as_modified(fname, parser) self._mark_as_modified(fname, parser)
@ -286,9 +282,7 @@ class Configuration:
for section in parser.sections(): for section in parser.sections():
items = parser.items(section) items = parser.items(section)
exists = self._config[variant].get(fname) self._config[variant].setdefault(fname, {})
if not exists:
self._config[variant][fname] = {}
self._config[variant][fname].update(self._normalized_keys(section, items)) self._config[variant][fname].update(self._normalized_keys(section, items))
return parser return parser