Commit graph

9844 commits

Author SHA1 Message Date
wwp
77e2223bbb Remove dead code, fixing Coverity CID #1398568. 2017-01-12 10:06:22 +01:00
wwp
91300009f4 Rework logics, remove dead code. Solves Coverity CID #1220297. 2017-01-11 23:19:22 +01:00
wwp
dad5b3e32a Kill dead code, fixing Coverity CID #1220511. 2017-01-11 22:41:28 +01:00
wwp
8ae6e56758 Remove accidentally added xpm file. 2017-01-11 16:38:31 +01:00
wwp
34fd77ccef Add deallocation call. 2017-01-11 16:35:05 +01:00
wwp
de7bb00b0c Quit function if no connection instead of assigning variable that
will be overwriten right after.
Fixes Coverity CID #1372370.
2017-01-11 16:09:08 +01:00
wwp
f986aa1d86 Rework icon antialiasing to look OK on dark and light themes. 2017-01-11 11:03:56 +01:00
wwp
2b41515a33 POPPLER_ACTION_MOVIE was not introduced w/ Poppler 0.14.0, but in
a version so old that even my grandma was using it (0.3.0 in fact).
2017-01-11 01:56:22 +01:00
wwp
34fb7f005f Rework icon antialiasing to look OK on dark and light themes. 2017-01-11 01:31:05 +01:00
wwp
b15774d193 Don't #undefine UNIX_PATH_MAX, move #define's up. 2017-01-10 16:19:29 +01:00
wwp
72625ef0e7 Be more clear about what 108 means here towards the Unix socket
path value lenght: rely on UNIX_PATH_MAX and fallback to its common
value '108' in not defined in un.h (caution, on other systems, it could
be 104, etc. down to 92).
2017-01-10 15:58:05 +01:00
wwp
32955775f6 Fail if attempting to create a UNIX socket w/ path len >108c.
Add few checks more for socket operations, and reduce few duplicate
initializations.
Saves us warnings and sikves Civerity #1372360.
2017-01-10 14:51:09 +01:00
wwp
619164ab29 Fix Coverity CIDs: 1220259 1364687 (and discarded 1220496) and added more checks for returned
values.
2017-01-10 10:10:05 +01:00
wwp
16b5db8d3a Fix Coverity CIDs: 1220274 and 1220377. 2017-01-10 09:59:52 +01:00
wwp
37b65a4db7 Real fix for Coverity 1372362. 2017-01-10 09:36:31 +01:00
wwp
0b238a22d6 Don't behave as if avail_d was not hardcoded, it is hardcoded
to 7, and do it properly.
Saves us a warning and solves Coverity #1372366.
2017-01-10 09:31:34 +01:00
wwp
e3cd98f9f3 Better fix for Coverity #1220388, use effective indexes and boundaries. 2017-01-10 09:26:08 +01:00
Paul
d18fa86729 fix typo 2017-01-09 11:37:25 +00:00
wwp
87b362fc33 Fixes Coverity CIDs: 1220388 1372362 1220222 1358399 1223756 1223757 1220305 1220269 1220243 1396991. 2017-01-09 11:37:18 +01:00
Ricardo Mones
be36f031fa Attachwarner: fix leaked string 2017-01-09 00:37:04 +01:00
wwp
a7a4f21742 Fix a leak. 2017-01-07 00:46:20 +01:00
wwp
d6deeaa61c Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws 2017-01-05 18:39:21 +01:00
wwp
be32eb07b7 Rework antialiasing a bit around toolbar and logo icons, in order
to better fit dark background themes (but still be fine w/ light ones).
2017-01-05 18:36:43 +01:00
wwp
cdbf2c37c3 Revert parts of 3.14.1-91 (the summary_select_node_no_mard_read func), obviously it's
been accidentally included in that commit and the origin of this modification is still
undetermined.
2017-01-05 10:56:46 +01:00
wwp
471d243cf7 Fix wrong function definition, declare it before using it, and make it
static.
2017-01-05 10:21:50 +01:00
wwp
9a20d31a23 Fix wrong libarchive version check. 2017-01-04 17:16:09 +01:00
wwp
3a66d2e101 Make the FOO vanish. 2017-01-04 11:32:19 +01:00
wwp
c7af8ad4b2 Fix marking all as (un)read recursively when the confirmation
dialogue is enabled and the user clicks No: confirmation dialog
was taken into account just for the current folder, subtree was
marked anyway, and this only under certain conditions that I'd
prefer not to list here becau<woosh>
2017-01-04 11:14:15 +01:00
wwp
d287120c94 Rename a misnamed function, remove debug statements. 2017-01-04 09:13:05 +01:00
wwp
8cc21bf46a Fix missing array initializers and line everything up. 2017-01-03 23:36:33 +01:00
wwp
2b85c3daaa Fix missing array initializers and line everything up. 2017-01-03 23:12:02 +01:00
wwp
eaa8a3ebd8 Really align array (using whitespaces). 2017-01-03 22:31:13 +01:00
wwp
91c5187539 Cosmetic changes: align arrays, remove debug statements. 2017-01-03 22:20:59 +01:00
wwp
cdb10d81eb Archiver plugin update and review:
- updated to support some of the compression formats up to libarchive 3.2.2,
- detect libarchive 2.8+ using pkgconfig,
- use alertpanel API instead of creating gtk dialogs from scratch (with missing
- dialog title, and no clue about what is displayed),
- configure script now makes use of libarchive pkgconfig,
- fixed wrong use of cached page struct info, we do now rely on data set in widgets
  to get source folder and target archive filename and sync the page struct info w/ it
  when needed,
- renamed gzip/zip to gzip,
- reworked the way archive formats and compression formats lists are displayed (not translatable anymore).
- reformat code a bit.
2017-01-03 19:14:10 +01:00
Holger Berndt
abf4b98214 GData plugin: Require libgdata at least 0.17.2
Version 0.17.2 is required for auth token save/restore accross restarts.
Without this functionality, the plugin has such bad usability, it's not
worth maintaining. This also fixes the previous compile-error when only
0.17.1 was present.
2017-01-03 11:20:11 +01:00
wwp
a0fbaacf17 Fix 'search folder' not working in some cases (it needs a 'clear' click to
work or to manually clear search fields).
Fix provided by Paul, the be(a)st.
2016-12-29 13:42:46 +01:00
Paul
38af4d7654 make Go to/[Next|Prev] sort order aware 2016-12-28 12:55:04 +00:00
wwp
b2b913e310 Fix compiler warnings when we test enum-based variables for impossible
<0 values.
2016-12-27 18:06:11 +01:00
wwp
f69f1588a9 Factorize toolbar reset code, and don't compute array sizes using
unsafe calculations.
2016-12-27 18:04:42 +01:00
wwp
30a1c0875f Fix enum boundaries we check in func_selection_changed (when
changing the internal function assigned to a toolbar item).
Just a theoretical issue here apparently, or we would have had
problems since ages.
2016-12-27 18:02:55 +01:00
wwp
878b6d7a20 More places where printf() and C_() have to be separated. 2016-12-27 17:58:47 +01:00
wwp
0372b283a8 Line-up arrays (w/ space chars only).
Fix missing array initializers.
2016-12-27 16:02:27 +01:00
wwp
66d2176e8b Silent up a compiler warning by making the ComposeCallAdvancedAction
enum a real integer-scope ([-1 .. n] instead of [0 .. n]), swallowing
the -1 value check.
2016-12-27 15:20:53 +01:00
wwp
aed88afd64 Update French translation. 2016-12-27 15:15:03 +01:00
wwp
571de7f509 Revert "Revert "Revert g9737584."" (but the fix) by reimplementing
the thing differently: don't mix printf() and C_() as it messes the
compiler up.
Factorize a bit format errors in compose.c.
Make some header names translatable following prefs in the
address keeper plugin.
2016-12-27 15:11:00 +01:00
wwp
6b68aee40d Fix a leak. 2016-12-27 13:12:22 +01:00
Ricardo Mones
ec9e88d3df Revert "Revert g9737584." and fix it ;)
This reverts commit 834ee304 which was reverting a previous
commit which broke build because of an extra comma. This
reverts the revert and removes the comma.
2016-12-27 13:08:00 +01:00
wwp
834ee30437 Revert g9737584. 2016-12-27 12:57:37 +01:00
wwp
9737584876 Add translation context helper text where some %s' are used and
their meaning is not obvious.
2016-12-27 12:16:56 +01:00
Paul
f5ea218791 removed all useless comments from the end of the po files 2016-12-23 11:20:30 +00:00