Christopher Baines
f68822cad2
Include some useful numbers on the package derivations comparison
...
As it's frequently useful to know how many packages/builds some change has
affected.
2023-02-15 15:48:45 +00:00
Christopher Baines
9fc5821180
Include more information about invalid query parameters
...
In the /compare response.
This should enable qa.guix.gnu.org to detect when the base revision for a
comparison is unknown.
2022-11-17 16:18:28 +00:00
Christopher Baines
1043b51bff
Include lint warnings in the JSON /compare response
2022-08-22 17:42:37 +01:00
Christopher Baines
752d21ad05
Improve the way the field fields work on various pages
...
Remove the brackets from the values since this makes the set of values more
consistent, and don't display the no additional fields value on the page.
2022-01-31 20:25:06 +00:00
Luciana Lima Brito
767e60b2b3
Change data handling when comparing derivations
...
comparison.scm: return query data for derivation comparison as an alist,
instead of list.
html.scm: Access derivation differences data using assq-ref.
controller.scm: remove mapping for outputs/inputs/sources.
utils.scm: add group-to-alist/vector function.
Signed-off-by: Christopher Baines <mail@cbaines.net>
2021-04-27 21:18:51 +01:00
Canan Talayhan
fe97021cd0
Set more informative page titles
...
For many pages where previously the title was just "Guix Data Service".
Signed-off-by: Christopher Baines <mail@cbaines.net>
2021-04-23 12:00:03 +01:00
Christopher Baines
6387f1bc67
Fetch the list of system values from the database
...
This removes the need to hardcode some values in the code.
2021-04-23 11:20:36 +01:00
Luciana Brito
a498433643
Implement basic JSON output for the derivation comparison page
...
Signed-off-by: Christopher Baines <mail@cbaines.net>
2021-04-19 20:53:46 +01:00
Christopher Baines
39f52e3a2e
Update parse-commit for the guix-revision changes
2021-02-04 10:28:04 +00:00
Christopher Baines
6195d7b18f
Remove store_path from select-guix-revision-for-branch-and-datetime
...
As I want to remove the field from the database.
2021-02-02 19:49:09 +00:00
Christopher Baines
a88e9db1ff
Fix issue with the system test comparison page
2021-01-14 20:44:41 +00:00
Christopher Baines
1050070067
Implement compare by datetime for system test derivations
...
Also fix some general issues with the rendering.
2021-01-04 22:59:28 +00:00
Christopher Baines
6f89066355
Support comparing revision system test derivations
...
This should come in useful for testing patches, as you can see what system
tests are affected, and check the build status.
2021-01-04 19:15:01 +00:00
Christopher Baines
c12959330b
Include the revision details for package dervation comparisons
...
I'm wanting the commits for tagging builds.
2020-12-20 19:37:36 +00:00
Leo Famulari
0813ad6978
Tell the user how to specify a datetime.
...
Also correct a mistake in the error message for invalid datetime formats.
2020-12-19 17:47:53 -05:00
Christopher Baines
de3ca9d074
Improve the parse-commit invalid parameter handling
2020-11-28 19:36:47 +00:00
Christopher Baines
8f702e5666
Add system and target controls to the package derivation comparison
...
By datetime, as these parameters are supported.
2020-11-25 21:05:32 +00:00
Christopher Baines
56c786e309
Fix typo with build_change parameter
...
For the compare by datetime package derivations page.
2020-11-21 21:23:39 +00:00
Christopher Baines
e93da1ae8f
Fix the JSON link on the compare package derivations page
2020-11-21 21:10:33 +00:00
Christopher Baines
7e1cba3309
Consolidate the package derivation comparison code
2020-11-21 21:00:40 +00:00
Christopher Baines
0c3e208a83
Start merging the package derivation comparison code
2020-11-21 20:29:14 +00:00
Christopher Baines
56983eb03e
Extract out the compare form controls
...
So they can be used for the package derivations page
2020-11-21 20:25:26 +00:00
Christopher Baines
814a5d7cba
Fix some links on the compare page
2020-11-21 20:11:21 +00:00
Christopher Baines
12f35c493b
Add default datetimes for compare-by-datetime
...
As this makes it easy to compare the current state of two branches.
2020-11-21 20:11:21 +00:00
Christopher Baines
7321ce4408
Improve the comparison page interface
...
Try to unify the code for the different comparison modes, so that there's less
of it.
2020-11-21 18:37:19 +00:00
Christopher Baines
c751031a26
Avoid crashing when no compare arguments are provided
2020-11-21 16:49:58 +00:00
Christopher Baines
00c84640c5
Improve the headings on the compare derivations page
2020-11-20 19:37:12 +00:00
Christopher Baines
65507aaac1
Don't show all results on the compare package derivation page
...
By default. For comparisons involving lots of changed derivations, the page
can take too long to render.
2020-11-20 19:33:16 +00:00
Christopher Baines
d98c676563
Fix typo
2020-11-19 21:46:47 +00:00
Christopher Baines
ce73e4448d
Include a "Build change" filter on the package derivations page
...
This helps determine what things a change broke or fixed for example.
2020-11-19 21:02:47 +00:00
Christopher Baines
80c6fbd1ac
Clean up some unused code in the compare controller
2020-11-19 20:59:02 +00:00
Christopher Baines
1431f712a6
Fix compare by datetime URL
...
Use package-derivations rather than derivations, as this is more accurate.
2020-11-19 20:58:38 +00:00
Christopher Baines
e394d1d6ad
Show build information when comparing package derivations
...
As this is useful to see, as it can indicate that a change to the derivation
has led to the builds to start failing/succeeding.
2020-10-31 15:55:11 +00:00
Christopher Baines
1573fe566b
Remove a few peek calls that snuck in
2020-10-31 15:54:34 +00:00
Christopher Baines
c05cbd8438
Rename some derivation comparison procedures
...
As they actually just relate to package derivations.
2020-10-31 13:52:08 +00:00
Christopher Baines
6c47212c4d
Improve the failed comparison page
2020-10-23 16:23:16 +01:00
Christopher Baines
faa32234d8
Fix compare package derivations JSON link
2020-10-23 12:47:43 +01:00
Christopher Baines
2fa9f151f6
Include the base commit and target commit in the compare output
...
This makes it easier to make other requests with the response body.
2020-10-09 19:35:38 +01:00
Christopher Baines
6023aa8caf
Improve select-job-for-commit
...
It now returns #f or a list, rather than the empty list or a nested list.
2020-10-09 19:31:51 +01:00
Christopher Baines
51204aefca
Clarify that the derivations comparison only is for packages
...
As it excludes the channel instances and system tests.
2020-10-09 19:31:21 +01:00
Christopher Baines
853aaa6a7c
Use letpar& for systems and targets in render-compare/derivations
2020-10-09 19:30:48 +01:00
Christopher Baines
8daf35e2df
Change the derivation comparison targets
...
To be targets, rather than systems.
2020-10-09 19:29:58 +01:00
Christopher Baines
1f55718d75
Link to the revisions in the comparison header
2020-10-09 19:29:38 +01:00
Christopher Baines
c3c9c07f9a
Completely rework the way db connections are handled during requests
...
Previously, a connection was passed through the code handling the
request. When queries were performed, this could block the thread though,
potentially leaving the server unable to serve other requests.
Instead, this now runs queries in a pool of threads. This should remove the
possibility of blocking the threads used by the web server, and in doing so,
some of the queries have been parallelised.
I''m still not sure about the naming and syntax, but I think the functionality
is a sort of step forward.
2020-10-03 21:35:31 +01:00
Christopher Baines
53341c70fc
Change the locale codeset representation
...
From the normalized one, to the one actually contained within glibc. Recent
versions of glibc also contain symlinks linking the normalized codeset to the
locales with the .UTF-8 ending, but older ones do not.
Maybe handling codeset normalisation for queries would be good, but the locale
values ending in .UTF-8 are more compatible and allow the code to be
simplified. For querying, maybe there should be a locales table which handles
different representations.
2020-09-26 11:45:57 +01:00
Danjela Lura
d3096de655
Use lint checker related translations on some pages
...
Signed-off-by: Christopher Baines <mail@cbaines.net>
2020-06-07 20:17:03 +01:00
Christopher Baines
374dc25440
Improve system and target query parameter handling
2020-02-13 23:11:59 +00:00
Christopher Baines
704f149645
Improve the compare-invalid-parameters messages
2020-01-18 10:18:17 +00:00
Christopher Baines
75665e3203
Fix a few list styling issues
2020-01-02 21:18:42 +00:00
Christopher Baines
83c86431ae
Better split up the comparision functionality
...
The packages comparison was getting confused by differences in the
derivations, so split the data used to make the comparison more sensible.
This resolves an issue comparing 8dd723f5… and 365892e9… which coinsided with
the fix for importing foreign architecture derivations, meaning that a whole
lot of new derivations appeared in the database. Prior to these changes, it
appeared like every package was new, and with these changes, the list is more
sensible.
2020-01-02 20:41:24 +00:00