Restrict this port to Python 2.7 for now, work to get it running
with Python 3.6 is in progress upstream.
Pet portlint (remove an extraneous spacae from pkg-descr)
Reported by: upstream / portscout
It fails to build with PostgreSQL 11:
pgut/pgut.c:389:47: error: too few arguments to function call, expected 4, have 3
return simple_prompt("Password: ", 100, false);
~~~~~~~~~~~~~ ^
/usr/local/include/postgresql/server/port.h:193:1: note: 'simple_prompt' declared here
extern void simple_prompt(const char *prompt, char *destination, size_t destlen,
^
1 error generated.
http://package18.nyi.freebsd.org/data/120amd64-default-PR239514/2019-07-29_20h41m52s/logs/pg_reorg-1.1.11_2.log
And after fixing that one:
reorg.c:230:55: warning: incompatible pointer types passing 'bool [1]' to parameter of type 'const char *' [-Wincompatible-pointer-types]
execute_plan(SPI_OK_SELECT, plan_peek, values_peek, nulls_peek);
^~~~~~~~~~
./pgut/pgut-spi.h:28:84: note: passing argument to parameter 'nulls' here
extern void execute_plan(int expected, SPIPlanPtr plan, Datum *values, const char *nulls);
^
reorg.c:256:58: warning: incompatible pointer types passing 'bool *' to parameter of type 'const char *' [-Wincompatible-pointer-types]
execute_plan(SPI_OK_INSERT, plan_insert, &values[2], &nulls[2]);
^~~~~~~~~
[...]
reorg.c:573:34: error: use of undeclared identifier 'BTREE_AM_OID'
opclass = OpclassnameGetOpcid(BTREE_AM_OID, opcname);
^
reorg.c:590:57: error: member reference type 'FormData_pg_attribute' (aka 'struct FormData_pg_attribute') is not a pointer; did you mean to use '.'?
opcintype = RelationGetDescr(indexRel)->attrs[nattr]->atttypid;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
etc.
PR: 239514
This fixes the build with newer PostgreSQL versions.
Drop the IDXPATCH option. The patch no longer applies. Unfortunately
it was never upstreamed, its purpose is not clear, and the port no
longer has a maintainer to ask about this.
Changes: https://github.com/RhodiumToad/ip4r/blob/2.4.1/README.ip4r
PR: 239514
table_log.c:76:29: error: member reference type 'FormData_pg_attribute' (aka 'struct FormData_pg_attribute') is not a pointer; did you mean to use '.'?
if (!tupleDesc->attrs[i]->attisdropped) {
~~~~~~~~~~~~~~~~~~~^~
.
table_log.c:303:59: error: member reference type 'FormData_pg_attribute' (aka 'struct FormData_pg_attribute') is not a pointer; did you mean to use '.'?
if (trigdata->tg_relation->rd_att->attrs[col_nr - 1]->attisdropped) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
.
table_log.c:348:59: error: member reference type 'FormData_pg_attribute' (aka 'struct FormData_pg_attribute') is not a pointer; did you mean to use '.'?
if (trigdata->tg_relation->rd_att->attrs[col_nr - 1]->attisdropped) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
.
table_log.c:375:59: error: member reference type 'FormData_pg_attribute' (aka 'struct FormData_pg_attribute') is not a pointer; did you mean to use '.'?
if (trigdata->tg_relation->rd_att->attrs[col_nr - 1]->attisdropped) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
.
4 errors generated.
http://package18.nyi.freebsd.org/data/120amd64-default-PR239514/2019-07-29_20h41m52s/logs/tablelog-0.4.4_3.log
While here
- Mark it as deprecated. The last release was in 2007 and upstream
has been inactive since then.
- Fix WWW
PR: 239514
Reported by: antoine (via exp-run)
- Broken with libc++ 6 and there's not enough time before the next bulk build.
- PORTEPOCH isn't necessary as if built it's good, and the update will return
rpcs3/util/atomic.cpp:55:51: error: no type named 'node_type' in 'std::__1::multimap<const void *, (anonymous namespace)::waiter, std::__1::less<const void *>, std::__1::allocator<std::__1::pair<const void *const, (anonymous namespace)::waiter> > >'; did you mean 'size_type'?
thread_local std::multimap<const void*, waiter>::node_type s_tls_waiter = []()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
size_type
/usr/include/c++/v1/map:1507:60: note: 'size_type' declared here
typedef typename __alloc_traits::size_type size_type;
^
rpcs3/util/atomic.cpp:59:16: error: no member named 'extract' in 'std::__1::multimap<const void *, (anonymous namespace)::waiter, std::__1::less<const void *>, std::__1::allocator<std::__1::pair<const void *const, (anonymous namespace)::waiter> > >'
return dummy.extract(dummy.emplace(nullptr, &s_tls_waiter));
~~~~~ ^
rpcs3/util/atomic.cpp:55:61: error: cannot initialize a variable of type 'std::multimap<const void *, waiter>::size_type' (aka 'unsigned long') with an rvalue of type 'void'
thread_local std::multimap<const void*, waiter>::node_type s_tls_waiter = []()
^ ~~~~
rpcs3/util/atomic.cpp:92:69: error: no type named 'node_type' in 'std::__1::multimap<const void *, (anonymous namespace)::waiter, std::__1::less<const void *>, std::__1::allocator<std::__1::pair<const void *const, (anonymous namespace)::waiter> > >'; did you mean 'size_type'?
const auto ptls = static_cast<std::multimap<const void*, waiter>::node_type*>(found->second.tls_ptr);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
size_type
/usr/include/c++/v1/map:1507:60: note: 'size_type' declared here
typedef typename __alloc_traits::size_type size_type;
^
rpcs3/util/atomic.cpp:93:21: error: no member named 'extract' in 'std::__1::multimap<const void *, (anonymous namespace)::waiter, std::__1::less<const void *>, std::__1::allocator<std::__1::pair<const void *const, (anonymous namespace)::waiter> > >'
*ptls = wmap.list.extract(found);
~~~~~~~~~ ^
rpcs3/util/atomic.cpp:94:7: error: member reference base type 'unsigned long' is not a structure or union
ptls->mapped().cond.notify_one();
~~~~^ ~~~~~~
6 errors generated.
GCC8 is already used for fortran so set USES=compiler:c11 to use GCC8 for everything.
PR: 239438
Approved by: mentors (implicit approval), yuri (mentor)
