Commit graph

5646 commits

Author SHA1 Message Date
Michael Kirk 1c69cd3dc5 Merge branch 'mkirk/missing-messages' 2018-02-15 06:24:09 -08:00
Michael Kirk da15f245cf CR: fix early return, assert on error
inline functions which were only used once

// FREEBIE
2018-02-15 06:23:47 -08:00
Michael Kirk b4359b33dd Fix "lose messages received while in background"
A moved legacy DB has the NSFileProtectionClassComplete, meaning it's
never accessible while the device is locked.

// FREEBIE
2018-02-15 06:23:47 -08:00
Matthew Chen 4262a83e00 "Bump build to 2.20.0.21." 2018-02-14 18:46:45 -05:00
Matthew Chen c1a78d1f1e Merge branch 'charlesmchen/saeShutdown' 2018-02-14 18:46:35 -05:00
Matthew Chen d13511ca7d Exit SAE when complete. 2018-02-14 18:46:22 -05:00
Matthew Chen d374e6ab86 "Bump build to 2.20.0.20." 2018-02-14 18:07:56 -05:00
Michael Kirk 7ff99fe76c Merge branch 'mkirk/fixup-readiness-dispatch' 2018-02-14 14:17:00 -08:00
Michael Kirk 5c432a2bc1 Fix crash on launch in debug.
OWSReadReceiptManager is not `init` on the main thread; however, because
it "schedules" it's own processing during init.

I considered dispatching to main, but since AppReadiness already *can*
resolve async if the app isn't yet ready, it should be no less safe to
also dispatch async when it's off the main thread.

// FREEBIE
2018-02-14 13:47:45 -08:00
Matthew Chen 0522f33a86 "Bump build to 2.20.0.19." 2018-02-14 16:07:46 -05:00
Matthew Chen f8b7c08be8 Merge branch 'charlesmchen/batchProcessingGlitch' 2018-02-14 16:07:35 -05:00
Matthew Chen b7958262ba Respond to CR. 2018-02-14 16:06:47 -05:00
Matthew Chen 8930110efd Fix glitch in batch processing of incoming messages. 2018-02-14 14:56:47 -05:00
Matthew Chen 6f28c75257 Fix glitch in batch processing of incoming messages. 2018-02-14 14:56:47 -05:00
Matthew Chen e48542e1db Merge branch 'charlesmchen/iOS8Nag' 2018-02-14 14:17:39 -05:00
Matthew Chen 9508761f09 Respond to CR. 2018-02-14 14:17:30 -05:00
Matthew Chen 4b62faf2f8 Aggressively nag iOS 8 users to upgrade iOS. 2018-02-14 14:15:23 -05:00
Matthew Chen 132bf81c08 Update l10n strings. 2018-02-14 14:07:59 -05:00
Matthew Chen 09665973a0 "Bump build to 2.20.0.18." 2018-02-14 12:21:41 -05:00
Michael Kirk 508bc72e68 Merge branch 'mkirk/logging-fixups' 2018-02-14 09:17:33 -08:00
Michael Kirk 3d5f7e6bf3 Clean up logging
- tag all log lines for easier filtering
- use up-to-date database path

// FREEBIE
2018-02-14 09:16:42 -08:00
Michael Kirk 929233c9e1 Merge branch 'mkirk/media-detail-tap-shift' 2018-02-14 09:05:14 -08:00
Michael Kirk c6e5d4369b Don't adjust inset when fully zoomed in.
On iOS11, when looking at the full-screen media details, if you'd zoomed
far enough that the media content is behind the status bar, tapping to
hide the status bar would cause an undesirable change in content offset.

// FREEBIE
2018-02-14 09:05:05 -08:00
Michael Kirk e0294b238f Merge branch 'mkirk/fix-redundant-transcript-caption' 2018-02-14 09:04:04 -08:00
Michael Kirk 4d0362f9a6 Don't create redundant caption for sync'd transcripts.
Note: For test devices running HEAD, there may have already been some
redundant captions created for sync'd transcripts.

However the existing `TSMessage#initWithCoder:` migration will address
this for our production users, so I'm not going to bother with a second
migration just for our test devices.

// FREEBIE
2018-02-14 09:03:55 -08:00
Michael Kirk 337f4a1416 Merge branch 'mkirk/fix-details-bubble-layout' 2018-02-14 09:00:58 -08:00
Michael Kirk 19eb17b469 Fix bubble layout in message details
TextView size depends on the VC.view size, so it must be updated when
view is done laying out.

// FREEBIE
2018-02-14 09:00:46 -08:00
Matthew Chen 6c357e8228 "Bump build to 2.20.0.17." 2018-02-14 11:03:32 -05:00
Matthew Chen 042f32bd28 Merge branch 'charlesmchen/messageSenderDeadlocks' 2018-02-14 10:38:20 -05:00
Matthew Chen 81522e4a23 Respond to CR. 2018-02-14 10:38:08 -05:00
Matthew Chen 888bf9256f Avoid deadlocks in message sender. 2018-02-14 10:38:08 -05:00
Matthew Chen 01496b2db8 Avoid deadlocks in message sender. 2018-02-14 10:38:08 -05:00
Matthew Chen a19882baaa Avoid deadlocks in message sender. 2018-02-14 10:38:08 -05:00
Michael Kirk d5e61dac9f Merge branch 'collinstuart/constant-time-compare' 2018-02-13 16:18:11 -08:00
Collin B. Stuart cc94573e9b Constant time compare
- fix case when second part of the && conditional is skipped when data is not equal

- isEqual variable marked volatile to prevent case when it doesn't equal 0, the loop can break early since it can never be 0 again

- tested with Fastest O3 and Whole Module optimization (App Store Release)

// FREEBIE
2018-02-13 16:18:06 -08:00
Michael Kirk b358a75e3e Merge branch 'mkirk/crash-on-first-message' 2018-02-13 15:55:10 -08:00
Michael Kirk ea12ed4c23 Fix dynamic type check which was too restrictive
// FREEBIE
2018-02-13 15:54:23 -08:00
Matthew Chen f131c71d90 Merge branch 'charlesmchen/messageDateTimes' 2018-02-13 15:03:54 -05:00
Matthew Chen 0944c2661e Respond to CR. 2018-02-13 15:03:43 -05:00
Matthew Chen 48b6c3dafb Refine message date/time formatting. 2018-02-13 15:02:29 -05:00
Michael Kirk 2d7a10ac0e [Pods] remove userdata
// FREEBIE
2018-02-13 10:40:45 -08:00
Matthew Chen 286c0133d4 Update Cocoapods. 2018-02-13 13:36:22 -05:00
Matthew Chen 3e14e9602c update l10n strings. 2018-02-13 13:30:18 -05:00
Michael Kirk 3246bcf627 [Pods] remove userdata dir from Pods.xcodeproj
// FREEBIE
2018-02-13 09:52:46 -08:00
Michael Kirk b999cd9e6e Merge branch 'mkirk/crash-on-search' 2018-02-13 09:50:08 -08:00
Michael Kirk ae2ddb25cc CR: add assert
// FREEBIE
2018-02-13 09:50:01 -08:00
Michael Kirk d6b3e191d1 Fix crash while searching when group somehow has nil members
This shouldn't normally happen, but seeing it on my device.

// FREEBIE
2018-02-13 09:50:01 -08:00
Michael Kirk a23f1b86ef nullability annotations for TSGroupModel
- add readonly where possible
- group members needn't be a mutable array

// FREEBIE
2018-02-13 09:50:01 -08:00
Michael Kirk 945c7cd1f9 Merge branch 'mkirk/fix-notification-percents' 2018-02-13 08:30:09 -08:00
Michael Kirk cb8767d19e CR: duplicate comments, DRY
// FREEBIE
2018-02-13 08:29:58 -08:00