Commit graph

19 commits

Author SHA1 Message Date
Michael Kirk 21fd7b040e Ensure sent video is mp4
// FREEBIE
2017-12-11 14:03:40 -05:00
Michael Kirk d3e7c99a63 Attachment approval: cancel/confirm to top/bottom toolbars
- avoid double-submit by disabling after hitting send.
- Animate SAE dismissal as modal
  Requires hiding the load view
- attachment is centered in screen
- add gradient to ensure controls are visible
- Fix clamp constraints - I think this was a typo
  Otherwise we couldn't show an image which was 1" wide by 2" tall
- set max zoom, hide scroll indicators
- use media view
- slower panning feels right
- white send button
- can share GIF, static, and sort of video...
- Play button for attachment approval
  - move to image assets so we can use it in SAE
  - slightly larger button for full-screen approval view
  - don't launch redundant fullscreen UI for images when in approval view
- fix scrollOffset in AttachmentApproval
- consolidate view initialization logic in loadView and fix white background
- CR: more legible arithmetic

// FREEBIE
2017-12-11 13:58:03 -05:00
Matthew Chen bf09c805b9 Respond to CR. 2017-12-11 11:27:53 -05:00
Matthew Chen c918279597 Convert image attachment thresholds to be based on file size. 2017-12-11 10:37:20 -05:00
Matthew Chen 80ae5e0fcf Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 11b4848530 Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 84061cca9f Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Matthew Chen 55aa5eef6c Clean up ahead of PR. 2017-12-11 10:37:20 -05:00
Matthew Chen 125aabb0a3 Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Michael Kirk d9cca77e23 update header references
// FREEBIE
2017-12-08 13:32:52 -05:00
Michael Kirk 3ecf0a7537 Cancelling dismisses share extension, remove "import with signal"
Usinig the new ShareViewDelegate to dismiss the share extension, might
have broken the "import with signal" functionality. But because we
want to remove it anyway, I've done that now, rather than fix it up.

// FREEBIE
2017-12-07 17:12:03 -05:00
Michael Kirk 0429836ff9 CR: rename keyWindow -> keyReferenceView, split long line
// FREEBIE
2017-12-07 10:39:44 -05:00
Michael Kirk 3f6f881d3f Use assets from duplicated main bundle
// FREEBIE
2017-12-07 10:14:30 -05:00
Michael Kirk eca19e5874 Reconcile MediaMessageView zoom behavior with AppExtension
Previously it was predicated on UIApplication.shared

// FREEBIE
2017-12-07 10:14:30 -05:00
Michael Kirk 3eceb86371 Show alert if we fail to build the attachment
// FREEBIE
2017-12-07 10:14:30 -05:00
Michael Kirk 89b9887f1d Make DeviceSleepManager extension compatible
// FREEBIE
2017-12-07 10:13:47 -05:00
Michael Kirk e20072ff2b CR: remove bundle specific image assets
// FREEBIE
2017-12-07 10:13:06 -05:00
Michael Kirk 56fe9d057d Attachment Approval
// FREEBIE
2017-12-07 10:13:06 -05:00
Michael Kirk a58f1f385c Share a photo from photos app
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
2017-12-07 10:13:06 -05:00