Commit graph

1459 commits

Author SHA1 Message Date
Matthew Chen
919e886eb7 Ensure brush strokes include the entire gesture. 2019-03-01 09:36:23 -05:00
Matthew Chen
65ee1dbd75 Hide the current text item while the text item editor is open. 2019-03-01 09:36:18 -05:00
Matthew Chen
d15f5b581f Tweak how image editor overlays are presented. 2019-03-01 09:36:12 -05:00
Matthew Chen
7ee38f808d Show "add attachment caption" button for non-media attachments; only show if more than one attachment. 2019-03-01 09:36:05 -05:00
Matthew Chen
82f18d8e4e Respond to CR. 2019-03-01 09:28:40 -05:00
Matthew Chen
63637af240 Clean up ahead of PR. 2019-03-01 09:07:03 -05:00
Matthew Chen
dc4e174e86 Clean up ahead of PR. 2019-03-01 09:07:03 -05:00
Matthew Chen
7c486d9093 Clean up image editor. 2019-03-01 09:07:03 -05:00
Matthew Chen
fa08b18fd7 Clean up image editor. 2019-03-01 09:07:03 -05:00
Matthew Chen
b64be3aa73 Clean up image editor. 2019-03-01 09:07:03 -05:00
Matthew Chen
97660e0a11 Clean up image editor. 2019-03-01 09:07:03 -05:00
Matthew Chen
bc31c8fcf4 Add brush view controller. 2019-03-01 09:07:03 -05:00
Matthew Chen
00aa5be55d Use navigation bar for image editor buttons. 2019-03-01 09:06:36 -05:00
Matthew Chen
e47ceab41c Use navigation bar for image editor buttons. 2019-03-01 09:06:36 -05:00
Matthew Chen
a630974e76 Use navigation bar for image editor buttons. 2019-03-01 09:06:36 -05:00
Matthew Chen
87646b1798 Replace old caption view with new caption view. 2019-03-01 09:06:36 -05:00
Michael Kirk
71dd4eb151 in-conversation search
- use MediaTime for computing benchmarks
2019-02-28 16:19:16 -07:00
Matthew Chen
be26c135e1 Rework image editor buttons, modes, etc. 2019-02-28 16:20:44 -05:00
Matthew Chen
d08445969d Generate gradient for color picker. 2019-02-28 16:20:44 -05:00
Matthew Chen
fac123eeb2 Add "crop lock" button and feature. 2019-02-28 16:20:43 -05:00
Matthew Chen
e01f39e8e1 Apply image editor design. 2019-02-28 16:20:43 -05:00
Matthew Chen
d419709ebd Respond to CR. 2019-02-28 16:19:54 -05:00
Matthew Chen
de27ed8728 Add color palette to image editor. 2019-02-28 15:53:12 -05:00
Michael Kirk
3be41e8c25 Unless you're on a call, all windows respect the orientation mask of the
primary app visible VC.

Fixes:
- Avoid flicker when forgrounding onboarding while in landscape
- Fix status bar in landscape while fingerprint is portrait, same with device linker
2019-02-26 19:52:09 -07:00
Matthew Chen
dd2b47bd76 Add "flip horizontal" feature. 2019-02-26 17:43:16 -05:00
Matthew Chen
0ce84b7929 Respond to CR. 2019-02-26 17:42:27 -05:00
Matthew Chen
69635fafac Update crop view to reflect design. 2019-02-26 13:28:44 -05:00
Matthew Chen
4db09b45b6 Update crop view to reflect design. 2019-02-26 13:28:44 -05:00
Matthew Chen
c07a74d029 Update crop view to reflect design. 2019-02-26 13:28:44 -05:00
Matthew Chen
ac1e89ce1d Respond to CR. 2019-02-26 13:27:54 -05:00
Matthew Chen
cc20182ec0 Normalize translation in image editor. 2019-02-26 13:19:40 -05:00
Matthew Chen
0d26caced7 Normalize translation in image editor. 2019-02-26 13:19:40 -05:00
Matthew Chen
f01fe8e563 Normalize translation in image editor. 2019-02-26 13:19:40 -05:00
Michael Kirk
5bd3cec6dc Merge tag '2.36.1.0' 2019-02-26 10:07:54 -07:00
Michael Kirk
870caaa84a simplify completion checking - make nonnull 2019-02-26 10:06:52 -07:00
Michael Kirk
13154fb828 allow long text with non-durable sends (SAE) 2019-02-26 10:06:52 -07:00
Matthew Chen
56e5feca46 Introduce ConversationSnapshot. 2019-02-26 10:55:44 -05:00
Matthew Chen
2bc5ac14ca Respond to CR. 2019-02-26 10:51:16 -05:00
Matthew Chen
7130895e3f Fix translation in all of editor view's gestures. 2019-02-26 10:06:06 -05:00
Matthew Chen
674cf2e01f Render stroke and text items in image coordinates, not canvas coordinates. 2019-02-26 10:06:06 -05:00
Matthew Chen
7aa826748a Fix translation in crop editor's pinch gesture. 2019-02-26 10:06:06 -05:00
Matthew Chen
4022ba1a16 Fix translation in crop editor's pan gesture. 2019-02-26 10:06:06 -05:00
Matthew Chen
72082edad8 Fix a visual bug that would sometimes occur while rendering settings switches. Thanks to Gunnar C. Pope for the bug report. 2019-02-25 15:13:16 -07:00
Michael Kirk
f1623b6037 missing nullability text 2019-02-25 13:27:49 -07:00
Michael Kirk
7e5256856c render media+longText message 2019-02-25 13:27:49 -07:00
Michael Kirk
b7989e9384 feature flag approval sending 2019-02-25 13:27:49 -07:00
Michael Kirk
bc4260b444 Send long-text with other attachments 2019-02-25 13:27:49 -07:00
Michael Kirk
a218d6c465 Send first chars of longtext in protobuf 2019-02-25 13:27:49 -07:00
Michael Kirk
680b844f3c Allow all windows to do landscape, fixes:
1. Remove undesirable animation from portrait->landscape when minimizizing in
   landscape and relaunching in landscape.

2. This also seems to fix the intermittently misplaced toolbar when launching
   in landscape. I believe this is a consequence of fix #1
2019-02-21 17:38:52 -07:00
Michael Kirk
7a4041cdde Cache dark theme preference
This is a hot path
2019-02-21 16:20:03 -07:00
Michael Kirk
fabd3996c2 pop view if message is deleted
- use global ui database connection
2019-02-21 16:18:14 -07:00
Matthew Chen
9402e088b2 Apply design feedback from Myles. 2019-02-21 14:16:31 -05:00
Matthew Chen
93e09be18e Apply design feedback from Myles. 2019-02-21 14:16:31 -05:00
Matthew Chen
aa8fd9e69c Remove old registration views. 2019-02-20 17:35:46 -05:00
Matthew Chen
8ecad88674 Move the accessibility identifier macros into UIUtil.h. 2019-02-19 16:11:36 -05:00
Matthew Chen
4d4b840787 Respond to CR. 2019-02-19 13:59:53 -05:00
Matthew Chen
ef5cd5344e Fix the auto-format of phone numbers in the onboarding views. 2019-02-19 13:42:47 -05:00
Matthew Chen
edf09c92f4 Rework "empty inbox" state. 2019-02-19 13:40:06 -05:00
Matthew Chen
1f922aa478 Sketch out the 'onboarding code verification' view. 2019-02-15 14:19:12 -05:00
Matthew Chen
05d63fd6b5 Update font sizes in onboarding views. 2019-02-14 16:22:51 -05:00
Matthew Chen
8cfe768e86 Update font sizes in onboarding views. 2019-02-14 16:20:29 -05:00
Matthew Chen
b658866319 Sketch out the 'onboarding phone number' view. 2019-02-14 08:55:37 -05:00
Matthew Chen
2a4b9426c3 Sketch out the 'onboarding phone number' view. 2019-02-14 08:54:27 -05:00
Matthew Chen
c0f907c441 Respond to CR. 2019-02-13 17:13:57 -05:00
Matthew Chen
69c5492fce Clean up ahead of PR. 2019-02-13 16:43:41 -05:00
Matthew Chen
331a013f8d Clean up ahead of PR. 2019-02-13 16:43:41 -05:00
Matthew Chen
618a3b1d47 Sketch out crop tool. 2019-02-13 16:43:41 -05:00
Matthew Chen
54c8c1f352 Sketch out the onboarding splash view. 2019-02-13 16:36:46 -05:00
Matthew Chen
2c0aa7a222 Sketch out the onboarding permissions view. 2019-02-13 16:35:19 -05:00
Matthew Chen
73b36c5400 Respond to CR. 2019-02-12 10:03:32 -05:00
Matthew Chen
6ac2dd7ea1 First draft of image editor's text tool. 2019-02-12 09:34:53 -05:00
Matthew Chen
3f8ea271b4 First draft of image editor's text tool. 2019-02-12 09:34:53 -05:00
Michael Kirk
cc2e062b85 CR: clean up graphics context code 2019-02-07 08:43:12 -07:00
Michael Kirk
2323cc21f0 note-to-self avatar 2019-02-07 08:34:48 -07:00
Michael Kirk
d29ce740cb Voice Note Lock 2019-02-06 17:34:29 -07:00
Matthew Chen
ea547fa46a Merge tag '2.35.0.12' 2019-02-04 13:15:30 -05:00
Michael Kirk
d88ffc4775 Notification titles for iOS10+ 2019-02-04 10:35:17 -07:00
Michael Kirk
fe84275cce Respect audio preferences/throttling 2019-02-01 17:44:13 -07:00
Michael Kirk
1bfe691895 In app notifications for iOS10+
Extract shared notification presention/response

Implement adapters which use that logic for modern UNUserNotification and
legacy UINotifications
2019-02-01 17:44:13 -07:00
Matthew Chen
6bfe0f0418 Ensure 'link new device' view is portrait. 2019-02-01 17:37:57 -05:00
Matthew Chen
7a990ed1ff Ensure 'link new device' view is portrait. 2019-02-01 17:37:57 -05:00
Matthew Chen
6b5952abda Move work off main thread. 2019-01-31 15:48:50 -05:00
Matthew Chen
12e57ecd25 Improve background screenshots v. orientation. 2019-01-31 10:14:06 -05:00
Matthew Chen
4be302bbea Update link previews setting behavior. 2019-01-29 16:32:30 -05:00
Matthew Chen
77396e11fd Send sync messages with link previews preference. 2019-01-29 16:27:39 -05:00
Matthew Chen
910df7069c Link previews migration. 2019-01-29 09:18:09 -05:00
Matthew Chen
7f2ca60615 Link previews migration. 2019-01-29 09:16:47 -05:00
Matthew Chen
2b71c433ac Update appearance of draft quoted replies. 2019-01-28 15:51:54 -05:00
Matthew Chen
ccb174120f Tweak conversation input toolbar layout. 2019-01-28 14:44:50 -05:00
Matthew Chen
39de96ac26 Re-enable landscape orientation; fix 'double activation' issue. 2019-01-28 11:48:49 -05:00
Matthew Chen
c359f2b708 Replace "connecting/sonar ping" with "outbound ringing." 2019-01-28 11:03:50 -05:00
Matthew Chen
c02d633272 Align draft view of link preview and draft view of quoted reply. 2019-01-25 16:43:16 -05:00
Matthew Chen
9149282e94 Resize link preview images if necessary. 2019-01-24 13:28:54 -05:00
Matthew Chen
4e7dbc486d Segment proxied content downloads. 2019-01-24 08:51:25 -05:00
Matthew Chen
82ceb044e3 Use link preview image when quote replying. 2019-01-23 13:17:23 -05:00
Matthew Chen
9b7ae86a6d Rework layout of conversation input toolbar. 2019-01-23 13:02:52 -05:00
Matthew Chen
6ff6ee2e2e Rework layout of conversation input toolbar. 2019-01-23 13:02:52 -05:00
Matthew Chen
3d757b492a Add link previews to conversation message bubbles. 2019-01-23 09:32:30 -05:00
Matthew Chen
8c7c9b27a2 Merge tag '2.34.0.26' 2019-01-23 09:14:26 -05:00
Michael Kirk
896a9f78f7 limit media message body to 2k chars 2019-01-22 13:25:07 -07:00
Michael Kirk
599a57e3a4 Pan horizontal to bulk select images 2019-01-22 09:19:17 -07:00
Michael Kirk
169581f12f show toast when selecting too many items 2019-01-22 09:12:43 -07:00
Matthew Chen
977ee9ffe9 Merge remote-tracking branch 'private/release/2.34.0' 2019-01-22 11:10:04 -05:00
Matthew Chen
2dcc79fbca Fix issues around link previews. 2019-01-22 10:15:50 -05:00
Matthew Chen
8e44bf554c Respond to CR. 2019-01-22 09:42:25 -05:00
Matthew Chen
d775a70a89 Build link previews. 2019-01-22 09:42:25 -05:00
Matthew Chen
31ea64bdaf Build link previews. 2019-01-22 09:42:25 -05:00
Matthew Chen
7878c0fac8 Add feature flag for 'note to self'. 2019-01-18 17:22:12 -05:00
Michael Kirk
721f330296 warm non-signal accounts cache in the background 2019-01-17 13:27:34 -07:00
Matthew Chen
debf2e7a95 Fix 'mutation during enumeration' and 'bad ordering' crashes. 2019-01-17 14:42:24 -05:00
Michael Kirk
0fb6dab020 avoid blocking write connection with long running read when building sync message 2019-01-17 09:55:51 -07:00
Michael Kirk
3c0982e0f9 Fix missing captionView when navigating via RailView 2019-01-17 09:54:10 -07:00
Michael Kirk
0c1b2e9f48 CR: remove unnecessary param, clearer code, comment typo 2019-01-17 09:47:01 -07:00
Michael Kirk
6e50a5353b rename for clarity 2019-01-16 17:06:37 -07:00
Matthew Chen
be714399c7 Add feature flag for landscape orientation. 2019-01-16 16:49:25 -05:00
Matthew Chen
eab3599ce9 Add feature flag for landscape orientation. 2019-01-16 16:42:11 -05:00
Michael Kirk
b4908e71e9 Use FTS for compose picker search 2019-01-16 14:39:35 -07:00
Matthew Chen
635a644e2f Fix safe area insets in SAE. 2019-01-16 10:04:33 -05:00
Matthew Chen
50f9a089bf Fix navbar layout in share extension. 2019-01-16 09:55:23 -05:00
Matthew Chen
a477e01a4a Apply LinkPreview model. 2019-01-14 16:20:54 -05:00
Matthew Chen
efd1be30c7 Cull unknown migrations. 2019-01-11 16:46:33 -05:00
Michael Kirk
0e78f9912b bump migration version 2019-01-11 07:44:19 -07:00
Matthew Chen
bf0d92acfb Landscape layout in gif picker. 2019-01-10 12:04:12 -05:00
Matthew Chen
4ab0c8fe58 Landscape orientation. 2019-01-09 15:22:55 -05:00
Matthew Chen
2ddde368ec Landscape orientation. 2019-01-09 15:22:55 -05:00
Matthew Chen
5adcbac5ef Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen
460f160cbb Landscape orientation. 2019-01-09 15:13:48 -05:00
Michael Kirk
099b9f60c3 enable multisend 2019-01-09 12:29:31 -07:00
Michael Kirk
0ab326da92 Only show delete button on selected rail item 2019-01-09 12:27:15 -07:00
Matthew Chen
c0922fc2c0 Remove LockInteractionController. 2019-01-08 13:52:36 -05:00
Michael Kirk
265552ae0e enable multisend in debug 2019-01-08 09:51:42 -07:00
Michael Kirk
c690ac2710 allow deselecting tool 2019-01-08 09:51:42 -07:00
Michael Kirk
a8200d6f4a Fix swipe between multi-images
gesture shouldn't be enabled until tool has been selected
2019-01-08 09:51:42 -07:00
Matthew Chen
5e3de84fdc Add feature flag for image editor. 2019-01-07 08:48:18 -05:00
Matthew Chen
9ab8bec2b1 Fix searching for 'note to self'. 2019-01-07 08:45:42 -05:00
Matthew Chen
fc8fbebd97 Note to Self. 2019-01-03 18:06:56 -05:00
Matthew Chen
8aa68327e6 Add primitive color picker. 2019-01-03 18:03:47 -05:00
Matthew Chen
a440f692ce Clean up image editor temp files. 2019-01-03 18:01:45 -05:00
Matthew Chen
b24e8e4f81 Use autoreleasepool when rendering image editor output. 2019-01-03 18:01:45 -05:00
Matthew Chen
2b25d875bc Don't select a tool by default in image editor view. 2019-01-03 18:01:45 -05:00
Matthew Chen
5dcde44486 Image editor fixes. 2019-01-03 16:56:24 -05:00
Matthew Chen
17c3ba0580 Image editor fixes. 2019-01-03 16:56:24 -05:00
Michael Kirk
3151e6e1a3 move string extensions up 2018-12-20 09:54:08 -07:00
Michael Kirk
df79fc9ed0 Move String+OWS into SSK
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
2018-12-20 09:54:08 -07:00
Michael Kirk
a0770c14c5 baseline perf test for migration 2018-12-19 15:19:02 -07:00
Michael Kirk
af7ee5e1d1 address compiler breakage after rebase 2018-12-19 15:16:36 -07:00
Michael Kirk
45e572e82f assert monotonic order for migration 2018-12-19 15:16:36 -07:00
Michael Kirk
5671fd2520 Revert "Revert 'new sort id'."
This reverts commit ebae75af00.
2018-12-19 15:16:36 -07:00
Matthew Chen
35b6f6cf12 Respond to CR. 2018-12-19 15:08:28 -05:00
Matthew Chen
db8bc58b6d Implement crop. 2018-12-19 14:48:37 -05:00
Matthew Chen
57f888a447 Add crop gesture. 2018-12-19 14:48:37 -05:00
Matthew Chen
03cbeb5fee Start working on crop. 2018-12-19 14:48:37 -05:00
Matthew Chen
2f95413bcf Use narrow change events in image editor. 2018-12-19 14:45:20 -05:00
Matthew Chen
f224c2130a Suppress undo during strokes. 2018-12-19 14:45:20 -05:00
Matthew Chen
cf1763e79d Suppress undo during strokes. 2018-12-19 14:45:20 -05:00
Matthew Chen
3d67c6574d Suppress undo during strokes. 2018-12-19 14:45:20 -05:00
Matthew Chen
9378ab2192 Add undo/redo buttons to image editor. 2018-12-19 14:45:20 -05:00
Matthew Chen
bd40aacd53 Purge dynamic interactions from database. 2018-12-18 10:55:54 -05:00
Matthew Chen
d1cf942f7e Respond to CR. 2018-12-18 10:53:41 -05:00
Matthew Chen
825826aa05 Reduce jitter with smoothing. 2018-12-18 10:53:41 -05:00
Matthew Chen
b8775006bb Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
794241963e Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
da13dc1d2e Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
bf734d5959 Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
04cd6c3495 Clean up ahead of PR. 2018-12-18 10:53:41 -05:00
Matthew Chen
639dac4e26 Add stroke drawing to the image editor. 2018-12-18 10:53:41 -05:00
Matthew Chen
b0e0c6e8c2 Replace edited attachments when sending. 2018-12-18 10:53:41 -05:00
Matthew Chen
2f7e99de46 Smooth stroke rendering. 2018-12-18 10:53:41 -05:00
Matthew Chen
e2afe27f5e Add trivial test interaction to image editor. 2018-12-18 10:53:41 -05:00
Matthew Chen
0d81139be5 Debug scaffolding. 2018-12-18 10:53:41 -05:00
Matthew Chen
4752cb94f5 Add ImageEditorView. 2018-12-18 10:53:41 -05:00
Matthew Chen
04440ed1e6 Add ImageEditorStrokeItem. 2018-12-18 10:53:41 -05:00
Matthew Chen
8704ffe93c Sketch out image editor undo/redo. 2018-12-18 10:53:41 -05:00
Matthew Chen
57232683fc Sketch out image editor undo/redo. 2018-12-18 10:53:41 -05:00
Matthew Chen
f95526bff7 Start sketching out image editor. 2018-12-18 10:53:41 -05:00
Matthew Chen
26a25f861b Start sketching out image editor. 2018-12-18 10:53:41 -05:00
Michael Kirk
fd6a56b3af format bench in ms 2018-12-17 14:44:49 -07:00
Michael Kirk
6232b1ef67 CR: add debug asserts 2018-12-17 14:43:50 -07:00
Michael Kirk
81bc357bbb more robust handling of unsaved outgoing messages 2018-12-17 14:43:50 -07:00
Michael Kirk
668cc22af3 Perf: Insert outgoing message into conversation before save completes.
This was a huge savings - e.g. 50-70% of the time between tapping send and
rendering the message takes place in the save/postWriteTransaction blocks
2018-12-17 14:43:50 -07:00
Michael Kirk
67cc1027cc Fix compiler warnings 2018-12-17 14:43:21 -07:00
Michael Kirk
ac2c9cc521 Benchmark Events by ID 2018-12-13 14:32:27 -07:00
Matthew Chen
19a2bfeaad More conversation viewmodel perf improvements. 2018-12-13 11:50:55 -05:00
Matthew Chen
fea40d571c Move contact offers to Conversation view model. 2018-12-13 09:12:41 -05:00
Matthew Chen
d717ee5411 Parse and apply profile fetches off main thread. 2018-12-13 09:08:32 -05:00
Michael Kirk
6ece45a2e4 toggle multisend feature flag 2018-12-12 10:08:22 -07:00
Michael Kirk
c0cb7df10a rename hasEverHadMessage -> shouldThreadBeVisible 2018-12-12 08:46:15 -07:00
Michael Kirk
b7ab036c04 warn_unused_result on AnyPromise methods 2018-12-11 09:37:44 -07:00
Matthew Chen
48bd0cfa06 Add missing retains to promises. 2018-12-11 10:43:47 -05:00
Michael Kirk
858ba6ef37 fix missing video thumbnails in approval view 2018-12-10 10:05:28 -07:00
Michael Kirk
3e48ed105d keyboard is always dark in attachment approval 2018-12-10 10:04:01 -07:00
Michael Kirk
2f92995cd6 Add placeholder text to message input field 2018-12-10 10:04:01 -07:00
Michael Kirk
eb96eec94a Merge branch 'release/2.32.0' 2018-12-07 09:55:43 -05:00
Michael Kirk
34737567c2 fix voice over for settings bar button item 2018-12-06 19:45:20 -05:00
Michael Kirk
de73c220da increment version canary 2018-12-05 13:56:34 -05:00
Michael Kirk
1a5c47df2f Fix SAE, limit max attachments 2018-12-05 13:56:34 -05:00
Matthew Chen
d70aa4418f Merge branch 'release/2.32.0' 2018-12-03 22:20:50 -05:00
Matthew Chen
894fd1379c Fix spurious assert. 2018-12-03 22:06:38 -05:00
Matthew Chen
aa4fea64cf Improve Profiles Debug UI. 2018-12-03 22:02:03 -05:00
Matthew Chen
d6ca969c62 Backup local profile. 2018-11-29 09:10:27 -05:00
Matthew Chen
c7f5047056 Handle iCloud status. 2018-11-29 08:57:51 -05:00
Michael Kirk
128bb9be8c Merge tag '2.32.0.17' 2018-11-28 22:15:39 -07:00
Michael Kirk
71ab5817eb fix captionview visibility 2018-11-28 21:23:31 -07:00
Matthew Chen
c5744321ba Backup misc collections. 2018-11-28 17:05:08 -05:00
Matthew Chen
4556025566 Update migrations. 2018-11-28 16:01:12 -05:00
Michael Kirk
61758dcf05 Only show caption for multiple images 2018-11-27 15:39:45 -07:00
Michael Kirk
0ac8f13c0b remove redunant method, consolidate naming, adding array getter 2018-11-27 15:39:45 -07:00
Michael Kirk
6fdd5d1001 dont initializer pagerScrollView as sideEffect 2018-11-27 15:39:45 -07:00
Michael Kirk
9bcc6a6c57 show navbar for photo/album picker, not approval 2018-11-27 10:27:13 -07:00
Matthew Chen
dcaaff7eac Add isRegisteredAndReady to TSAccountManager. 2018-11-27 09:21:44 -05:00
Matthew Chen
8110e0c765 Clean up usage of TSAccountManager. 2018-11-27 09:21:44 -05:00
Michael Kirk
26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 2018-11-26 14:11:13 -07:00
Michael Kirk
78c74d87bc Merge tag '2.32.0.16' 2018-11-26 13:03:27 -07:00
Michael Kirk
9317ee9c99 design comment 2018-11-26 12:57:50 -07:00
Michael Kirk
e3120a5b87 cleanup keyboard animation code 2018-11-26 12:52:05 -07:00
Michael Kirk
0562619ca9 smaller margins between rail images, avoid choppy change as the margin updates
are not being animated smoothly.
2018-11-26 12:43:28 -07:00
Michael Kirk
55807f9a4d iPhoneX compatible keyboard animations 2018-11-26 12:43:28 -07:00
Michael Kirk
279694e704 keyboard animation cleanup 2018-11-26 12:43:28 -07:00
Michael Kirk
0808458392 fix caption dismiss animation/placeholder for multiline message body 2018-11-26 12:43:28 -07:00
Michael Kirk
4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
2018-11-26 12:43:28 -07:00
Michael Kirk
3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 2018-11-26 12:43:28 -07:00
Michael Kirk
b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
2018-11-26 12:43:28 -07:00
Michael Kirk
838012d1ec Caption length limit and label 2018-11-26 12:43:28 -07:00
Michael Kirk
e0f7513df0 white tint for attachment approval textview cursors 2018-11-26 12:43:28 -07:00
Michael Kirk
a946ec0056 new icon assets per design 2018-11-26 12:43:28 -07:00
Michael Kirk
8776dd1909 New "add caption" and "done" assets 2018-11-26 12:43:28 -07:00
Michael Kirk
feb5a0c444 fix initial CaptionView layout glitch 2018-11-26 12:43:28 -07:00
Michael Kirk
e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 2018-11-26 12:43:28 -07:00
Michael Kirk
33750baf67 finally got dismiss-before-swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
dd82803a10 second abandoned attempt to require dismiss before page 2018-11-26 12:43:28 -07:00
Michael Kirk
b98b3d1fdd WIP: require dismiss before swipe 2018-11-26 12:43:28 -07:00
Michael Kirk
706dd3d0c1 initial layout of keyboard is correct across pages 2018-11-26 12:43:28 -07:00
Michael Kirk
280664c763 WIP: keyboard 2018-11-26 12:43:28 -07:00
Michael Kirk
eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
2018-11-26 12:43:28 -07:00
Michael Kirk
8b5d1d9e69 Only add delete button once 2018-11-26 12:43:28 -07:00
Michael Kirk
28f8fc5911 per cr, avoid unnecessary 2018-11-26 12:37:58 -07:00
Michael Kirk
fcc4b516a5 fix typo in logging 2018-11-26 12:37:58 -07:00
Michael Kirk
4f0092615a Support captions *and* independent message body 2018-11-26 12:37:58 -07:00
Michael Kirk
cd88ef2bec CaptionView text field per page 2018-11-26 12:37:58 -07:00
Michael Kirk
79995cc52c rename captioning -> messageText
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Michael Kirk
47affb81c0 Move gallery rail into input accessory view
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Matthew Chen
544bdbd7f5 Fix edge cases around registration. 2018-11-26 09:58:59 -05:00
Matthew Chen
3edf3ed199 Don't use UD for "self" profile fetches. 2018-11-26 09:19:12 -05:00
Michael Kirk
31782af2f1 dark theme section headers in tile gallery 2018-11-25 18:03:20 -06:00
Michael Kirk
6cdef57e2a Merge tag '2.32.0.15' 2018-11-25 12:54:59 -06:00
Michael Kirk
18766280f6 fix crash when non-registered user upgrades 2018-11-23 11:38:51 -06:00
Michael Kirk
dbe8e5706d avoid crash on iOS9/10 2018-11-21 22:26:59 -06:00
Matthew Chen
8eb2550e0c Respond to CR. 2018-11-15 14:10:19 -05:00
Matthew Chen
8b24fba095 Add "add more" button to image picker. Provide caption editing continuity. 2018-11-15 14:10:19 -05:00
Michael Kirk
87bfdbb72c Sender Rail 2018-11-15 12:25:28 -06:00