Commit graph

1373 commits

Author SHA1 Message Date
Michael Kirk
71dd4eb151 in-conversation search
- use MediaTime for computing benchmarks
2019-02-28 16:19:16 -07:00
Michael Kirk
b11308b2f8 Return to conversation after deleting long text 2019-02-26 17:19:18 -07:00
Matthew Chen
7711ee92a7 Revert "Conversation view always observes view model."
This reverts commit 9d39e829a44f28f324f79e0b74a6c8692678d788.
2019-02-26 10:56:23 -05:00
Matthew Chen
6ed4045fbe Conversation view always observes view model. 2019-02-26 10:56:11 -05:00
Matthew Chen
56e5feca46 Introduce ConversationSnapshot. 2019-02-26 10:55:44 -05:00
Matthew Chen
586b362b89 Introduce ConversationSnapshot. 2019-02-26 10:55:44 -05:00
Michael Kirk
233bc3858b dismiss menu actions when selected item is deleted 2019-02-25 14:10:12 -07:00
Michael Kirk
c6a3772a5e clearer constant names 2019-02-25 13:27:49 -07:00
Michael Kirk
7e5256856c render media+longText message 2019-02-25 13:27:49 -07:00
Michael Kirk
bc4260b444 Send long-text with other attachments 2019-02-25 13:27:49 -07:00
Michael Kirk
a218d6c465 Send first chars of longtext in protobuf 2019-02-25 13:27:49 -07:00
Michael Kirk
fabd3996c2 pop view if message is deleted
- use global ui database connection
2019-02-21 16:18:14 -07:00
Michael Kirk
467dde2bc9 Try to avoid generating link previews while user is actively editing the URL 2019-02-20 09:38:52 -07:00
Michael Kirk
2c59b1bf13 fix iPhoneX layout 2019-02-07 12:44:35 -07:00
Michael Kirk
d29ce740cb Voice Note Lock 2019-02-06 17:34:29 -07:00
Michael Kirk
1bfe691895 In app notifications for iOS10+
Extract shared notification presention/response

Implement adapters which use that logic for modern UNUserNotification and
legacy UINotifications
2019-02-01 17:44:13 -07:00
Matthew Chen
501e883cc4 Merge tag '2.35.0.10' 2019-02-01 17:35:40 -05:00
Matthew Chen
dd506430d9 Fix the input toolbar border. 2019-02-01 17:17:40 -05:00
Matthew Chen
4feb0011d7 Reduce logging. 2019-01-31 15:48:50 -05:00
Matthew Chen
6a132a065e Add upper bound on body media size. 2019-01-31 15:07:23 -05:00
Matthew Chen
4827de5d88 Add upper bound on body media size. 2019-01-31 15:06:21 -05:00
Matthew Chen
f71483a200 Fix input toolbar background in dark mode. 2019-01-31 11:51:53 -05:00
Matthew Chen
a222a12fab Fix input toolbar background in dark mode. 2019-01-31 11:50:23 -05:00
Matthew Chen
230612f02f Fix input toolbar background in dark mode. 2019-01-31 10:45:59 -05:00
Matthew Chen
3d1b930e06 Fix navigation to quoted replies outside load window. 2019-01-29 13:39:15 -05:00
Matthew Chen
890dfdcc06 Fix reset of 'link preview cancelled' state. 2019-01-29 10:36:54 -05:00
Matthew Chen
2b71c433ac Update appearance of draft quoted replies. 2019-01-28 15:51:54 -05:00
Matthew Chen
25fd43d646 Update appearance of draft quoted replies. 2019-01-28 14:45:31 -05:00
Matthew Chen
ccb174120f Tweak conversation input toolbar layout. 2019-01-28 14:44:50 -05:00
Matthew Chen
5830c62403 Fix quoted reply image aspect ratio. 2019-01-25 17:06:05 -05:00
Matthew Chen
75e017b2c1 Align draft view of link preview and draft view of quoted reply. 2019-01-25 16:48:54 -05:00
Matthew Chen
c02d633272 Align draft view of link preview and draft view of quoted reply. 2019-01-25 16:43:16 -05:00
Matthew Chen
0cc667d123 Fix spacing between quoted replies and link previews in sent message bubbles. 2019-01-25 15:57:26 -05:00
Matthew Chen
e4d11eb15f Fix conversation text input background color. 2019-01-25 15:43:42 -05:00
Matthew Chen
9c806d59df Safely ignore invalid link preview images. 2019-01-25 15:33:32 -05:00
Matthew Chen
957a733838 Yet more link preview refinements. 2019-01-25 11:33:09 -05:00
Matthew Chen
c6387e7c6a Simplify the logic to flush database changes. 2019-01-24 17:04:38 -05:00
Matthew Chen
e7b9f7da99 Flush multi-process writes more aggressively. 2019-01-24 17:03:49 -05:00
Matthew Chen
9b33d70d7b Constrain max size of link preview image. 2019-01-24 13:06:22 -05:00
Matthew Chen
9efe1377a2 Refine invalidation of conversation view layout. 2019-01-24 10:39:03 -05:00
Matthew Chen
eb7c6ff441 Respond to CR. 2019-01-23 13:10:25 -05:00
Matthew Chen
9b7ae86a6d Rework layout of conversation input toolbar. 2019-01-23 13:02:52 -05:00
Matthew Chen
6ff6ee2e2e Rework layout of conversation input toolbar. 2019-01-23 13:02:52 -05:00
Matthew Chen
8452f5e74b Open link preview URLs when tapped. 2019-01-23 09:58:37 -05:00
Matthew Chen
a51182321c Respond to CR. 2019-01-23 09:56:46 -05:00
Matthew Chen
3d757b492a Add link previews to conversation message bubbles. 2019-01-23 09:32:30 -05:00
Matthew Chen
ca8a4b3751 Make LinkPreviewView reusable. 2019-01-23 09:27:52 -05:00
Matthew Chen
c7053aa36d Add link previews to converastion view items. 2019-01-23 09:26:05 -05:00
Matthew Chen
8c7c9b27a2 Merge tag '2.34.0.26' 2019-01-23 09:14:26 -05:00
Matthew Chen
416aa2b347 Add rough draft of link preview view to composer. 2019-01-23 09:11:13 -05:00
Matthew Chen
79000d5fbb Save and share all items in album. 2019-01-22 17:14:06 -05:00
Matthew Chen
8dc6ea0c08 Revert "Save and share all items in album"
This reverts commit 58ab3948e969fe09872e51061e2311535d9e0eb4.
2019-01-22 17:14:06 -05:00
Matthew Chen
4fda1be3f5 Save and share all items in album 2019-01-22 17:14:06 -05:00
Michael Kirk
f1e508cb60 Recover status bar style when canceling PhotoPicker 2019-01-22 09:13:22 -07:00
Matthew Chen
977ee9ffe9 Merge remote-tracking branch 'private/release/2.34.0' 2019-01-22 11:10:04 -05:00
Matthew Chen
d6a51a2a42 Fix merge breakage. 2019-01-22 10:21:43 -05:00
Matthew Chen
31ea64bdaf Build link previews. 2019-01-22 09:42:25 -05:00
Matthew Chen
127ccccb80 Tweak conversation view's "load more" behavior. 2019-01-17 14:36:31 -05:00
Matthew Chen
e91195385b Respond to CR. 2019-01-15 16:39:01 -05:00
Matthew Chen
04a300784f Respond to CR. 2019-01-15 16:34:46 -05:00
Matthew Chen
42762ad907 Allow taps in albums with failed images. 2019-01-15 16:34:46 -05:00
Matthew Chen
b8e2cb6267 Respond to CR. 2019-01-15 16:33:54 -05:00
Matthew Chen
18c890bb95 Fix input toolbar margins issue. 2019-01-15 16:30:32 -05:00
Matthew Chen
d32372ec26 Respond to CR. 2019-01-11 17:55:21 -05:00
Matthew Chen
9dda2fa8c0 Improve scroll state continuity during conversation view rotations. 2019-01-11 17:55:21 -05:00
Matthew Chen
cb228bdd29 Fix conversation view keyboard. 2019-01-10 12:04:12 -05:00
Matthew Chen
18a1d49b46 Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen
721cab7887 Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen
9497a38d76 Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen
b5d5822b7b Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen
aefe0eabed Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen
045b112724 Landscape orientation. 2019-01-09 15:14:36 -05:00
Matthew Chen
460f160cbb Landscape orientation. 2019-01-09 15:13:48 -05:00
Michael Kirk
014cf9c500 fix crash on iOS9 2019-01-08 09:55:35 -07:00
Matthew Chen
c30f155221 Fix overzealous assert. 2019-01-07 17:04:54 -05:00
Matthew Chen
7df17251a2 Fix edge cases in conversation view scroll continuity. 2019-01-07 15:37:31 -05:00
Matthew Chen
b92051c881 Fix edge cases in conversation view scroll continuity. 2019-01-07 15:37:31 -05:00
Matthew Chen
6b881b9efe Fix edge cases in conversation view scroll continuity. 2019-01-07 15:37:31 -05:00
Matthew Chen
f90e49226d Respond to CR. 2019-01-07 12:47:15 -05:00
Matthew Chen
73f5d9237d Avoid overflow. 2019-01-07 12:47:15 -05:00
Matthew Chen
f32edc93e4 Tweak conversation view animations. 2019-01-07 12:47:15 -05:00
Matthew Chen
435379926a Introduce conversation view mapping; rework conversation view scrolling. 2019-01-07 12:47:15 -05:00
Matthew Chen
c5b0c73055 Introduce conversation view mapping; rework conversation view scrolling. 2019-01-07 12:47:15 -05:00
Matthew Chen
c775dbcd66 Introduce conversation view mapping; rework conversation view scrolling. 2019-01-07 12:47:15 -05:00
Matthew Chen
449633e0dc Respond to CR. 2019-01-04 09:19:41 -05:00
Matthew Chen
fc8fbebd97 Note to Self. 2019-01-03 18:06:56 -05:00
Matthew Chen
e52feb3c36 Note to Self. 2019-01-03 18:06:56 -05:00
Matthew Chen
4a84a19d00 Merge tag '2.33.0.11' 2019-01-02 17:24:07 -05:00
Michael Kirk
049b858125 Fix crash when update corresponds to a move.
reloading during performBatchUpdates requires the *original* indexPath, not the
new index path.
2019-01-02 16:42:48 -05:00
Michael Kirk
df79fc9ed0 Move String+OWS into SSK
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
2018-12-20 09:54:08 -07:00
Michael Kirk
af7ee5e1d1 address compiler breakage after rebase 2018-12-19 15:16:36 -07:00
Michael Kirk
5671fd2520 Revert "Revert 'new sort id'."
This reverts commit ebae75af00.
2018-12-19 15:16:36 -07:00
Matthew Chen
039755c0df Respond to CR. 2018-12-18 13:35:49 -05:00
Matthew Chen
f2d585f439 Always allow long-press for message actions. 2018-12-18 13:34:08 -05:00
Michael Kirk
f51416b2d2 save a few ms on send, hoist async dispatch to caller, and use it for clearing draft 2018-12-17 14:44:34 -07:00
Michael Kirk
6232b1ef67 CR: add debug asserts 2018-12-17 14:43:50 -07:00
Michael Kirk
81bc357bbb more robust handling of unsaved outgoing messages 2018-12-17 14:43:50 -07:00
Michael Kirk
62cf05cd8b assert only trivial unsaved messages are appended to the view model 2018-12-17 14:43:50 -07:00
Michael Kirk
087e320036 Track 'persisted' viewItems separately 2018-12-17 14:43:50 -07:00
Michael Kirk
e3610d4360 Apply other requisite ViewItem attributes 2018-12-17 14:43:50 -07:00
Michael Kirk
0ae4821950 always put typing indicator last 2018-12-17 14:43:50 -07:00
Michael Kirk
668cc22af3 Perf: Insert outgoing message into conversation before save completes.
This was a huge savings - e.g. 50-70% of the time between tapping send and
rendering the message takes place in the save/postWriteTransaction blocks
2018-12-17 14:43:50 -07:00
Michael Kirk
67cc1027cc Fix compiler warnings 2018-12-17 14:43:21 -07:00
Michael Kirk
4b84583de8 reload input bar async 2018-12-13 14:32:27 -07:00
Michael Kirk
ac2c9cc521 Benchmark Events by ID 2018-12-13 14:32:27 -07:00
Matthew Chen
9c46ce8662 Re-enable prefetching a bit sooner. 2018-12-13 14:34:08 -05:00
Matthew Chen
6797d43510 Auto-extend conversation load window size. 2018-12-13 14:28:49 -05:00
Matthew Chen
8a6f30518a Auto-extend conversation load window size. 2018-12-13 14:28:49 -05:00
Matthew Chen
6bc8f6d3a3 More perf tweaks for conversation view. 2018-12-13 13:32:00 -05:00
Matthew Chen
2bf0c55ab0 More perf tweaks for conversation view. 2018-12-13 13:32:00 -05:00
Matthew Chen
be8a61b559 Refine contact offers logic. 2018-12-13 11:50:55 -05:00
Matthew Chen
19a2bfeaad More conversation viewmodel perf improvements. 2018-12-13 11:50:55 -05:00
Matthew Chen
b0295b736b Add ReverseDispatchQueue. 2018-12-13 11:44:29 -05:00
Matthew Chen
85f6d05e0f Refine view model diffing. 2018-12-13 09:21:13 -05:00
Matthew Chen
90d8fb3d14 Refine view model diffing. 2018-12-13 09:21:13 -05:00
Matthew Chen
9db50bd9e0 Reduce priority of media loads. 2018-12-13 09:16:39 -05:00
Matthew Chen
21ab3fbbcb Respond to CR. 2018-12-13 09:16:39 -05:00
Matthew Chen
962c1acc9f Fix "blinking" regression media views. 2018-12-13 09:16:39 -05:00
Matthew Chen
047afe21ae Fix typo. 2018-12-13 09:16:39 -05:00
Matthew Chen
b9404938c4 Respond to CR. 2018-12-13 09:16:39 -05:00
Matthew Chen
358d97bf5b Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen
ddd6732f74 Revert "Always load conversation media async."
This reverts commit 297aa080163cb6eb324b40bae790768ff2fb1721.
2018-12-13 09:16:39 -05:00
Matthew Chen
5cb319a9c8 Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen
956859244d Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen
c1578b4b06 Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen
fea40d571c Move contact offers to Conversation view model. 2018-12-13 09:12:41 -05:00
Matthew Chen
15826cec5d Reduce initial conversation load window size. 2018-12-13 09:09:07 -05:00
Matthew Chen
9017c16e7e Sort interactions in CVM. 2018-12-13 09:07:49 -05:00
Michael Kirk
78e963404a remove overzealous assert, since we now sometimes post notification without threadId 2018-12-10 10:04:40 -07:00
Michael Kirk
52e21be656 fix draft scrolling 2018-12-10 10:03:01 -07:00
Matthew Chen
00c6ed2f3c Tweak scroll down animation behavior in conversation view. 2018-12-10 09:24:18 -05:00
Michael Kirk
eb96eec94a Merge branch 'release/2.32.0' 2018-12-07 09:55:43 -05:00
Matthew Chen
b88416a931 Apply dark theme changes to media downloads. 2018-12-07 09:12:31 -05:00
Michael Kirk
e834550649 ensure layout invalidated after leaving media landscape 2018-12-06 19:48:32 -05:00
Michael Kirk
694b9ef7e9 Merge tag '2.32.0.20' 2018-12-05 14:08:02 -05:00
Michael Kirk
1a5c47df2f Fix SAE, limit max attachments 2018-12-05 13:56:34 -05:00
Matthew Chen
6e457e43ca Clear typing indicators when they are disabled. 2018-12-05 13:31:54 -05:00
Matthew Chen
ee74691e80 Activate lazy restore of attachments. 2018-12-03 22:06:38 -05:00
Michael Kirk
92dd77779c Merge tag '2.32.0.19' 2018-12-03 16:39:06 -05:00
Matthew Chen
ab9e2c4e11 Ensure quoted replies with attachments are handled properly. 2018-11-30 11:05:55 -07:00
Michael Kirk
fcc4b516a5 fix typo in logging 2018-11-26 12:37:58 -07:00
Michael Kirk
4f0092615a Support captions *and* independent message body 2018-11-26 12:37:58 -07:00
Matthew Chen
f5ba8048b7 Clean up ahead of PR. 2018-11-21 08:53:15 -08:00
Matthew Chen
e72dafb08e Use attachment pointers to restore attachments from backup. 2018-11-21 08:53:15 -08:00
Michael Kirk
b87b2522e3 Merge tag '2.32.0.13' 2018-11-16 23:28:51 -06:00
Matthew Chen
910b249112 "Auto load more" async while scrolling. 2018-11-15 22:02:59 -05:00
Matthew Chen
8b24fba095 Add "add more" button to image picker. Provide caption editing continuity. 2018-11-15 14:10:19 -05:00
Michael Kirk
87bfdbb72c Sender Rail 2018-11-15 12:25:28 -06:00
Matthew Chen
2e50cc1f2d Respond to CR. 2018-11-13 13:14:24 -05:00
Matthew Chen
84d6f61d53 Fix glitches in conversation media view. 2018-11-13 11:57:16 -05:00