Matthew Chen
79000d5fbb
Save and share all items in album.
2019-01-22 17:14:06 -05:00
Matthew Chen
8dc6ea0c08
Revert "Save and share all items in album"
...
This reverts commit 58ab3948e969fe09872e51061e2311535d9e0eb4.
2019-01-22 17:14:06 -05:00
Matthew Chen
4fda1be3f5
Save and share all items in album
2019-01-22 17:14:06 -05:00
Michael Kirk
f1e508cb60
Recover status bar style when canceling PhotoPicker
2019-01-22 09:13:22 -07:00
Matthew Chen
977ee9ffe9
Merge remote-tracking branch 'private/release/2.34.0'
2019-01-22 11:10:04 -05:00
Matthew Chen
d6a51a2a42
Fix merge breakage.
2019-01-22 10:21:43 -05:00
Matthew Chen
31ea64bdaf
Build link previews.
2019-01-22 09:42:25 -05:00
Matthew Chen
127ccccb80
Tweak conversation view's "load more" behavior.
2019-01-17 14:36:31 -05:00
Matthew Chen
e91195385b
Respond to CR.
2019-01-15 16:39:01 -05:00
Matthew Chen
04a300784f
Respond to CR.
2019-01-15 16:34:46 -05:00
Matthew Chen
42762ad907
Allow taps in albums with failed images.
2019-01-15 16:34:46 -05:00
Matthew Chen
b8e2cb6267
Respond to CR.
2019-01-15 16:33:54 -05:00
Matthew Chen
18c890bb95
Fix input toolbar margins issue.
2019-01-15 16:30:32 -05:00
Matthew Chen
d32372ec26
Respond to CR.
2019-01-11 17:55:21 -05:00
Matthew Chen
9dda2fa8c0
Improve scroll state continuity during conversation view rotations.
2019-01-11 17:55:21 -05:00
Matthew Chen
cb228bdd29
Fix conversation view keyboard.
2019-01-10 12:04:12 -05:00
Matthew Chen
18a1d49b46
Landscape orientation.
2019-01-09 15:14:36 -05:00
Matthew Chen
721cab7887
Landscape orientation.
2019-01-09 15:14:36 -05:00
Matthew Chen
9497a38d76
Landscape orientation.
2019-01-09 15:14:36 -05:00
Matthew Chen
b5d5822b7b
Landscape orientation.
2019-01-09 15:14:36 -05:00
Matthew Chen
aefe0eabed
Landscape orientation.
2019-01-09 15:14:36 -05:00
Matthew Chen
045b112724
Landscape orientation.
2019-01-09 15:14:36 -05:00
Matthew Chen
460f160cbb
Landscape orientation.
2019-01-09 15:13:48 -05:00
Michael Kirk
014cf9c500
fix crash on iOS9
2019-01-08 09:55:35 -07:00
Matthew Chen
c30f155221
Fix overzealous assert.
2019-01-07 17:04:54 -05:00
Matthew Chen
7df17251a2
Fix edge cases in conversation view scroll continuity.
2019-01-07 15:37:31 -05:00
Matthew Chen
b92051c881
Fix edge cases in conversation view scroll continuity.
2019-01-07 15:37:31 -05:00
Matthew Chen
6b881b9efe
Fix edge cases in conversation view scroll continuity.
2019-01-07 15:37:31 -05:00
Matthew Chen
f90e49226d
Respond to CR.
2019-01-07 12:47:15 -05:00
Matthew Chen
73f5d9237d
Avoid overflow.
2019-01-07 12:47:15 -05:00
Matthew Chen
f32edc93e4
Tweak conversation view animations.
2019-01-07 12:47:15 -05:00
Matthew Chen
435379926a
Introduce conversation view mapping; rework conversation view scrolling.
2019-01-07 12:47:15 -05:00
Matthew Chen
c5b0c73055
Introduce conversation view mapping; rework conversation view scrolling.
2019-01-07 12:47:15 -05:00
Matthew Chen
c775dbcd66
Introduce conversation view mapping; rework conversation view scrolling.
2019-01-07 12:47:15 -05:00
Matthew Chen
449633e0dc
Respond to CR.
2019-01-04 09:19:41 -05:00
Matthew Chen
fc8fbebd97
Note to Self.
2019-01-03 18:06:56 -05:00
Matthew Chen
e52feb3c36
Note to Self.
2019-01-03 18:06:56 -05:00
Matthew Chen
4a84a19d00
Merge tag '2.33.0.11'
2019-01-02 17:24:07 -05:00
Michael Kirk
049b858125
Fix crash when update corresponds to a move.
...
reloading during performBatchUpdates requires the *original* indexPath, not the
new index path.
2019-01-02 16:42:48 -05:00
Michael Kirk
df79fc9ed0
Move String+OWS into SSK
...
name Switcharoo String+OWS/String+SSK categories to reflect where they live.
2018-12-20 09:54:08 -07:00
Michael Kirk
af7ee5e1d1
address compiler breakage after rebase
2018-12-19 15:16:36 -07:00
Michael Kirk
5671fd2520
Revert "Revert 'new sort id'."
...
This reverts commit ebae75af00
.
2018-12-19 15:16:36 -07:00
Matthew Chen
039755c0df
Respond to CR.
2018-12-18 13:35:49 -05:00
Matthew Chen
f2d585f439
Always allow long-press for message actions.
2018-12-18 13:34:08 -05:00
Michael Kirk
f51416b2d2
save a few ms on send, hoist async dispatch to caller, and use it for clearing draft
2018-12-17 14:44:34 -07:00
Michael Kirk
6232b1ef67
CR: add debug asserts
2018-12-17 14:43:50 -07:00
Michael Kirk
81bc357bbb
more robust handling of unsaved outgoing messages
2018-12-17 14:43:50 -07:00
Michael Kirk
62cf05cd8b
assert only trivial unsaved messages are appended to the view model
2018-12-17 14:43:50 -07:00
Michael Kirk
087e320036
Track 'persisted' viewItems separately
2018-12-17 14:43:50 -07:00
Michael Kirk
e3610d4360
Apply other requisite ViewItem attributes
2018-12-17 14:43:50 -07:00
Michael Kirk
0ae4821950
always put typing indicator last
2018-12-17 14:43:50 -07:00
Michael Kirk
668cc22af3
Perf: Insert outgoing message into conversation before save completes.
...
This was a huge savings - e.g. 50-70% of the time between tapping send and
rendering the message takes place in the save/postWriteTransaction blocks
2018-12-17 14:43:50 -07:00
Michael Kirk
67cc1027cc
Fix compiler warnings
2018-12-17 14:43:21 -07:00
Michael Kirk
4b84583de8
reload input bar async
2018-12-13 14:32:27 -07:00
Michael Kirk
ac2c9cc521
Benchmark Events by ID
2018-12-13 14:32:27 -07:00
Matthew Chen
9c46ce8662
Re-enable prefetching a bit sooner.
2018-12-13 14:34:08 -05:00
Matthew Chen
6797d43510
Auto-extend conversation load window size.
2018-12-13 14:28:49 -05:00
Matthew Chen
8a6f30518a
Auto-extend conversation load window size.
2018-12-13 14:28:49 -05:00
Matthew Chen
6bc8f6d3a3
More perf tweaks for conversation view.
2018-12-13 13:32:00 -05:00
Matthew Chen
2bf0c55ab0
More perf tweaks for conversation view.
2018-12-13 13:32:00 -05:00
Matthew Chen
be8a61b559
Refine contact offers logic.
2018-12-13 11:50:55 -05:00
Matthew Chen
19a2bfeaad
More conversation viewmodel perf improvements.
2018-12-13 11:50:55 -05:00
Matthew Chen
b0295b736b
Add ReverseDispatchQueue.
2018-12-13 11:44:29 -05:00
Matthew Chen
85f6d05e0f
Refine view model diffing.
2018-12-13 09:21:13 -05:00
Matthew Chen
90d8fb3d14
Refine view model diffing.
2018-12-13 09:21:13 -05:00
Matthew Chen
9db50bd9e0
Reduce priority of media loads.
2018-12-13 09:16:39 -05:00
Matthew Chen
21ab3fbbcb
Respond to CR.
2018-12-13 09:16:39 -05:00
Matthew Chen
962c1acc9f
Fix "blinking" regression media views.
2018-12-13 09:16:39 -05:00
Matthew Chen
047afe21ae
Fix typo.
2018-12-13 09:16:39 -05:00
Matthew Chen
b9404938c4
Respond to CR.
2018-12-13 09:16:39 -05:00
Matthew Chen
358d97bf5b
Always load conversation media async.
2018-12-13 09:16:39 -05:00
Matthew Chen
ddd6732f74
Revert "Always load conversation media async."
...
This reverts commit 297aa080163cb6eb324b40bae790768ff2fb1721.
2018-12-13 09:16:39 -05:00
Matthew Chen
5cb319a9c8
Always load conversation media async.
2018-12-13 09:16:39 -05:00
Matthew Chen
956859244d
Always load conversation media async.
2018-12-13 09:16:39 -05:00
Matthew Chen
c1578b4b06
Always load conversation media async.
2018-12-13 09:16:39 -05:00
Matthew Chen
fea40d571c
Move contact offers to Conversation view model.
2018-12-13 09:12:41 -05:00
Matthew Chen
15826cec5d
Reduce initial conversation load window size.
2018-12-13 09:09:07 -05:00
Matthew Chen
9017c16e7e
Sort interactions in CVM.
2018-12-13 09:07:49 -05:00
Michael Kirk
78e963404a
remove overzealous assert, since we now sometimes post notification without threadId
2018-12-10 10:04:40 -07:00
Michael Kirk
52e21be656
fix draft scrolling
2018-12-10 10:03:01 -07:00
Matthew Chen
00c6ed2f3c
Tweak scroll down animation behavior in conversation view.
2018-12-10 09:24:18 -05:00
Michael Kirk
eb96eec94a
Merge branch 'release/2.32.0'
2018-12-07 09:55:43 -05:00
Matthew Chen
b88416a931
Apply dark theme changes to media downloads.
2018-12-07 09:12:31 -05:00
Michael Kirk
e834550649
ensure layout invalidated after leaving media landscape
2018-12-06 19:48:32 -05:00
Michael Kirk
694b9ef7e9
Merge tag '2.32.0.20'
2018-12-05 14:08:02 -05:00
Michael Kirk
1a5c47df2f
Fix SAE, limit max attachments
2018-12-05 13:56:34 -05:00
Matthew Chen
6e457e43ca
Clear typing indicators when they are disabled.
2018-12-05 13:31:54 -05:00
Matthew Chen
ee74691e80
Activate lazy restore of attachments.
2018-12-03 22:06:38 -05:00
Michael Kirk
92dd77779c
Merge tag '2.32.0.19'
2018-12-03 16:39:06 -05:00
Matthew Chen
ab9e2c4e11
Ensure quoted replies with attachments are handled properly.
2018-11-30 11:05:55 -07:00
Michael Kirk
fcc4b516a5
fix typo in logging
2018-11-26 12:37:58 -07:00
Michael Kirk
4f0092615a
Support captions *and* independent message body
2018-11-26 12:37:58 -07:00
Matthew Chen
f5ba8048b7
Clean up ahead of PR.
2018-11-21 08:53:15 -08:00
Matthew Chen
e72dafb08e
Use attachment pointers to restore attachments from backup.
2018-11-21 08:53:15 -08:00
Michael Kirk
b87b2522e3
Merge tag '2.32.0.13'
2018-11-16 23:28:51 -06:00
Matthew Chen
910b249112
"Auto load more" async while scrolling.
2018-11-15 22:02:59 -05:00
Matthew Chen
8b24fba095
Add "add more" button to image picker. Provide caption editing continuity.
2018-11-15 14:10:19 -05:00
Michael Kirk
87bfdbb72c
Sender Rail
2018-11-15 12:25:28 -06:00
Matthew Chen
2e50cc1f2d
Respond to CR.
2018-11-13 13:14:24 -05:00
Matthew Chen
84d6f61d53
Fix glitches in conversation media view.
2018-11-13 11:57:16 -05:00
Michael Kirk
fa82d43e6c
put custom image picker behind feature flag
2018-11-12 14:32:43 -06:00
Michael Kirk
97e9871f19
remove unnecessary implicitly unwrapped optional
2018-11-12 09:55:06 -06:00
Michael Kirk
2a1c62f6f5
remove unused delegate method declaration
2018-11-12 09:55:00 -06:00
Michael Kirk
24f97f1229
compiler warning: discard result explicitly
2018-11-12 09:54:42 -06:00
Matthew Chen
6f64a809f3
Tap on album item.
2018-11-09 17:45:29 -05:00
Matthew Chen
b475695f54
Respond to CR.
2018-11-09 13:58:31 -05:00
Matthew Chen
34b4ea377f
Revise media progress views.
2018-11-09 13:49:32 -05:00
Matthew Chen
15c42642e0
Apply invalid and rety assets.
2018-11-09 13:49:32 -05:00
Matthew Chen
9d1579a480
Update caption indicator asset.
2018-11-08 15:49:49 -05:00
Matthew Chen
cd224a1590
Render single media as albums.
2018-11-08 15:44:22 -05:00
Matthew Chen
82fb766c27
Respond to CR.
2018-11-08 15:40:43 -05:00
Matthew Chen
654325c6dc
Add download progress indicators.
2018-11-08 15:35:14 -05:00
Matthew Chen
a26086b303
Show attachment upload progress indicators.
2018-11-08 15:34:03 -05:00
Matthew Chen
c1a5e1e258
Rename to media album.
2018-11-08 15:33:57 -05:00
Matthew Chen
3daf7d4744
Add OWSAttachmentDownloads.
2018-11-08 15:31:00 -05:00
Michael Kirk
42bf267607
fixup plumbing for incoming messages/synced transcripts
2018-11-08 12:52:09 -06:00
Michael Kirk
57681bd6f3
Gallery supports album messages
2018-11-08 12:52:09 -06:00
Matthew Chen
02a9cc9181
Remove stroke on album items.
2018-11-08 13:46:02 -05:00
Matthew Chen
9a44f24bc1
Reduce typing indicators.
2018-11-07 14:31:47 -05:00
Matthew Chen
f382cd770e
Fix build break.
2018-11-07 12:32:30 -05:00
Matthew Chen
777e2b9251
Rename to media album.
2018-11-07 12:26:57 -05:00
Matthew Chen
2dfd4b2c0d
Rename to media album.
2018-11-07 12:24:53 -05:00
Michael Kirk
3ff3779f17
CR: remove unnecessary assert
2018-11-07 10:12:50 -06:00
Matthew Chen
c7c02f03d1
Display caption indicators for media albums in conversation view.
2018-11-07 11:12:13 -05:00
Michael Kirk
7cef41f8e2
Multi-approval
2018-11-07 10:09:21 -06:00
Matthew Chen
57de089118
Add support for album captions to models.
2018-11-07 10:54:17 -05:00
Matthew Chen
60c5a84dd2
Fix issues in media gallery cells; Improve debug galleries.
2018-11-07 09:56:49 -05:00
Matthew Chen
88a1186e4e
Restore XCode 9 compatability.
2018-11-07 09:56:17 -05:00
Matthew Chen
cdfd2779a3
Fix a couple small bugs in the typing indicators.
2018-11-06 17:21:24 -05:00
Matthew Chen
5aa6467d20
Fix issues in media gallery cells.
2018-11-06 15:35:48 -05:00
Matthew Chen
f45693ec34
Respond to CR.
2018-11-06 15:34:18 -05:00
Matthew Chen
736d7c7351
Fix media gallery cell edge cases.
2018-11-06 15:23:09 -05:00
Matthew Chen
d538301632
Fix media gallery cell edge cases.
2018-11-06 15:23:09 -05:00
Matthew Chen
34e85dd90e
Fix media gallery cell edge cases.
2018-11-06 15:23:09 -05:00
Matthew Chen
ee3bdca336
Fix media gallery cell edge cases.
2018-11-06 15:23:09 -05:00
Matthew Chen
cfcb6cb15b
Clean up ahead of PR.
2018-11-06 15:23:09 -05:00
Matthew Chen
0c76e1c02d
Use ConversationMediaView to simplify media rendering in conversation view cells.
2018-11-06 15:23:09 -05:00
Matthew Chen
f2c0a6f7dd
Clean up ahead of PR.
2018-11-06 15:23:09 -05:00
Matthew Chen
c89bdd2a15
Modify MediaGalleryCellView to handle animated images and videos.
2018-11-06 15:23:09 -05:00
Matthew Chen
2c9a556786
Remove overzealous assert in ConversationViewModel.
2018-11-06 15:23:09 -05:00
Matthew Chen
cf057e3af3
Modify MediaGalleryCellView to handle still images.
2018-11-06 15:23:09 -05:00
Matthew Chen
ec6de40bd9
Modify MessageBubbleView to support media galleries.
2018-11-06 15:23:09 -05:00
Matthew Chen
0341f5dc2b
Modify ConversationViewItem to support media galleries.
2018-11-06 15:23:09 -05:00
Matthew Chen
f2c0985907
Add 'is valid media?' method.
2018-11-06 15:23:09 -05:00
Michael Kirk
4c5d46e8f8
Custom photo picker, respects theme/call banner
...
- share GridViewCell
- Multiple image selection, with feature flag, cant currently approve multiple
2018-11-05 22:23:40 -06:00
Matthew Chen
2ca32fddcc
Preserve ordering in incremental diffs.
2018-11-05 16:53:39 -05:00
Matthew Chen
aa5e6b456e
Preserve ordering in incremental diffs.
2018-11-05 16:53:39 -05:00
Matthew Chen
af249de681
Fix race in CVM startup.
2018-11-05 09:02:05 -05:00
Matthew Chen
47fda2e377
Add debug UI for multi-image sends.
2018-11-02 13:04:05 -04:00
Matthew Chen
ecba67b511
Add debug UI for multi-image sends.
2018-11-02 13:04:05 -04:00
Matthew Chen
22c922bf5b
Respond to CR.
2018-11-01 16:44:47 -04:00
Matthew Chen
650469c6a7
Respond to CR.
2018-11-01 16:44:47 -04:00
Matthew Chen
4088bebe05
Clean up ahead of PR.
2018-11-01 16:44:47 -04:00
Matthew Chen
94eaed0024
Fix rebase breakage.
2018-11-01 16:44:47 -04:00
Matthew Chen
37ae4ef360
Add typing indicator animation.
2018-11-01 16:44:47 -04:00
Matthew Chen
63d88ef5cb
Sketch out TypingIndicatorCell.
2018-11-01 16:44:47 -04:00
Matthew Chen
eedc9f9a26
Sketch out "typing indicators" interaction and cell.
2018-11-01 16:44:47 -04:00
Michael Kirk
77bd9b8852
Extract most Gallery functionality from the gallery NavigationController.
...
By not overriding the initializer for an OWSNavigationController subclass,
we can use the dynamic disaptch intialization chain.
The root difficulty here is that super.init(navBarClass:) wants to call
self.init(nibNam)
2018-11-01 12:53:59 -06:00
Matthew Chen
834bba8880
Respond to CR.
2018-11-01 14:51:47 -04:00
Matthew Chen
32d3eed7ba
Add ConversationViewModel.
2018-11-01 14:51:47 -04:00
Matthew Chen
3d0e7386a4
Respond to CR.
2018-10-31 12:19:07 -04:00
Matthew Chen
a98c82645c
Start work on typing indicators.
...
* Update proto schema to reflect typing indicators.
* Sketch out OWSTypingIndicatorMessage.
* Add "online" to the service message params.
* Sketch out logic to send typing indicator messages.
* Sketch out OWSTypingIndicators class.
2018-10-31 12:11:29 -04:00
Matthew Chen
40aa78e001
Merge remote-tracking branch 'origin/release/2.31.0'
2018-10-31 11:42:41 -04:00
Michael Kirk
3d9cd4f4ed
CR: comments and code clarity
2018-10-30 11:35:34 -06:00
Michael Kirk
cb9aa6304c
find -E . -type f -regex ".*\.(m|h)" -exec sed -i "" -e "s/try_/throws_/" {} \;
2018-10-30 11:35:34 -06:00
Michael Kirk
3a6aafc454
Swift Exception wrap NSData+keyVersionByte
2018-10-30 11:35:34 -06:00
Michael Kirk
3560f3be5c
Durable send operation
...
TODO
-[x] respect order of queue
-[x] replacements
-[x] those w/o completion handler
-[x] basic send+log operation persists
-[x] send+ui completion
-[x] share extension
-[x] update state jobs
-[x] App Lifecyle
-[x] settable
-[x] Mark as ready on startup
-[x] Fail appropriate jobs on startup
NICE TO HAVE
-[x] concurrent per senders
-[ ] longer retry (e.g. 24hrs)
-[ ] App Lifecyle
-[x] retry failed jobs on startup?
-[ ] reachability
DONE
-[x] basic passing test
-[x] datamodel
-[x] queue/classes
2018-10-25 11:54:59 -06:00
Michael Kirk
e20df022c8
always show footer for in-progress sending
2018-10-25 11:54:58 -06:00
Michael Kirk
ce9ca1bdaa
audio player type
2018-10-24 07:46:27 -06:00
Michael Kirk
3b4188f34b
hoist audio session singleton to Environment
2018-10-24 07:46:25 -06:00
Michael Kirk
3d022adf4e
WIP: audio activities
2018-10-24 07:44:50 -06:00
Matthew Chen
0b4ed1175d
Create AppEnvironment.
2018-10-15 15:08:37 -04:00
Matthew Chen
f1d93d4472
Merge remote-tracking branch 'origin/release/2.30.2'
2018-10-12 16:00:42 -04:00
Matthew Chen
0b41e5e240
Rework profile fetch to reflect UD changes.
2018-10-04 11:56:37 -04:00
Michael Kirk
f243914fe5
NSTemporaryDirectory -> OWSTemporaryDirectory/AccessibleAfterFirstAuth
...
Remove redundant move - AFNetworking alread moves the CFNetwork tmp file for
us.
2018-10-03 14:01:36 -06:00
Michael Kirk
006021ea41
Fix: group color change doesn't immediately apply
...
Because we were fetching a new thread instance, instead of updating the
existing thread instance, classes which were bound to the old thread instance
weren't updating. This affected the HeaderView.AvatarView.thread and the
ConversationStyle.thread.
2018-10-01 17:06:09 -06:00
Matthew Chen
0125535d4d
Pull out SignalCoreKit.
2018-10-01 09:06:40 -04:00
Michael Kirk
06eae47e09
ConversationViewItem -> protocol
2018-09-28 12:58:33 -06:00
Matthew Chen
ebae75af00
Revert 'new sort id'.
2018-09-27 19:40:51 -04:00
Joshua Lund
97d0543cef
String cleanup:
...
* Made our Title Case usage a little more consistent.
* Standardized on the ellipses special character.
* Rephrased a few buttons and descriptions.
2018-09-27 15:30:58 -04:00
Michael Kirk
79add78d51
Merge branch 'release/2.30.1'
2018-09-27 13:03:35 -06:00
Matthew Chen
1c1d305a71
Respond to CR.
2018-09-27 11:42:32 -04:00
Matthew Chen
cbaf40d4ce
Respond to CR.
2018-09-27 09:52:12 -04:00
Matthew Chen
d161e5ff3d
Add inner shadows to media thumbnails.
2018-09-27 09:42:29 -04:00
Matthew Chen
b3ad6e27dc
Rework conversation message bubble colors; add "conversation colors" class.
2018-09-27 09:07:47 -04:00
Matthew Chen
25d56b30c1
Rework group avatars to reflect conversation colors.
2018-09-27 08:55:20 -04:00
Michael Kirk
c21020d7e7
Use received date for footer-collapse supression
2018-09-26 09:52:34 -06:00
Michael Kirk
6f8eddc955
unread indicator uses sortId
...
- removed timestamp parameter. This wasn't totally obvious, previously we were tracking two pieces of state
1. `unreadIndicator.firstUnseenTimestamp`:
the first unseen timestamp for a conversation that exists in the database
2. `unreadIndicator.timestamp`:
the timestamp of the first interaction *after* the unread indicator that fits in the loading window
We don't actually need to track `2` because it was only used in a comparison like:
viewItem.interaction.timestampForSorting >= unreadIndicator.timestamp
But by definition, unreadIndicator.firstUnseenTimestamp is always less than or
equal to unreadIndicator.timestamp. Put into terms of the `sortId` corallary,
the sortId of the first unseen interaction in the database is always less than
or equal to the sortId of the first unseen interaction that fits in the loading
window.
In other words, there's no situation where
viewItem.interaction.sortId >= unreadIndicator.firstUnseenSortId
2018-09-26 09:52:34 -06:00
Michael Kirk
3240e0d9d0
Be explicit about receivedAt time
...
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.
In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
2018-09-26 09:52:34 -06:00
Michael Kirk
b281b37637
replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
...
Update migration accordingly
Date shown on home view cell is message.receivedAt
2018-09-26 09:52:34 -06:00
Michael Kirk
90aa593dcd
sortId vs. Read status
2018-09-26 09:52:33 -06:00
Michael Kirk
d6d6c4fca4
ConversationVC - lastSeenSortId
2018-09-26 09:52:33 -06:00
Michael Kirk
ab55e85304
step 1: timestampForSorting audit, change signature
...
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
2018-09-26 09:52:33 -06:00
Michael Kirk
df61316495
minimize diff senderTimestamp -> timestamp
2018-09-26 09:52:33 -06:00
Michael Kirk
00d0d1e002
Remove legacy Error backdating - no changes in functionality
...
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.
I also audited that all other error messages are saved directly after creation.
I applied deprecation attributes as appropriate as I audited.
2018-09-26 09:52:33 -06:00
Michael Kirk
eef1368ad3
Timestamp audit step1: change signature
...
There is no change in functionality in this commit.
Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.
For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
2018-09-26 09:52:33 -06:00
Matthew Chen
72562920ed
Fix author conversation colors.
2018-09-26 09:19:12 -04:00
Matthew Chen
4186ce9a72
Respond to CR.
2018-09-25 17:05:26 -04:00
Matthew Chen
7b2dd19fb8
Respond to CR.
2018-09-25 16:11:37 -04:00
Matthew Chen
ae84528dc3
Update avatar colors; add shaded conversation color constants, modify color picker to be color-name-based, not color-based, use shaded conversation colors, remove JSQ.
2018-09-25 16:11:37 -04:00