Commit graph

4544 commits

Author SHA1 Message Date
Matthew Chen 39c6b5fd7b Merge branch 'charlesmchen/refineAttachmentApproval' 2017-10-24 09:42:43 -04:00
Matthew Chen c1f35a0ea6 Respond to CR.
// FREEBIE
2017-10-24 09:42:29 -04:00
Matthew Chen bf8d694eb4 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Matthew Chen 2fa3cf1bc6 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Matthew Chen cbb0030b12 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Matthew Chen d04f9111db Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Michael Kirk 1fee5d97e6 Merge branch 'release/2.18.0' 2017-10-23 16:02:11 -07:00
Michael Kirk efd58022d0 bump version
// FREEBIE
2017-10-23 16:01:37 -07:00
Michael Kirk 288b975a17 Pull latest translations
// FREEBIE
2017-10-23 16:00:52 -07:00
Matthew Chen 688f77b7dc Merge branch 'charlesmchen/fixAudioAndGenericMessageLayout' 2017-10-23 17:35:43 -04:00
Matthew Chen a1d8c7765d Respond to CR.
// FREEBIE
2017-10-23 17:35:35 -04:00
Matthew Chen 54c56f1c4b Fix layout of generic and audio messages.
// FREEBIE
2017-10-23 17:30:56 -04:00
Matthew Chen 92883c3a98 Merge branch 'charlesmchen/jsqRewriteGlitches' 2017-10-23 17:30:20 -04:00
Matthew Chen a16197f193 Respond to CR.
// FREEBIE
2017-10-23 17:30:03 -04:00
Matthew Chen b1b0ddbf2e Fix layout glitches in JSQ rewrite.
// FREEBIE
2017-10-23 17:25:34 -04:00
Michael Kirk 2067b395bf Merge branch 'mkirk/show-failed-footer' 2017-10-23 14:10:07 -07:00
Michael Kirk 21df2dc047 Never hide "failed to send" footer
// FREEBIE
2017-10-23 08:40:26 -07:00
Michael Kirk 46dd30e630 Merge branch 'dastmetz-accessibilityCallScreen' 2017-10-23 07:54:16 -07:00
Daniel e8f92ede60 added accessibility labels for call screen controls FREEBIE
Added Prefix

combined similar labels to CALL_VIEW_MUTE_LABEL
2017-10-23 07:53:23 -07:00
Michael Kirk 1a9186410e Merge branch 'mkirk/use-failed-color' 2017-10-21 19:00:08 -07:00
Michael Kirk bd4b4f0041 Use proper color when messages fail to send.
// FREEBIE
2017-10-21 18:59:21 -07:00
Michael Kirk 8b1bea8d12 Merge branch 'mkirk/cleanup-after-db-registration' 2017-10-21 18:53:36 -07:00
Michael Kirk c5244e175e orphan cleanup shouldn't happen until DB is registered
// FREEBIE
2017-10-21 18:16:52 -07:00
Michael Kirk f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons."
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
2017-10-20 16:37:07 -07:00
Michael Kirk 66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 2017-10-20 16:23:58 -07:00
Michael Kirk 2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 2017-10-20 16:23:10 -07:00
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 2017-10-20 16:10:07 -07:00
Matthew Chen e427d25c5a Bump build to 2.18.0.3.
// FREEBIE
2017-10-20 17:53:17 -04:00
Matthew Chen 8fdc980cad Update l10n strings.
// FREEBIE
2017-10-20 17:53:07 -04:00
Matthew Chen bdb2890801 Merge branch 'charlesmchen/gifProxy' into release/2.18.0 2017-10-20 16:22:14 -04:00
Matthew Chen c11b82ba30 Respond to CR.
// FREEBIE
2017-10-20 16:21:52 -04:00
Matthew Chen bfde3142ca Merge branch 'charlesmchen/fixMarkAsRead' 2017-10-20 16:14:36 -04:00
Matthew Chen 9274d7fd9b Fix proxying of Giphy requests.
// FREEBIE
2017-10-20 16:12:11 -04:00
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
2017-10-20 12:35:21 -07:00
Michael Kirk b6c9a2a67f Merge branch 'mkirk/gif-data' into release/2.18.0 2017-10-20 12:35:04 -07:00
Michael Kirk 64c7c40b81 CR: add shadow to activity indicator
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 2af99eb710 Allow canceling GIF download
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 891cc6ee0d CR: better method names
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 6eaa49593d preview vs. sending have independent resolution min
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 688810c267 CR: Enforce "one time only" with a bool, not a cell ref
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 591cba6468 fix comment typos
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk a01de44917 Fix intermittent crash
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 6db5895269 dismiss keyboard when scrolling after auto-search
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk be51776d82 Fix mask appearing partially above search bar
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 37177de7cb Make sure user knows what they're picking
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 3939e8a6ac Download picked GIF faster: cancel pending request
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk b8ce636afc Show loading screen while selected GIF downloads
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk 2a4c6506fb log giphy data usage in debug
// FREEBIE
2017-10-20 12:34:55 -07:00