Commit graph

5801 commits

Author SHA1 Message Date
Michael Kirk 75e3516ebc Merge branch 'mkirk/callKitPrivacyVsiOS11' 2018-02-26 15:21:32 -05:00
Michael Kirk 658b8c3223 CR: typos and doc changes
// FREEBIE
2018-02-26 15:19:52 -05:00
Michael Kirk 5959cdf070 Simplify call privacy settings
We've long allowed users to configure what shows up in message
notifications:

- name: content (by default)
- just name (no content)
- generic notification (no name nor content)

Now we're dual purposing that setting to apply to calls. If someone
doesn't want to show names in the message notifications, presumably also
don't want that name showing up in the call log.

Also, since the earlier CallKit/iCloud issues had been addressed before
iOS11, we upgrade all iOS11 users to the more intuitive CallKit
interface.

Also: introduce "use system call logs" toggle when available. It will be
enabled by default, but we disable it for legacy users who'd explicitly
opted *out* of CallKit.

// FREEBIE
2018-02-26 15:19:52 -05:00
Matthew Chen 5b9ab0cf5d Auto-disable CallKit privacy in iOS 11 and later. 2018-02-26 15:19:25 -05:00
Matthew Chen 775682052c Merge branch 'charlesmchen/customNotificationSounds3' 2018-02-26 15:08:37 -05:00
Matthew Chen 8f22facecc Respond to CR. 2018-02-26 15:07:43 -05:00
Matthew Chen 38ff82ab97 Rebrand OWSAudioPlayer. 2018-02-26 14:47:57 -05:00
Matthew Chen a16c2adda7 Rework conversation settings view. 2018-02-26 14:47:57 -05:00
Matthew Chen 306af29d6f Restore "sonar ping" for "call connecting." 2018-02-26 14:47:57 -05:00
Matthew Chen 32b87d0e58 Remove custom ringtones. 2018-02-26 14:47:57 -05:00
Matthew Chen efeb00643c Add title for the mute section in conversation settings view. 2018-02-26 14:46:17 -05:00
Matthew Chen e54cf313e8 Use quiet versions of the notification sounds in foreground. 2018-02-26 14:46:17 -05:00
Matthew Chen 55b9aa4089 Preserve 'classic' Signal notification and ringtone for legacy users. 2018-02-26 14:46:17 -05:00
Matthew Chen 390cf3c80a Revive the 'classic' Signal notification and ringtone. 2018-02-26 14:46:17 -05:00
Matthew Chen ed95eec769 Preview sound settings in app settings and conversation settings views. 2018-02-26 14:46:17 -05:00
Matthew Chen 62af7ddc15 Add "none" option for sounds. Use AVPlayer for everything. 2018-02-26 14:46:17 -05:00
Matthew Chen 57ccde44f0 Merge branch 'charlesmchen/duplicateTimestampFail' 2018-02-26 14:45:38 -05:00
Matthew Chen ad78b1ea53 Convert duplicate timestamp fail to log. 2018-02-26 14:45:32 -05:00
Matthew Chen 42e1369596 Merge branch 'charlesmchen/iOS9minimum' 2018-02-26 14:14:38 -05:00
Matthew Chen 2c15606923 Respond to CR. 2018-02-26 14:14:19 -05:00
Matthew Chen 99aedca45f Strip out special casing for pre-iOS 9 users. 2018-02-26 14:13:38 -05:00
Matthew Chen 44e38709d6 Update minimum iOS version to 9.0. 2018-02-26 14:13:38 -05:00
Matthew Chen 710d164186 Update minimum iOS version to 9.0. 2018-02-26 14:13:38 -05:00
Michael Kirk f0e1cea27c Merge branch 'mkirk/send-ice-updates-immediately' 2018-02-23 17:36:17 -05:00
Michael Kirk 5f305f844f Send ICE updates immediately after sending CallOffer for faster call
connection.

For legacy reasons, the call sender used to wait until after receiving
the call answer before sending the ICE updates. The primary motivation
was that if the receiving user hadn't accepted a new identity change,
rather than just seeing one "Tap to Accept New Safety Number" messages
for a call, they'd see one for the call offer and then a dozen more as
ICE updates trickled in.

We changed that behavior long ago, and effectively all clients will
avoid that case, while sending ICE updates immediately will allow calls
to connect without having to wait for an additional serialized round
trip between the caller and call recipient.

// FREEBIE
2018-02-23 17:36:07 -05:00
Michael Kirk 76aee05817 Merge branch 'mkirk/dont-send-sender-read-receipts-to-self' 2018-02-23 13:50:43 -05:00
Michael Kirk b79244affa Don't enqueue sender read receipts from self-sent messages
These messages are always already read.

Reminder, there are two types of read receipts:

1. One informs our linked devices that we've read a message on another
device.
2. The other informs the sender that we've read their message.

This change is about the latter, we'll continue to send the former to
ourself.

The proximate cause for this change was a failing assert in
OWSMessageSender#handleSendToMyself:(TSOutgoingMessage *)outgoingMessage

The assert was failing because we were sending a message to ourself
which had no body or attachment (the sender-read receipt). Rather than
filtering them out from the message sender, we should never ask the
message sender to do nonsense work (send a senderReadReceipt to ourself)

// FREEBIE
2018-02-23 13:50:40 -05:00
Michael Kirk c66fb70b2f Merge branch 'mkirk/use-contact-ringtones' 2018-02-23 13:49:11 -05:00
Michael Kirk e8c5509f3a Respect system contact ringtones
If CallKit privacy is enabled, we'll always use the system default
ringer.

If CallKit privacy is *not* enabled we'll use any ringtone specified in
the for that contact in the address book, else fall back to the default

// FREEBIE
2018-02-23 13:43:23 -05:00
Matthew Chen f7935bc363 Merge branch 'charlesmchen/customNotificationSounds2' 2018-02-23 12:54:24 -05:00
Matthew Chen 6c8a8fa098 Add new "note" audio asset for fallback push notifications. 2018-02-23 12:53:43 -05:00
Matthew Chen 0c20f2215a Improve sound settings view. 2018-02-23 12:53:43 -05:00
Matthew Chen e0144dab5f Improve sound settings view. 2018-02-23 12:53:43 -05:00
Matthew Chen 899799af92 Improve sound settings view. 2018-02-23 12:53:43 -05:00
Matthew Chen 5e8f3086de Update call sounds. 2018-02-23 12:53:43 -05:00
Matthew Chen a0f4723fa2 Update call sounds. 2018-02-23 12:53:43 -05:00
Matthew Chen a44a117612 Add custom ringtone sounds. 2018-02-23 12:53:43 -05:00
Matthew Chen cd32895657 Add UI for editing per-thread notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 396fe82707 Add UI for editing per-thread notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen dc8b8ca0bd Add per-thread custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 9aa02489b8 Custom notification sounds in local notifications. 2018-02-23 12:53:42 -05:00
Matthew Chen a837c5d41b Custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 60d839d7a4 Custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 5c3f6b0ee5 Custom notification sounds. 2018-02-23 12:53:42 -05:00
Matthew Chen 3d892abc46 "Bump build to 2.21.0.0." 2018-02-23 12:29:24 -05:00
Matthew Chen 03bea4fd8b "Bump build to 2.20.0.42." 2018-02-23 10:21:39 -05:00
Matthew Chen 9e3aa77fc6 Update l10n strings. 2018-02-23 10:21:33 -05:00
Matthew Chen cf39181d05 Merge branch 'mkirk/freeze-after-dismiss' 2018-02-23 10:19:53 -05:00
Michael Kirk 5af1123219 Fix freeze in host app after "dismissing" select thread VC
We must call these completion handlers whenever we exit the SAE

// FREEBIE
2018-02-23 10:15:34 -05:00
Matthew Chen 01cde6740c "Bump build to 2.20.0.41." 2018-02-22 16:43:11 -05:00