Commit graph

9911 commits

Author SHA1 Message Date
Michael Kirk 7aad3a9e7a Avoid spurious crash reporting 2018-11-27 10:47:40 -07:00
Michael Kirk 2c344f6a5b Merge branch 'mkirk/photopicker-design' 2018-11-27 10:27:25 -07:00
Michael Kirk 9bcc6a6c57 show navbar for photo/album picker, not approval 2018-11-27 10:27:13 -07:00
Matthew Chen 753c88437f Merge branch 'charlesmchen/iCloudVsMultipleBackups' 2018-11-27 09:43:45 -05:00
Matthew Chen 1c012e9a23 Respond to CR. 2018-11-27 09:43:32 -05:00
Matthew Chen e23773ed2c Support multiple backups in single iCloud account. 2018-11-27 09:25:16 -05:00
Matthew Chen c86518e44c Support multiple backups in single iCloud account. 2018-11-27 09:25:16 -05:00
Matthew Chen df25301d57 Merge branch 'charlesmchen/longLivedBackup' 2018-11-27 09:23:43 -05:00
Matthew Chen 7fab42abf4 Use long-lived operations for CK backup. 2018-11-27 09:23:31 -05:00
Matthew Chen 0eafb8dc34 Use long-lived operations for CK backup. 2018-11-27 09:23:31 -05:00
Matthew Chen ba3a1863da Use long-lived operations for CK backup. 2018-11-27 09:23:31 -05:00
Matthew Chen 018fe6cb42 Merge branch 'charlesmchen/backupRestoreView' 2018-11-27 09:22:41 -05:00
Matthew Chen e3363ab9a1 Add isRegisteredAndReady to TSAccountManager. 2018-11-27 09:21:44 -05:00
Matthew Chen 8ad58e3357 Respond to CR. 2018-11-27 09:21:44 -05:00
Matthew Chen dcaaff7eac Add isRegisteredAndReady to TSAccountManager. 2018-11-27 09:21:44 -05:00
Matthew Chen 70b2280aa7 Add isRegisteredAndReady to TSAccountManager. 2018-11-27 09:21:44 -05:00
Matthew Chen 8110e0c765 Clean up usage of TSAccountManager. 2018-11-27 09:21:44 -05:00
Matthew Chen d44a8f9996 Sketch out the backup restore view. 2018-11-27 09:21:44 -05:00
Matthew Chen 156aa8419f Clean up ahead of PR. 2018-11-27 09:21:44 -05:00
Matthew Chen 4ee0958384 Sketch out the backup restore view. 2018-11-27 09:21:44 -05:00
Matthew Chen 56fe3663e6 Fix retain cycle in settings views. 2018-11-27 09:21:44 -05:00
Matthew Chen f40b81ca4c Sketch out the backup restore view. 2018-11-27 09:21:44 -05:00
Matthew Chen 03f598a130 Sketch out the backup restore view. 2018-11-27 09:21:44 -05:00
Matthew Chen 332f202a52 Sketch out the backup restore view. 2018-11-27 09:21:44 -05:00
Matthew Chen 5010b027b1 Sketch out the backup restore view. 2018-11-27 09:21:44 -05:00
Matthew Chen 5c0d98b83a Show 'restore backup' view after registration. 2018-11-27 09:21:44 -05:00
Michael Kirk b2d75eb1ae "Bump build to 2.33.0.0." 2018-11-26 14:59:23 -07:00
Michael Kirk d7f94b6d16 Merge branch 'mkirk/fix-resign-animation' 2018-11-26 14:58:57 -07:00
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 2018-11-26 14:11:13 -07:00
Michael Kirk 78c74d87bc Merge tag '2.32.0.16' 2018-11-26 13:03:27 -07:00
Michael Kirk d9942aa5eb Merge branch 'mkirk/multisend-design' 2018-11-26 12:58:02 -07:00
Michael Kirk 9317ee9c99 design comment 2018-11-26 12:57:50 -07:00
Michael Kirk e3120a5b87 cleanup keyboard animation code 2018-11-26 12:52:05 -07:00
Michael Kirk 0562619ca9 smaller margins between rail images, avoid choppy change as the margin updates
are not being animated smoothly.
2018-11-26 12:43:28 -07:00
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 2018-11-26 12:43:28 -07:00
Michael Kirk 279694e704 keyboard animation cleanup 2018-11-26 12:43:28 -07:00
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 2018-11-26 12:43:28 -07:00
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
2018-11-26 12:43:28 -07:00
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 2018-11-26 12:43:28 -07:00
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
2018-11-26 12:43:28 -07:00
Michael Kirk 838012d1ec Caption length limit and label 2018-11-26 12:43:28 -07:00
Michael Kirk e0f7513df0 white tint for attachment approval textview cursors 2018-11-26 12:43:28 -07:00
Michael Kirk a946ec0056 new icon assets per design 2018-11-26 12:43:28 -07:00
Michael Kirk 8776dd1909 New "add caption" and "done" assets 2018-11-26 12:43:28 -07:00
Michael Kirk feb5a0c444 fix initial CaptionView layout glitch 2018-11-26 12:43:28 -07:00
Michael Kirk e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 2018-11-26 12:43:28 -07:00
Michael Kirk 33750baf67 finally got dismiss-before-swipe 2018-11-26 12:43:28 -07:00
Michael Kirk dd82803a10 second abandoned attempt to require dismiss before page 2018-11-26 12:43:28 -07:00
Michael Kirk b98b3d1fdd WIP: require dismiss before swipe 2018-11-26 12:43:28 -07:00
Michael Kirk 706dd3d0c1 initial layout of keyboard is correct across pages 2018-11-26 12:43:28 -07:00