Commit graph

2603 commits

Author SHA1 Message Date
Matthew Chen
579da1c768 Refine handling of unsafe filename characters. 2018-02-27 09:43:26 -05:00
Matthew Chen
47a6d844c9 Refine handling of unsafe filename characters. 2018-02-27 09:43:26 -05:00
Matthew Chen
7e1ae33167 Refine changes to debug logs. 2018-02-27 09:36:50 -05:00
Matthew Chen
920c2b1d76 Rework log upload. 2018-02-27 09:27:09 -05:00
Matthew Chen
5235f97953 Use background task while migrating. 2018-02-22 16:21:48 -05:00
Matthew Chen
81629a87df Fix build break. 2018-02-22 13:31:41 -05:00
Matthew Chen
152c570900 Respond to CR. 2018-02-22 12:07:11 -05:00
Matthew Chen
03670b4868 Rename the view horizon. 2018-02-22 11:46:08 -05:00
Matthew Chen
fabbe46114 Clean up ahead of PR. 2018-02-22 11:46:08 -05:00
Matthew Chen
4e1e232825 Flush writes from other processes. 2018-02-22 11:46:08 -05:00
Matthew Chen
1ff4f85247 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen
5444fc73b0 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Matthew Chen
2ac7716771 Improve handling of db modifications while conversation view is not observing. 2018-02-22 11:46:08 -05:00
Michael Kirk
e43d0b1b5a Fix "Share" for attachment with caption
// FREEBIE
2018-02-22 10:33:29 -05:00
Michael Kirk
5ba5d3f524 Remove "Share" from edit menu
Showing the share UI conflicts with the conversation views
inputAccessory toolbar.

Specifically:

- the long press menu acquires first responder
- tapping share presents the activity view
- at this point, the input toolbar is hidden
- launching a share extension hides the activity view, presents the
  share extension (could be the Signal share extension or another app's
  share extension)
- the conversation view (which is rendered behind the share extension)
  regains first responder, causing the input toolbar to appear above the
  share extension

One fix would be to re-implement an interface similar UIMenuController,
which does not require mucking with the responder chain, but that's
going to be more involved.

// FREEBIE
2018-02-22 08:57:58 -05:00
Michael Kirk
d7f8c3e9d3 Ensure inputAccessory doesn't obscure the SN alert
This affects iOS 8, 9, and to a lesser degree iOS10.
On iOS11, presenting an alert causes the keyboard/inputAccessoryView to
temporarily dismiss.

// FREEBIE
2018-02-21 16:35:46 -05:00
Michael Kirk
7040437ca6 Handle nil date when formatting
// FREEBIE
2018-02-21 16:35:09 -05:00
Matthew Chen
a4855acf44 Don't clear legacy db password until conversion completes. 2018-02-21 16:20:13 -05:00
Matthew Chen
d91507d897 Improve the robustness of the migration logic. 2018-02-20 17:37:14 -05:00
Matthew Chen
14122dab54 Fix the storage failure alert. 2018-02-20 13:46:37 -05:00
Michael Kirk
6eb1ce682a Debug file browser
// FREEBIE
2018-02-18 16:24:29 -05:00
Michael Kirk
8dfe06e3f2 Ensure audio session is default after call is terminated.
Previously, we were enabling PlayAndRecord when a call ended due to the
CallService observer's "updateVideoTrack" callbacks.

// FREEBIE
2018-02-18 15:35:37 -05:00
Michael Kirk
6eb1951ee6 Don't stop audio until after CallKit audio session is deactivated
// FREEBIE
2018-02-18 15:35:37 -05:00
Michael Kirk
707ab5f5a8 Minimize changes around call audio activity
// FREEBIE
2018-02-16 14:00:15 -08:00
Michael Kirk
4dd1c7813a Instrument calls to ensure audio session is maintained
// FREEBIE
2018-02-16 14:00:15 -08:00
Michael Kirk
abb51b565a Don't de-activate audio sesion when other audio activities are happening
// FREEBIE
2018-02-16 14:00:15 -08:00
Matthew Chen
6935298f6f Improve handling of the not migrated case. 2018-02-16 15:19:24 -05:00
Matthew Chen
ceaf028445 Always scroll to bottom after sending attachments. 2018-02-16 14:06:46 -05:00
Matthew Chen
d648a258d1 Merge branch 'hotfix/2.19.7' 2018-02-16 10:49:52 -05:00
Matthew Chen
abfd333a17 Address Indic script crash. 2018-02-16 10:19:47 -05:00
Matthew Chen
8fdc61c726 Fix failed status messages in message detail view. 2018-02-15 13:44:20 -05:00
Matthew Chen
6f28c75257 Fix glitch in batch processing of incoming messages. 2018-02-14 14:56:47 -05:00
Matthew Chen
4b62faf2f8 Aggressively nag iOS 8 users to upgrade iOS. 2018-02-14 14:15:23 -05:00
Michael Kirk
3d5f7e6bf3 Clean up logging
- tag all log lines for easier filtering
- use up-to-date database path

// FREEBIE
2018-02-14 09:16:42 -08:00
Michael Kirk
c6e5d4369b Don't adjust inset when fully zoomed in.
On iOS11, when looking at the full-screen media details, if you'd zoomed
far enough that the media content is behind the status bar, tapping to
hide the status bar would cause an undesirable change in content offset.

// FREEBIE
2018-02-14 09:05:05 -08:00
Michael Kirk
19eb17b469 Fix bubble layout in message details
TextView size depends on the VC.view size, so it must be updated when
view is done laying out.

// FREEBIE
2018-02-14 09:00:46 -08:00
Matthew Chen
0944c2661e Respond to CR. 2018-02-13 15:03:43 -05:00
Matthew Chen
48b6c3dafb Refine message date/time formatting. 2018-02-13 15:02:29 -05:00
Michael Kirk
a23f1b86ef nullability annotations for TSGroupModel
- add readonly where possible
- group members needn't be a mutable array

// FREEBIE
2018-02-13 09:50:01 -08:00
Michael Kirk
cb8767d19e CR: duplicate comments, DRY
// FREEBIE
2018-02-13 08:29:58 -08:00
Michael Kirk
44678e3951 CR: weak capture and clearer comments
// FREEBIE
2018-02-13 08:29:58 -08:00
Michael Kirk
debd556e09 Fix notification % escaping, debug UI
Consolidated the notifications debug UI (and fixed it) to make testing
this a bit easier.

// FREEBIE
2018-02-13 08:29:58 -08:00
Matthew Chen
e3776015bb Respond to CR. 2018-02-13 10:49:54 -05:00
Matthew Chen
246a56e925 Respond to CR. 2018-02-13 10:49:54 -05:00
Matthew Chen
33686594e9 Tweak debug logging. 2018-02-13 10:49:54 -05:00
Matthew Chen
44cbf142a1 Respond to CR. 2018-02-12 22:41:52 -05:00
Matthew Chen
3e8b08e19b Defer handling app delegate hooks until app is ready. 2018-02-12 22:37:37 -05:00
Matthew Chen
ba42ac73d8 Revisit TODOs in the SAE work. 2018-02-12 22:33:26 -05:00
Matthew Chen
9c8178653d Revisit TODOs in the SAE work. 2018-02-12 22:33:26 -05:00
Matthew Chen
7c199faf8f Respond to CR. 2018-02-12 22:26:35 -05:00