This is part of unforking JSQMVC, but I'm only reformatting files
otherwise changed rather than reformatting the entire project for git
sanity.
This is intentionally a second commit so we can separate formatting
changes from code changes
* brace should drop after method definition (this is common across
almost all objc projects, and allows you to quickly differentiate
multi-line method signatures from their implementation.
* aligning consecutive assignments ongoingly muddies git history
// FREEBIE
Geting back on upstream fixes a couple bugs (see ##Bugfixes), and also
will make future updates easier.
The unforking process was basically this:
* move custom message types (Calls and DisplayedMessages) classes from our
custom JSQMVC fork into Signal-iOS.
* Move any method customization into our subclass. Including
ColletionView stuff, bubble sizing, and gesture behavior
Bug Fixes
---------
* Fix mis-sized incoming media bubbles.
Bubble size was being cached by interaction id. Which broke when
receiving an attachment. The problem is that incoming media messages
were initially the height of a "Downloading Attachment" info message.
Instead we use the mediaHash for media messages to expire the bubble
size when the media changes.
* fix missized bubble when MVC did appear
The MessagesViewController isn't sized correctly until ViewWillAppear.
This caused the first round of bubbles to be rendered incorrectly (they
assumed a larger container than they had). I think is reflected in the
current version of the app by a reflow occurring shortly after the view
appears.
Chores
------
* bump travis to build with xcode8
* specify RQV development team for device build. required by xcode 8 beta
Cleanup
------
* Refactor messageing XIB so that elements are hangning outside of
the views frame
* Fix compiler warning with explicit cast
* delete deprecated lineBreakmode, it's the default value anyway.
// FREEBIE
* Latest SocketRocket includes
* crash fixes.
* our new security policy management, so we don't have to
keep rebasing to incorporate updates.
* Adapt to policy renaming in SignalServiceKit
* bump XCode version to play nice with SWIFT_NAME
// FREEBIE
* compress non-GIF media as JPEG
There are some problems with this approach
- Potentially re-encoding files
- Lots of code in the controller
* Compress GIF > 5MB into static JPEG.
This isn't ideal, but a stopgap to prevent people from sending huge
GIFs, while also giving them *some* kind of feedback (e.g. a static jpeg
is sent rather than their being no indication to sender+recipient that
anything was attempted.)
* spell bmp correctly
// FREEBIE
FIXES#1222
Maybe this code was a vestige of a former way we were customizing the
back button. In any case, it's no longer required for swipe-to-pop
functionality.
// FREEBIE
4% of our crashes are from accessing latestContactsById with an invalid
address. This was partially addressed by assigning a value on init, but
it's still happening.
By converting the ivar to an atomic property we can avoid any funny
business that would happen when accessing this var while it's being
updated in a different thread.
Also, make sure we're copying to defensively strip mutability.
Also:
* bumped release target
* removed unused code
* dealloc at the top per style.
* Fixes "New Message" --> "Invite contact" exception for iPhone devices that do not support SMS messaging
* fix SMS invite on empty inbox
This code appears in two contexts - (1) in an empty inbox , where no other view
controller is presented, and (2) in compose interface where a
search controller is presented, and must first be dismissed.
* only check SMS sending ability directly, (not device model)
This is better because:
1. sometimes iPhones can't send SMS
2. Sometimes iPads/iPods can send SMS
* correct localization key
* bump build
// FREEBIE
* all Signal users can send text messages, never hide texting toolbar.
//FREEBIE
* Fix composition box size when switching threads.
Partial revert of 2c83046ff6 which
introduced a shared reusable message view controller across threads.
2c83046ff6 resulted in several discovered
bugs so far (#1179, #1150, #1152, and maybe: #1146). It's pretty clear
at this point we're going against the grain of how
JSQMesageViewController is intended to be used, and since the nominal
purpose of this feature (iPad Layout) doesn't exist, we should revert to
the known good way of interacting with the MessageViewController,
creating a fresh instance per thread.
// FREEBIE
* bump release
//FREEBIE
* fix invite over sms alert
Could not present the sms invite alert controller because we were
already presenting the UISearchController
FIXES: #1182
// FREEBIE
* Update translations (4 new translations!)
*New Translations*
- Persian (fa) (100%)
- Indonesian (id) (82%)
- Macedonian (Macedonia) (mk_MK) 100%
- Shona (sn) 98%
Inluded a script to pull translations that are >=80% complete
80% is completely arbitrary, but nicely bisects the current translation
efforts which fall into buckets of "over 80%" and "under 50%."
// FREEBIE
* final tx pull before push source
//FREEBIE
* tx pull, after updating source (plus some eager beavers already pushed new translations)
iStringVerify passes
* Make "add person" label more i18n flexible
This accommodates (e.g.) Italian, which was being truncated.
// FREEBIE
* Galician localization
Moitas grazas xesusmosquera!
// FREEBIE
* i18n for Unarchive action
started leaving hints for our translators. These are currently manually
redundantly duplicated in the source/strings file, in hopes of a more
automated future with genstrings.
// FREEBIE
* include iStringsVerify check in update-translations script
and pull latest translations after including UNARCHIVE action
// FREEBIE
* i18n GROUP_MEMBERS_HEADER
//FREEBIE
* pull translations
* Group actions bar button image was too big
Added image inset to resize.
// FREEBIE
* return blue line to neutral gray. (partial revert of 0c1a97a743)
// FREEBIE
* Podfile.lock corollary to updating SSL in b7813bdc9a
// FREEBIE
Since we're now re-using the message controller across threads, we have
to reset some elements to their initial state when switching threads.
Missed this one.
Fixes: #1150
// FREEBIE
* Fix ability to attach photos from camera
Looks like this came about with the animated GIF handling. We'll only
go down the byte-comparison-mime-type-detecting code path for attaching
existing photos, since it only exists for animated GIFs.
This will also revert to properly compressing our image attachments, so
long as they are taken from the camera.
* Prevent crash when tapping broken image
It never makes sense to present a "full screen" nil image. Previously
this happened when camera-capture was broken, but could conceivably
happen for other as-of-yet unknown reasons.
// FREEBIE
*most* of our time when scrolling around a message view is in this
method. Doubly so when these are media items.
remove interaction from cache when it is deleted/updated
// FREEBIE
Since "Key Path" is the header for run time attributes, my guess is that
this was a click misfire so long ago. I'm not clear if this was ever
causing a crash or just a warning, but we don't want the noise.
Fix "Unbalanced calls to begin/end appearance transitions"
You should not segue while animations are in progress. I'm not sure if
this was causing intermittent crashes or just the warning.
//FREEBIE
Closes#1130
- Use single MessagesViewController. Goal: Being able to reuse that UI
for SplitViewController on iPad. Prevents unnecessary deallocations and
re-allocations.
- Remove custom archiving UI for default swipe right to left archive
action, like in iOS Mail.app.
- DynamicType for main view.
- Simplify API of MessagesViewController to prevent undefined behavior.
//FREEBIE
- Using same clang format file for old and new files.
- Moving out all TextSecure code to allow other clients (OS X, iOS) to
integrate easily TextSecure functionality.
- Use TextSecure API to signup.
Implemented using corbett's suggestion in issue #525. Uses
Flipboard/FLAnimatedImage in an AttachmentAdapter. Detects gifs using
new Animated category in MIMETypeUtil.
Backwards compatible with previous versions of Signal on iOS for both
sending and receiving Gifs, though they are sent/received in older
versions as UIImage and won't animate. Gifs also animate on both ends of
conversations with TextSecure users on Android.
//FREEBIE
Michael Kirk
Michael Kirk
Ronny
Arek Banas
Frederic Jacobs
Aayush Ranaut
Mahyar McDonald
Adam Kunicki
Michael Okner
Rui