Commit graph

8618 commits

Author SHA1 Message Date
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
03829779cc Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
c0d486b1f1 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
d81dea1d84 Add OWS log macros. 2018-08-27 12:58:50 -04:00
Matthew Chen
2c60f6f224 Merge branch 'charlesmchen/logSdp' 2018-08-27 10:51:46 -04:00
Matthew Chen
0b5b74a901 Respond to CR. 2018-08-27 10:49:26 -04:00
Matthew Chen
490ac5dd76 Redact ice-pwd from SDP. 2018-08-27 10:49:26 -04:00
Matthew Chen
02daca11af Redact ice-pwd from SDP. 2018-08-27 10:49:26 -04:00
Matthew Chen
b4539328e1 Log call session description. 2018-08-27 10:49:25 -04:00
Matthew Chen
2d06c05a4f Log call session description. 2018-08-27 10:49:25 -04:00
Matthew Chen
329f8d6f45 Log call session description. 2018-08-27 10:49:25 -04:00
Matthew Chen
77711df274 Merge branch 'charlesmchen/prodFail' 2018-08-27 10:33:04 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Matthew Chen
5b50e81b4f Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
Matthew Chen
7be8f30877 Apply -> Never. 2018-08-27 10:21:03 -04:00
Matthew Chen
d01023d862 Respond to CR. 2018-08-27 10:07:14 -04:00
Matthew Chen
11eaf1474e Add OWSProdExit(). 2018-08-27 10:07:14 -04:00
Matthew Chen
202a91680f Merge branch 'charlesmchen/reworkingLogging' 2018-08-27 10:05:27 -04:00
Matthew Chen
16a7361e54 Update Cocoapods. 2018-08-27 10:05:09 -04:00
Matthew Chen
4f2f4a44a0 Respond to CR. 2018-08-27 10:04:27 -04:00
Matthew Chen
d4f7b5d45b Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen
f34bdd34bc Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen
dd4f1babba Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen
e1049fdfcc Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen
bc23e38efc Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen
cf6f3841a8 Apply new Swift logging. 2018-08-27 10:02:28 -04:00
Matthew Chen
3697974ca8 Rework Swift logging. 2018-08-27 10:02:28 -04:00
Michael Kirk
1a92f414eb Revert "Disable dark theme in production."
This reverts commit 472a92a1a3.
2018-08-24 16:22:28 -06:00
Michael Kirk
1d2590fa12 Merge tag '2.29.0.17' 2018-08-24 16:22:07 -06:00
Michael Kirk
65c323440b update translation location 2018-08-24 16:21:42 -06:00
Michael Kirk
1503608f5f Merge branch 'mkirk/faster-presentation' 2018-08-24 08:54:32 -06:00
Michael Kirk
7e8b2e3034 Faster conversation presentation.
There are multiple places in the codebase we present a conversation.

We used to have some very conservative machinery around how this was done, for
fear of failing to present the call view controller, which would have left a
hidden call in the background. We've since addressed that concern more
thoroughly via the separate calling UIWindow.

As such, the remaining presentation machinery is overly complex and inflexible
for what we need.

Sometimes we want to animate-push the conversation. (tap on home, tap on "send message" in contact card/group members)
Sometimes we want to dismiss a modal, to reveal the conversation behind it (contact picker, group creation)
Sometimes we want to present the conversation with no animation (becoming active from a notification)

We also want to ensure that we're never pushing more than one conversation view
controller, which was previously a problem since we were "pushing" a newly
constructed VC in response to these myriad actions. It turned out there were
certain code paths that caused multiple actions to be fired in rapid succession
which pushed multiple ConversationVC's.

The built-in method: `setViewControllers:animated` easily ensures we only have
one ConversationVC on the stack, while being composable enough to faciliate the
various more efficient animations we desire.

The only thing lost with the complex methods is that the naive
`presentViewController:` can fail, e.g. if another view is already presented.
E.g. if an alert appears *just* before the user taps compose, the contact
picker will fail to present.

Since we no longer depend on this for presenting the CallViewController, this
isn't catostrophic, and in fact, arguable preferable, since we want the user to
read and dismiss any alert explicitly.

// FREEBIE
2018-08-24 08:54:23 -06:00
Michael Kirk
ae44b316aa Merge branch 'mkirk/show-message-actions-on-call' 2018-08-23 15:55:18 -06:00
Michael Kirk
bc2ba63c21 DRY refactor 2018-08-23 10:39:55 -06:00
Michael Kirk
37738c24c5 Allow menuActions + callBanner
// FREEBIE
2018-08-23 10:39:55 -06:00
Michael Kirk
495ed56676 Merge branch 'mkirk/cleanup-longview' 2018-08-23 10:39:19 -06:00
Michael Kirk
464b854eb1 CR: follow naming conventions 2018-08-23 10:38:54 -06:00
Michael Kirk
9c9f3875a7 Link styling 2018-08-23 10:38:20 -06:00
Michael Kirk
5148747c12 clean up long text VC 2018-08-23 10:38:20 -06:00
Michael Kirk
c8c2b8c640 Merge branch 'mkirk/swift-assert-main-thread' 2018-08-23 10:36:45 -06:00
Michael Kirk
82e559d11b Use swift macros for main thread assert 2018-08-23 10:29:49 -06:00
Michael Kirk
aabf9e79e8 Merge branch 'mkirk/async-search' 2018-08-23 10:18:31 -06:00
Michael Kirk
781c535327 weak capture self 2018-08-23 10:18:23 -06:00
Michael Kirk
fc7dc03cee don't block main thread during search
// FREEBIE
2018-08-23 10:18:23 -06:00
Michael Kirk
65fe3cc1d2 Merge branch 'mkirk/debug-protos' 2018-08-23 10:16:47 -06:00
Michael Kirk
2fc3a211f1 restrict debug methods 2018-08-23 10:16:40 -06:00
Michael Kirk
1295a09ab3 add comment 2018-08-22 16:25:53 -06:00
Matthew Chen
b75bc27d55 Respond to CR. 2018-08-22 16:37:01 -04:00
Matthew Chen
c6132249e6 Respond to CR. 2018-08-22 16:32:44 -04:00